From 434cfdd6862d69f7cffd2a293d875978cc976b3a Mon Sep 17 00:00:00 2001
From: Ad Schellevis <ad@opnsense.org>
Date: Sun, 2 Jan 2022 19:52:20 +0100
Subject: [PATCH] dns/ddclient - replacement for dyndns using ddclient package

fix typo and username is optional for some services
---
 .../src/opnsense/mvc/app/models/OPNsense/DynDNS/DynDNS.xml    | 2 +-
 .../service/templates/OPNsense/ddclient/ddclient.conf         | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/dns/ddclient/src/opnsense/mvc/app/models/OPNsense/DynDNS/DynDNS.xml b/dns/ddclient/src/opnsense/mvc/app/models/OPNsense/DynDNS/DynDNS.xml
index e9bf53869..c5521211f 100644
--- a/dns/ddclient/src/opnsense/mvc/app/models/OPNsense/DynDNS/DynDNS.xml
+++ b/dns/ddclient/src/opnsense/mvc/app/models/OPNsense/DynDNS/DynDNS.xml
@@ -68,7 +68,7 @@
                     </OptionValues>
                 </service>
                 <username type="TextField">
-                    <Required>Y</Required>
+                    <Required>N</Required>
                     <mask>/^([a-z0-9\-.@_:+])*$/u</mask>
                     <ValidationMessage>The username contains invalid characters.</ValidationMessage>
                 </username>
diff --git a/dns/ddclient/src/opnsense/service/templates/OPNsense/ddclient/ddclient.conf b/dns/ddclient/src/opnsense/service/templates/OPNsense/ddclient/ddclient.conf
index 83ddb549d..a39586583 100644
--- a/dns/ddclient/src/opnsense/service/templates/OPNsense/ddclient/ddclient.conf
+++ b/dns/ddclient/src/opnsense/service/templates/OPNsense/ddclient/ddclient.conf
@@ -60,8 +60,10 @@ ssl=yes
 {%            endif %}
 {%            if account.wildcard|default('0') == '1' %}
 wildcard=yes
-{%            endif}
+{%            endif %}
+{%            if account.username %}
 login={{account.username}}
+{%            endif %}
 password={{account.password}}
 {{account.hostnames}}