From 432a5f10df31f7dcd42fff94f29885d3906ecc7a Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Fri, 20 Nov 2015 00:35:36 +0100
Subject: [PATCH] Mk: properly error out on missing vars

---
 Mk/plugins.mk | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/Mk/plugins.mk b/Mk/plugins.mk
index 14f043e7a..365857b0f 100644
--- a/Mk/plugins.mk
+++ b/Mk/plugins.mk
@@ -33,12 +33,15 @@ PLUGIN_PREFIX=		os-
 LOCALBASE?=		/usr/local
 PKG!=			which pkg || echo true
 
+PLUGIN_REQUIRES=	PLUGIN_NAME PLUGIN_VERSION PLUGIN_COMMENT \
+			PLUGIN_MAINTAINER
+
 check:
-	@[ -n "${PLUGIN_NAME}" ] || echo "PLUGIN_NAME not set"
-	@[ -n "${PLUGIN_VERSION}" ] || echo "PLUGIN_VERSION not set"
-	@[ -n "${PLUGIN_COMMENT}" ] || echo "PLUGIN_COMMENT not set"
-	@[ -n "${PLUGIN_MAINTAINER}" ] || echo "PLUGIN_MAINTAINER not set"
-	# XXX throw an error here
+.for PLUGIN_REQUIRE in ${PLUGIN_REQUIRES}
+.  if "${${PLUGIN_REQUIRE}}" == ""
+.    error "${PLUGIN_REQUIRE} not set"
+.  endif
+.endfor
 
 name: check
 	@echo ${PLUGIN_PREFIX}${PLUGIN_NAME}