From 1c76be9cedda956f24e22909c43b9df357b5d247 Mon Sep 17 00:00:00 2001
From: Michael <m.muenz@gmail.com>
Date: Thu, 1 Nov 2018 07:48:03 +0100
Subject: [PATCH] net/frr: add BGP router-id (#949)

---
 .../mvc/app/controllers/OPNsense/Quagga/forms/bgp.xml      | 7 +++++++
 .../src/opnsense/mvc/app/models/OPNsense/Quagga/BGP.xml    | 4 ++++
 .../opnsense/service/templates/OPNsense/Quagga/bgpd.conf   | 3 +++
 3 files changed, 14 insertions(+)

diff --git a/net/frr/src/opnsense/mvc/app/controllers/OPNsense/Quagga/forms/bgp.xml b/net/frr/src/opnsense/mvc/app/controllers/OPNsense/Quagga/forms/bgp.xml
index 57a680a3c..b0128e5ff 100644
--- a/net/frr/src/opnsense/mvc/app/controllers/OPNsense/Quagga/forms/bgp.xml
+++ b/net/frr/src/opnsense/mvc/app/controllers/OPNsense/Quagga/forms/bgp.xml
@@ -11,6 +11,13 @@
         <type>text</type>
         <help>Your AS Number here</help>
     </field>
+    <field>
+        <id>bgp.routerid</id>
+        <label>Router ID</label>
+        <type>text</type>
+        <advanced>true</advanced>
+        <help>In some cases it might be clearer to set a fixed router-id.</help>
+    </field>
     <field>
         <id>bgp.networks</id>
         <label>Network</label>
diff --git a/net/frr/src/opnsense/mvc/app/models/OPNsense/Quagga/BGP.xml b/net/frr/src/opnsense/mvc/app/models/OPNsense/Quagga/BGP.xml
index b51848094..3f7b30962 100644
--- a/net/frr/src/opnsense/mvc/app/models/OPNsense/Quagga/BGP.xml
+++ b/net/frr/src/opnsense/mvc/app/models/OPNsense/Quagga/BGP.xml
@@ -13,6 +13,10 @@
             <MinimumValue>1</MinimumValue>
             <MaximumValue>4294967295</MaximumValue>
         </asnumber>
+        <routerid type="TextField">
+            <Required>N</Required>
+            <mask>/^\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}$/</mask>
+        </routerid>
         <networks type="CSVListField">
             <default></default>
             <Required>N</Required>
diff --git a/net/frr/src/opnsense/service/templates/OPNsense/Quagga/bgpd.conf b/net/frr/src/opnsense/service/templates/OPNsense/Quagga/bgpd.conf
index 81be578f6..f7820f56a 100644
--- a/net/frr/src/opnsense/service/templates/OPNsense/Quagga/bgpd.conf
+++ b/net/frr/src/opnsense/service/templates/OPNsense/Quagga/bgpd.conf
@@ -17,6 +17,9 @@ log syslog {{ OPNsense.quagga.general.sysloglevel }}
 !
 {% if helpers.exists('OPNsense.quagga.bgp.asnumber') and OPNsense.quagga.bgp.asnumber != '' %}
 router bgp {{ OPNsense.quagga.bgp.asnumber }}
+{%   if helpers.exists('OPNsense.quagga.bgp.routerid') and OPNsense.quagga.bgp.routerid != '' %}
+ bgp router-id {{ OPNsense.quagga.bgp.routerid }}
+{%   endif %} 
 {%   if helpers.exists('OPNsense.quagga.bgp.neighbors.neighbor') %}
 {%     for neighbor in helpers.toList('OPNsense.quagga.bgp.neighbors.neighbor') %}
 {%       if neighbor.enabled == '1' %}