upstream/openvpn
1
0
Fork 0
mirror of https://github.com/OpenVPN/openvpn.git synced 2026-05-28 04:03:29 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix key_state_gen_auth_control_files probably checking file creation

Browse source 
When the auth_failed_reason_file was added, it was forgotten to also add it
to the conditions that determine if the file creation was successful.

Reported-by: Joshua Rogers <contact@joshua.hu>
Found-by: ZeroPath (https://zeropath.com/)
Change-Id: I94d2bdd234a1c416b78924d044bf7e57f1bed8c4
Signed-off-by: Arne Schwabe <arne@rfc2549.org>
Acked-by: Gert Doering <gert@greenie.muc.de>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1327
Message-Id: <20251030193940.1295-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34067.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit 2f8cbf5bc9)
This commit is contained in:
Arne Schwabe 2025-10-30 20:39:34 +01:00 committed by Gert Doering
parent 2aa8550d44
commit da394db747
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/openvpn/ssl_verify.c
View file

@ -998,7 +998,7 @@ key_state_gen_auth_control_files(struct auth_deferred_status *ads,
const char *apf = platform_create_temp_file(opt->tmp_dir, "apf", &gc);
const char *afr = platform_create_temp_file(opt->tmp_dir, "afr", &gc);
if (acf && apf)
if (acf && apf && afr)
{
ads->auth_control_file = string_alloc(acf, NULL);
ads->auth_pending_file = string_alloc(apf, NULL);
@ -1010,7 +1010,7 @@ key_state_gen_auth_control_files(struct auth_deferred_status *ads,
}
gc_free(&gc);
return (acf && apf);
return (acf && apf && afr);
}
/**