From 9beebd0a80663550b187c6e2f54d8b2f6bfaaf25 Mon Sep 17 00:00:00 2001 From: Frank Lichtenheld Date: Mon, 11 May 2026 22:06:39 +0200 Subject: [PATCH] route: Clarify operator precedence in a & b ? c : d As suggested by cppcheck. Change-Id: I5c9b54dca0a14688a3bb7798cb086f5bde7311b8 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1668 Message-Id: <20260511200645.24711-1-gert@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36880.html Signed-off-by: Gert Doering --- src/openvpn/route.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/openvpn/route.c b/src/openvpn/route.c index 3b18f740..81ce8674 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -2884,7 +2884,7 @@ do_route_ipv4_service(const bool add, const struct route_ipv4 *r, const struct t .prefix.ipv4.s_addr = htonl(r->network), .gateway.ipv4.s_addr = htonl(r->gateway), .iface = { .index = if_index, .name = "" }, - .metric = (r->flags & RT_METRIC_DEFINED ? r->metric : -1) }; + .metric = (r->flags & RT_METRIC_DEFINED) ? r->metric : -1 }; netmask_to_netbits(r->network, r->netmask, &msg.prefix_len); if (msg.prefix_len == -1) @@ -2986,7 +2986,7 @@ do_route_ipv6_service(const bool add, const struct route_ipv6 *r, const struct t .prefix_len = r->netbits, .gateway.ipv6 = r->gateway, .iface = { .index = tt->adapter_index, .name = "" }, - .metric = ((r->flags & RT_METRIC_DEFINED) ? r->metric : -1) }; + .metric = (r->flags & RT_METRIC_DEFINED) ? r->metric : -1 }; if (r->adapter_index) /* vpn server special route */ {