From 8d512db3fcfceed73cd302f27c2c7849764c33f6 Mon Sep 17 00:00:00 2001 From: Selva Nair Date: Fri, 24 Apr 2026 18:18:33 +0200 Subject: [PATCH] Fixup: prompting password from management Commit b450414 added logic for reading password from management when not in file or inline, but it was made conditional on `response_from_stdin` which is always true! Fix by explicitly checking for `password_from_stdin`. Github: fixes OpenVPN/openvpn#1021 Change-Id: I4d46c3672691b159cbd98a17020c4f30782bc202 Signed-off-by: Selva Nair Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1638 Message-Id: <20260424161840.5767-1-gert@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36739.html Signed-off-by: Gert Doering (cherry picked from commit 9ac9a41b82aecdb5cb17a3746a7fa50878ec7ee0) --- src/openvpn/misc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/openvpn/misc.c b/src/openvpn/misc.c index 979293ff..10bfc351 100644 --- a/src/openvpn/misc.c +++ b/src/openvpn/misc.c @@ -336,6 +336,7 @@ get_user_pass_cr(struct user_pass *up, const char *auth_file, const char *prefix */ if (management && (flags & GET_USER_PASS_MANAGEMENT) && management_query_user_pass_enabled(management) + && password_from_stdin && !(flags & GET_USER_PASS_USERNAME_ONLY)) { msg(D_LOW,