From 784ba7a2019539db028cd98beaa42e8921394cdf Mon Sep 17 00:00:00 2001 From: Selva Nair Date: Tue, 14 Apr 2026 07:57:14 +0200 Subject: [PATCH] Log when writing username/password to TLS buffer fails Currently we get an unhelpful "Key Method #2 failed" error. Add a more specific warning message. Change-Id: I9468811fd434e17645957fc12770aa2b9ed98fb8 Signed-off-by: Selva Nair Acked-by: Arne Schwabe Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1600 Message-Id: <20260414055721.16857-1-gert@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36604.html Signed-off-by: Gert Doering (cherry picked from commit fd1fd077ea7781be8be6e05f2a2b657619c7e437) --- src/openvpn/ssl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c index 962f5df4..b188b4e9 100644 --- a/src/openvpn/ssl.c +++ b/src/openvpn/ssl.c @@ -2125,10 +2125,12 @@ key_method_2_write(struct buffer *buf, struct tls_multi *multi, struct tls_sessi if (!write_string(buf, up->username, -1)) { + msg(M_WARN, "WARNING: Failed to write auth username to TLS buffer"); goto error; } else if (!write_string(buf, up->password, -1)) { + msg(M_WARN, "WARNING: Failed to write auth password to TLS buffer"); goto error; } /* save username for auth-token which may get pushed later */