upstream/openvpn
1
0
Fork 0
mirror of https://github.com/OpenVPN/openvpn.git synced 2026-05-28 04:03:29 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

test_user_pass: Add UTs for character filtering

Browse source 
For simplicity I implemented them only with the
inline method, but they actually apply to all methods.

Change-Id: Ie8d2d5f6f58679baaf5eb817a7e2ca1afcb8c4db
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Arne Schwabe <arne-openvpn@rfc2549.org>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20240129105358.11161-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/search?l=mid&q=20240129105358.11161-1-gert@greenie.muc.de
Signed-off-by: Gert Doering <gert@greenie.muc.de>
This commit is contained in:
Frank Lichtenheld 2024-01-29 11:53:57 +01:00 committed by Gert Doering
parent b9696ff387
commit 55418bf62e
1 changed files with 23 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
tests/unit_tests/openvpn/test_user_pass.c
View file

@ -141,6 +141,29 @@ test_get_user_pass_inline_creds(void **state)
reset_user_pass(&up);
/* Test various valid characters */
/*FIXME: query_user_exec() called even though nothing queued */
will_return(query_user_exec_builtin, true);
/* FIXME? content after first two lines just ignored */
assert_true(get_user_pass_cr(&up, "#iuser and 커뮤니티\n//ipasswörd!\nsome other content\nnot relevant", "UT", flags, NULL));
assert_true(up.defined);
assert_string_equal(up.username, "#iuser and 커뮤니티");
assert_string_equal(up.password, "//ipasswörd!");
reset_user_pass(&up);
/* Test various invalid characters */
/*FIXME: query_user_exec() called even though nothing queued */
will_return(query_user_exec_builtin, true);
/*FIXME? allows arbitrary crap if c > 127 */
/*FIXME? silently removes control characters */
assert_true(get_user_pass_cr(&up, "\tiuser\r\nipass\xffwo\x1erd", "UT", flags, NULL));
assert_true(up.defined);
assert_string_equal(up.username, "iuser");
assert_string_equal(up.password, "ipass\xffword");
reset_user_pass(&up);
expect_string(query_user_exec_builtin, query_user[i].prompt, "Enter UT Password:");
will_return(query_user_exec_builtin, "cpassword");
will_return(query_user_exec_builtin, true);