pool: convert pool 'type' to enum

The pool 'type' member is actually an enumered type, therefore
declare it as 'enum' to improve static code analisys and
readability.

Signed-off-by: Antonio Quartulli <antonio@openvpn.net>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20180608052017.6696-4-a@unstable.cc>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17000.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
This commit is contained in:
Antonio Quartulli 2018-06-08 13:20:12 +08:00 committed by Gert Doering
parent 5d2cd1222e
commit 3e1606fe86
2 changed files with 8 additions and 5 deletions

View file

@ -147,7 +147,7 @@ ifconfig_pool_verify_range(const int msglevel, const in_addr_t start, const in_a
}
struct ifconfig_pool *
ifconfig_pool_init(int type, in_addr_t start, in_addr_t end,
ifconfig_pool_init(enum pool_type type, in_addr_t start, in_addr_t end,
const bool duplicate_cn,
const bool ipv6_pool, const struct in6_addr ipv6_base,
const int ipv6_netbits )

View file

@ -34,8 +34,11 @@
#define IFCONFIG_POOL_MAX 65536
#define IFCONFIG_POOL_MIN_NETBITS 16
#define IFCONFIG_POOL_30NET 0
#define IFCONFIG_POOL_INDIV 1
enum pool_type
{
IFCONFIG_POOL_30NET,
IFCONFIG_POOL_INDIV
};
struct ifconfig_pool_entry
{
@ -49,7 +52,7 @@ struct ifconfig_pool
{
bool duplicate_cn;
struct {
int type;
enum pool_type type;
in_addr_t base;
int size;
} ipv4;
@ -69,7 +72,7 @@ struct ifconfig_pool_persist
typedef int ifconfig_pool_handle;
struct ifconfig_pool *ifconfig_pool_init(int type, in_addr_t start, in_addr_t end, const bool duplicate_cn, const bool ipv6_pool, const struct in6_addr ipv6_base, const int ipv6_netbits );
struct ifconfig_pool *ifconfig_pool_init(enum pool_type type, in_addr_t start, in_addr_t end, const bool duplicate_cn, const bool ipv6_pool, const struct in6_addr ipv6_base, const int ipv6_netbits );
void ifconfig_pool_free(struct ifconfig_pool *pool);