upstream/openvpn
1
0
Fork 0
mirror of https://github.com/OpenVPN/openvpn.git synced 2026-05-28 04:03:29 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Remove unnecessary OpenSSL init and cleanup commands in unit tests

Browse source 
After the removal of OpenSSL 1.0.2 support these instructions are
no longer needed and the main OpenVPN program also no longer calls
them in init_ssl_lib or free_ssl_lib.

Also remove them from the unit tests. This also solves a
deprecation warning on EVP_cleanup when compiling with aws-lc

Change-Id: I228f6fd9ff18256f09d4348df1fc48853f8e7306
Signed-off-by: Arne Schwabe <arne-openvpn@rfc2549.org>
Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1568
Message-Id: <20260316121148.25189-1-frank@lichtenheld.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36153.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
This commit is contained in:
Arne Schwabe 2026-03-16 13:11:48 +01:00 committed by Gert Doering
parent b0c2174a9e
commit 369c751078
5 changed files with 5 additions and 43 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
tests/unit_tests/openvpn/test_auth_token.c
View file

@ -428,11 +428,5 @@ main(void)
cmocka_unit_test_setup_teardown(auth_token_test_session_mismatch, setup, teardown)
};
#if defined(ENABLE_CRYPTO_OPENSSL)
OpenSSL_add_all_algorithms();
#endif
int ret = cmocka_run_group_tests_name("auth-token tests", tests, NULL, NULL);
return ret;
return cmocka_run_group_tests_name("auth-token tests", tests, NULL, NULL);
}

12
tests/unit_tests/openvpn/test_crypto.c
View file

@ -963,15 +963,5 @@ main(void)
cmocka_unit_test(epoch_test_derive_data_key)
};
#if defined(ENABLE_CRYPTO_OPENSSL)
OpenSSL_add_all_algorithms();
#endif
int ret = cmocka_run_group_tests_name("crypto tests", tests, NULL, NULL);
#if defined(ENABLE_CRYPTO_OPENSSL)
EVP_cleanup();
#endif
return ret;
return cmocka_run_group_tests_name("crypto tests", tests, NULL, NULL);
}

4
tests/unit_tests/openvpn/test_ncp.c
View file

@ -407,8 +407,6 @@ int
main(void)
{
openvpn_unit_test_setup();
#if defined(ENABLE_CRYPTO_OPENSSL)
OpenSSL_add_all_algorithms();
#endif
return cmocka_run_group_tests(ncp_tests, NULL, NULL);
}

12
tests/unit_tests/openvpn/test_pkt.c
View file

@ -765,15 +765,5 @@ main(void)
cmocka_unit_test(test_extract_control_message)
};
#if defined(ENABLE_CRYPTO_OPENSSL)
OpenSSL_add_all_algorithms();
#endif
int ret = cmocka_run_group_tests_name("pkt tests", tests, NULL, NULL);
#if defined(ENABLE_CRYPTO_OPENSSL)
EVP_cleanup();
#endif
return ret;
return cmocka_run_group_tests_name("pkt tests", tests, NULL, NULL);
}

12
tests/unit_tests/openvpn/test_tls_crypt.c
View file

@ -673,15 +673,5 @@ main(void)
cmocka_unit_test(test_tls_crypt_v2_write_client_key_file_metadata),
};
#if defined(ENABLE_CRYPTO_OPENSSL)
OpenSSL_add_all_algorithms();
#endif
int ret = cmocka_run_group_tests_name("tls-crypt tests", tests, NULL, NULL);
#if defined(ENABLE_CRYPTO_OPENSSL)
EVP_cleanup();
#endif
return ret;
return cmocka_run_group_tests_name("tls-crypt tests", tests, NULL, NULL);
}