From 352d234bee0d88e8a03d84fc3d9c1cd773c19c43 Mon Sep 17 00:00:00 2001 From: Frank Lichtenheld Date: Mon, 27 Apr 2026 19:47:50 +0200 Subject: [PATCH] configure: Remove --enable-strict Both -Wsign-compare (via -Wextra) and -Wuninitalized (via -Wall) are enabled by default. So this does not do anything anymore. While here also remove rest of --enable-strict-options which was mostly removed in commit 2104ea62430e4d203f2cd998e053f4192798b9f1 Change-Id: I53e7b984980cb1e2b3f68e80358b61c9e1045725 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1590 Message-Id: <20260427174757.4075-1-gert@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36752.html Signed-off-by: Gert Doering (cherry picked from commit ac62337dd5338ab5fe066f33a09f258dd04d0585) --- CMakeLists.txt | 2 +- configure.ac | 18 ------------------ 2 files changed, 1 insertion(+), 19 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 681b3de2..15ddf5f6 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -112,7 +112,7 @@ if (MSVC) add_link_options("$<$:/CETCOMPAT>") endif() else () - add_compile_options(-Wall -Wuninitialized) + add_compile_options(-Wall) check_and_add_compiler_flag(-Wno-stringop-truncation NoStringOpTruncation) check_and_add_compiler_flag(-Wstrict-prototypes StrictPrototypes) check_and_add_compiler_flag(-Wold-style-definition OldStyleDefinition) diff --git a/configure.ac b/configure.ac index f086aa09..7753f45e 100644 --- a/configure.ac +++ b/configure.ac @@ -209,13 +209,6 @@ AC_ARG_ENABLE( [enable_pam_dlopen="no"] ) -AC_ARG_ENABLE( - [strict], - [AS_HELP_STRING([--enable-strict], [enable strict compiler warnings (debugging option) @<:@default=no@:>@])], - , - [enable_strict="no"] -) - AC_ARG_ENABLE( [pedantic], [AS_HELP_STRING([--enable-pedantic], [enable pedantic compiler warnings, will not generate a working executable (debugging option) @<:@default=no@:>@])], @@ -230,13 +223,6 @@ AC_ARG_ENABLE( [enable_werror="no"] ) -AC_ARG_ENABLE( - [strict-options], - [AS_HELP_STRING([--enable-strict-options], [enable strict options check between peers (debugging option) @<:@default=no@:>@])], - , - [enable_strict_options="no"] -) - AC_ARG_ENABLE( [selinux], [AS_HELP_STRING([--enable-selinux], [enable SELinux support @<:@default=no@:>@])], @@ -1278,13 +1264,9 @@ if test "${WIN32}" = "yes"; then fi if test "${enable_pedantic}" = "yes"; then - enable_strict="yes" CFLAGS="${CFLAGS} -pedantic" AC_DEFINE([PEDANTIC], [1], [Enable pedantic mode]) fi -if test "${enable_strict}" = "yes"; then - CFLAGS="${CFLAGS} -Wsign-compare -Wuninitialized" -fi if test "${enable_werror}" = "yes"; then CFLAGS="${CFLAGS} -Werror" fi