upstream/openvpn
1
0
Fork 0
mirror of https://github.com/OpenVPN/openvpn.git synced 2026-05-28 04:03:29 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

remove newline characters at the end of msg() calls

Browse source 
Unlike debugging with printf(), or msg() calls do not need or want
a '\n' at the end of the string.  Remove those that were overlooked.

Change-Id: I889b53ed72efaec546a6609491fae9715726ea00
Signed-off-by: Gert Doering <gert@greenie.muc.de>
Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
Message-Id: <20250912131609.43444-1-frank@lichtenheld.com>
URL: https://sourceforge.net/p/openvpn/mailman/message/59232448/
URL: https://gerrit.openvpn.net/c/openvpn/+/1180
Signed-off-by: Gert Doering <gert@greenie.muc.de>
This commit is contained in:
Gert Doering 2025-09-12 15:16:09 +02:00
parent c3600e9b59
commit 340b5b2d26
8 changed files with 15 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/openvpn/multi.c
View file

@ -1036,7 +1036,7 @@ multi_print_status(struct multi_context *m, struct status_output *so, const int
#ifdef ENABLE_ASYNC_PUSH
if (m->inotify_watchers)
{
msg(D_MULTI_DEBUG, "inotify watchers count: %d\n", hash_n_elements(m->inotify_watchers));
msg(D_MULTI_DEBUG, "inotify watchers count: %d", hash_n_elements(m->inotify_watchers));
}
#endif
}

2
src/openvpn/plugin.c
View file

@ -1007,7 +1007,7 @@ plugin_return_print(const int msglevel, const char *prefix, const struct plugin_
msg(msglevel, "PLUGIN #%d (%s)", i, prefix);
while (l)
{
msg(msglevel, "[%d] '%s' -> '%s'\n", ++count, l->name, l->value);
msg(msglevel, "[%d] '%s' -> '%s'", ++count, l->name, l->value);
l = l->next;
}
}

2
src/openvpn/socket_util.h
View file

@ -475,7 +475,7 @@ af_addr_size(sa_family_t af)
default:
#if 0
/* could be called from socket_do_accept() with empty addr */
msg(M_ERR, "Bad address family: %d\n", af);
msg(M_ERR, "Bad address family: %d", af);
ASSERT(0);
#endif
return 0;

12
src/openvpn/tun.c
View file

@ -2392,7 +2392,7 @@ open_tun(const char *dev, const char *dev_type, const char *dev_node, struct tun
{
if (ioctl(if_fd, SIOCGLIFFLAGS, &ifr) < 0)
{
msg(M_ERR, "Can't get flags\n");
msg(M_ERR, "Can't get flags");
}
strncpynt(ifr.lifr_name, tt->actual_name, sizeof(ifr.lifr_name));
ifr.lifr_ppa = ppa;
@ -2403,7 +2403,7 @@ open_tun(const char *dev, const char *dev_type, const char *dev_node, struct tun
}
if (ioctl(if_fd, SIOCGLIFFLAGS, &ifr) < 0)
{
msg(M_ERR, "Can't get flags\n");
msg(M_ERR, "Can't get flags");
}
/* Push arp module to if_fd */
if (ioctl(if_fd, I_PUSH, "arp") < 0)
@ -2422,18 +2422,18 @@ open_tun(const char *dev, const char *dev_type, const char *dev_node, struct tun
/* Push arp module to ip_fd */
if (ioctl(tt->ip_fd, I_PUSH, "arp") < 0)
{
msg(M_ERR, "Can't push ARP module\n");
msg(M_ERR, "Can't push ARP module");
}
/* Open arp_fd */
if ((arp_fd = open(arp_node, O_RDWR, 0)) < 0)
{
msg(M_ERR, "Can't open %s\n", arp_node);
msg(M_ERR, "Can't open %s", arp_node);
}
/* Push arp module to arp_fd */
if (ioctl(arp_fd, I_PUSH, "arp") < 0)
{
msg(M_ERR, "Can't push ARP module\n");
msg(M_ERR, "Can't push ARP module");
}
/* Set ifname to arp */
@ -2443,7 +2443,7 @@ open_tun(const char *dev, const char *dev_type, const char *dev_node, struct tun
strioc_if.ic_dp = (char *)&ifr;
if (ioctl(arp_fd, I_STR, &strioc_if) < 0)
{
msg(M_ERR, "Can't set ifname to arp\n");
msg(M_ERR, "Can't set ifname to arp");
}
}

4
src/openvpn/xkey_helper.c
View file

@ -53,7 +53,7 @@ print_openssl_errors(void)
unsigned long e;
while ((e = ERR_get_error()))
{
msg(M_WARN, "OpenSSL error %lu: %s\n", e, ERR_error_string(e, NULL));
msg(M_WARN, "OpenSSL error %lu: %s", e, ERR_error_string(e, NULL));
}
}
@ -429,7 +429,7 @@ ecdsa_bin2der(unsigned char *buf, int len, size_t capacity)
if (derlen > (int)capacity)
{
ECDSA_SIG_free(ecsig);
msg(M_NONFATAL, "Error: DER encoded ECDSA signature is too long (%d)\n", derlen);
msg(M_NONFATAL, "Error: DER encoded ECDSA signature is too long (%d)", derlen);
return 0;
}
derlen = i2d_ECDSA_SIG(ecsig, &buf);

2
src/openvpn/xkey_provider.c
View file

@ -944,7 +944,7 @@ static int
signature_sign(void *ctx, unsigned char *sig, size_t *siglen, size_t sigsize,
const unsigned char *tbs, size_t tbslen)
{
xkey_dmsg(D_XKEY, "entry with siglen = %zu\n", *siglen);
xkey_dmsg(D_XKEY, "entry with siglen = %zu", *siglen);
XKEY_SIGNATURE_CTX *sctx = ctx;
ASSERT(sctx);

2
tests/unit_tests/openvpn/test_cryptoapi.c
View file

@ -64,7 +64,7 @@ crypto_print_openssl_errors(const unsigned int flags)
unsigned long e;
while ((e = ERR_get_error()))
{
msg(flags, "OpenSSL error %lu: %s\n", e, ERR_error_string(e, NULL));
msg(flags, "OpenSSL error %lu: %s", e, ERR_error_string(e, NULL));
}
}

4
tests/unit_tests/openvpn/test_pkcs11.c
View file

@ -52,7 +52,7 @@ crypto_print_openssl_errors(const unsigned int flags)
unsigned long e;
while ((e = ERR_get_error()))
{
msg(flags, "OpenSSL error %lu: %s\n", e, ERR_error_string(e, NULL));
msg(flags, "OpenSSL error %lu: %s", e, ERR_error_string(e, NULL));
}
}
@ -170,7 +170,7 @@ get_user_pass_cr(struct user_pass *up, const char *auth_file, const char *prefix
}
else
{
msg(M_NONFATAL, "ERROR: get_user_pass called with unknown request <%s> ignored\n", prefix);
msg(M_NONFATAL, "ERROR: get_user_pass called with unknown request <%s> ignored", prefix);
ret = false;
}