From 2aaa5e4d7c5bae35d7befdebeed065c634292151 Mon Sep 17 00:00:00 2001 From: Frank Lichtenheld Date: Sun, 5 Apr 2026 12:22:04 +0200 Subject: [PATCH] win: Fix nrpt_dnssec flag handling By default the first enum value is 0. But we check whether we set the flag by doing BOOL dnssec = (msg->flags & nrpt_dnssec) != 0; This can't ever be true. Found by cppcheck. Change-Id: Iff5be978817bfc0cd4d78818e7be7b90bad71f3c Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1606 Message-Id: <20260405102209.31528-1-gert@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36487.html Signed-off-by: Gert Doering (cherry picked from commit 08a19843a184c6cb8850ac9e6bf7ce0cd4d15d37) --- include/openvpn-msg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/openvpn-msg.h b/include/openvpn-msg.h index a0cec53a..ca9c9038 100644 --- a/include/openvpn-msg.h +++ b/include/openvpn-msg.h @@ -109,7 +109,7 @@ typedef struct typedef enum { - nrpt_dnssec + nrpt_dnssec = 1 << 0, } nrpt_flags_t; #define NRPT_ADDR_NUM 8 /* Max. number of addresses */