upstream/openvpn
1
0
Fork 0
mirror of https://github.com/OpenVPN/openvpn.git synced 2026-05-28 04:03:29 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

dev-tools/gerrit-send-mail.py: include Gerrit URL into the commit message

Browse source 
We used to reference to one of the mailing list archives as the formal
reference for the patch and the review discussions.  With the problematic
reliability of the archives, I've started to manually add the URLs in
the OpenVPN Gerrit to the commits because they give a better reference
and (usually) all the feedback is there in a useful format.

So, enhance this dev-tool script to do this automatically.

Change-Id: Idb137ecbade4b0584a4d74aee34978062e247bc5
Signed-off-by: Gert Doering <gert@greenie.muc.de>
Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1196
Message-Id: <20250917120720.30738-1-gert@greenie.muc.de>
URL: https://sourceforge.net/p/openvpn/mailman/message/59234672/
Signed-off-by: Gert Doering <gert@greenie.muc.de>
This commit is contained in:
Gert Doering 2025-09-17 14:07:15 +02:00
parent 5681535b19
commit 168792766d
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
dev-tools/gerrit-send-mail.py
View file

@ -99,6 +99,7 @@ def apply_patch_mods(patch_text, details, args):
assert comment_start > signed_off_end
acked_by_text = ""
acked_by_names = ""
gerrit_url = f"{args.url}/c/{details['project']}/+/{args.changeid}"
for ack in details["acked_by"]:
acked_by_text += f"Acked-by: {ack}\n"
acked_by_names += f"{ack}\n"
@ -106,12 +107,13 @@ def apply_patch_mods(patch_text, details, args):
patch_text[:signed_off_end]
+ signed_off_text
+ acked_by_text
+ f"Gerrit URL: {gerrit_url}\n"
+ patch_text[signed_off_end:comment_start]
+ f"""
This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to {details["target"]}.
Gerrit URL: {args.url}/c/{details["project"]}/+/{args.changeid}
Gerrit URL: {gerrit_url}
This mail reflects revision {details["revision"]} of this Change.
{signed_off_comment}
Acked-by according to Gerrit (reflected above):