upstream/openldap
1
0
Fork 0
mirror of https://git.openldap.org/openldap/openldap.git synced 2025-12-24 00:29:35 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions
21846 commits 38 branches 309 tags 68 MiB
Commit graph

11933 commits

Author SHA1 Message Date
Howard Chu
c25208cd14 Minor cleanup (coverity) 2015-01-14 12:48:44 +00:00
Howard Chu
0677f67d29 Minor cleanup (coverity) 2015-01-14 12:23:19 +00:00
Howard Chu
86d81fa153 Minor cleanup (coverity) 2015-01-14 12:16:24 +00:00
Howard Chu
e861305d50 Minor cleanup (coverity) 2015-01-14 11:30:33 +00:00
Howard Chu
0e5f63ae6d Minor cleanup (coverity) 2015-01-14 11:08:51 +00:00
Howard Chu
651804842f Fix missing error return (coverity) 2015-01-14 10:37:13 +00:00
Howard Chu
45146ba21a Fix UTF8stringvalidate loop termination (coverity) 2015-01-14 10:35:20 +00:00
Howard Chu
67c13d0ccf Fix NULL in debug output (coverity) 2015-01-14 10:22:50 +00:00
Howard Chu
0e66a3d1bf check ber_scanf(syncUUIDs) result (coverity) 2015-01-14 10:13:16 +00:00
Howard Chu
14a3efa48a plug unlikely memleak (coverity) 2015-01-13 22:48:07 +00:00
Howard Chu
74d89e567c plug memleak in cr index (coverity) 2015-01-13 22:01:17 +00:00
Howard Chu
19af642a2d ACL write/manage fixes (coverity) 2015-01-13 21:43:22 +00:00
Howard Chu
975dce7ffb varargs cleanup (coverity) 2015-01-13 18:32:28 +00:00
Howard Chu
79cce59ad4 Fix insecure chroot (coverity) 2015-01-13 18:23:16 +00:00
Howard Chu
2cf553563b Fix fprintf format (coverity) 2015-01-13 18:11:49 +00:00
Howard Chu
6046584531 ITS#8022 don't skip TLS init for ldaps:// targets 2015-01-12 22:25:53 +00:00
Howard Chu
9266a43d6c ITS#8016 return errmsg for unknown envflags 2015-01-05 09:37:27 +00:00
Leo Yuriev
67a65ec701 ITS#8011: few corrections for lmdb-backend; 
dn2id.c:
  + assertion for mdb_id2l_insert() result;
  - unnecessary assignment;

search.c:
  - unused variable 'first';
  + range-check for mdb_idl_search() result;
 2015-01-04 07:41:07 +00:00
Leo Yuriev
7c2951819f ITS#5452,#8012: fix syncprov syncops freeing 
Detaching a syncops record from op-list conditionally,
only when it was freed by syncprov_free_syncop.

The syncprov_free_syncop() and syncprov_drop_psearch() now
returns a flag, which is nonzero if the given syncops was freed.
 2015-01-04 07:27:29 +00:00
Howard Chu
0b2438fbec ITS#8013 fix syncprov_matchops test_filter usage 2015-01-04 07:20:41 +00:00
Howard Chu
c5cc2f241f ITS#8014 plug onetime leak in slapadd -w 2015-01-04 07:01:47 +00:00
Howard Chu
2930a68808 ITS#7780,#7781 fix prev commit 2014-12-18 19:35:09 +00:00
Ondřej Kuzník
8958d2b7cb ITS#7780,ITS#7781 Fix slapo-constraint with 0 count 2014-12-18 19:34:55 +00:00
Howard Chu
e8771b785c ITS#8007 fix d06f5e7c1b 
duplicate OID, oops
 2014-12-16 20:08:32 +00:00
Howard Chu
d06f5e7c1b ITS#8007 Add maxentrysize config option 2014-12-15 21:35:48 +00:00
Ondřej Kuzník
508f4158bc ITS#7797 Fix segfault in slapo-collect 2014-12-12 01:35:30 +00:00
Howard Chu
9accfbb73a ITS#7995 fix slap_bv2undef_ad 2014-12-10 02:06:50 +00:00
Leo Yuriev
8ba5a27829 ITS#7968 add locks for syncrepl cookiestate 
Mutex must be held even for a read-access of a cookie state,
as there may be a race with write in other thread.
 2014-12-05 19:44:19 +00:00
Howard Chu
b0225e8e60 ITS#7976 fix delta-mmr/accesslog interaction 2014-10-30 15:00:13 +00:00
Howard Chu
e6e073d31e ITS#7975 fix onelevel search 2014-10-29 18:05:00 +00:00
Howard Chu
10d5815c62 Fix typo in cancel config 2014-10-15 11:21:19 +01:00
Leo Yuriev
b0e46fb9f9 ITS#7965 mdb_dn2id 
heap corruption due to returning a reference to a local variable
 2014-10-14 13:15:16 +01:00
Quanah Gibson-Mount
db564ab516 Silence compiler warning by adding explicit return 0 to ppolicy_db_destroy 2014-10-03 15:35:39 -05:00
Howard Chu
766103a912 Fix mdb_txn cleanup 2014-09-19 19:22:14 +01:00
Howard Chu
8bdd54c4c1 ITS#7942 tweak previous commit 
Only free when cleaning up operation controls, not response controls.
(This only makes a difference on search requests, which may have
multiple responses with the same set of controls.)
 2014-09-18 06:49:26 +01:00
Howard Chu
9d9913392a ITS#7942 plug leak in controls 2014-09-18 02:06:38 +01:00
Howard Chu
af8f1e0741 ITS#7941 fix for repeated tags 
Make sure ntags isn't incremented if we're skippnig the tag
 2014-09-18 00:33:33 +01:00
Howard Chu
09137b6646 Consolidate LDAP_TXN precheck 
This commit was accidentally omitted from previous push
 2014-09-16 00:09:10 +01:00
Howard Chu
f9cb538fbd Add updateControls to txn response 2014-09-15 23:49:26 +01:00
Howard Chu
32f05e96f7 Flesh out txn support 
Only in back-mdb; back-bdb needs work but it's deprecated;
not worth the effort. In particular txn, retry after deadlocks
makes the whole thing too messy.
 2014-09-15 23:48:23 +01:00
Howard Chu
11594db633 ITS#7937 flush data to socket 2014-09-11 10:24:09 +01:00
Leo Yuriev
c1f04881be ITS#7915 fix memory leaks in previous patch 2014-09-10 11:51:44 +01:00
Howard Chu
4f66cfa1b4 ITS#7935 partially revert prev patch 
Can't allow special chars in RDN, not all OSs/filesystems support it.
 2014-09-09 14:40:11 +01:00
Howard Chu
f88970efc1 ITS#7935 fix schema RDN normalization 2014-09-09 14:35:43 +01:00
Howard Chu
3d52e63366 ITS#7929 don't log internal searches 2014-09-08 15:40:28 +01:00
Howard Chu
4ea2fe90e8 ITS#7934 add missing normalization of attrs 2014-09-08 14:57:57 +01:00
Jan Synacek
1ad90643b5 ITS#7933 fix frontend config 2014-09-08 14:04:38 +01:00
hyc
846cf30842 ITS#7930 additional fix 
bypass cleanup handlers for suppressed search result msgs
 2014-09-06 09:49:32 +01:00
hyc
18d9470984 ITS#7930 partial fix 
Only restore op->o_req_dn if no one else changed it on us.
 2014-09-06 09:14:46 +01:00
Howard Chu
92c7a89130 ITS#7928 fix syncprov abandon cleanup 2014-08-29 02:19:35 +01:00
Howard Chu
9a8cb6091a ITS#7702 better fix 
Check for duplicate scopes in search_aliases, not later.
 2014-08-28 18:21:21 +01:00
Howard Chu
f42c7c6bbc Revert "ITS#7702 fix results with aliases" 
This reverts commit cac00c6a97.
 2014-08-28 17:51:46 +01:00
Howard Chu
b669f5b706 ITS#7904 init wwctx earlier 2014-08-27 11:50:32 +01:00
Howard Chu
cac00c6a97 ITS#7702 fix results with aliases 
Aliases pointing within the original search scope could cause
the same entry to be returned multiple times. Check for subtree
scope and duplicate scopes.
 2014-08-26 20:07:40 +01:00
Howard Chu
e5f5a4ab5f ITS#7927 fix double-free of searchref 2014-08-26 19:17:33 +01:00
Howard Chu
b07e31aa02 Cleanup mdb_ad_get 2014-08-21 20:26:00 -07:00
Howard Chu
be02e8ddd0 ITS#7906,#7923 Don't free configinfo in _db_close 2014-08-20 13:49:37 -07:00
Howard Chu
3feffb9a0a ITS#7904 more tweaks 
Must save/restore mcd cursor if we're doing a scope-based search.
 2014-08-20 13:06:51 -07:00
Howard Chu
cd02e6054e ITS#7922 delete dead code 
Harmless, but stupid.
 2014-08-19 20:31:20 -07:00
Quanah Gibson-Mount
9c54ff2f0b Fix typo 2014-08-18 12:18:44 -05:00
Howard Chu
27f3ef2cfd ITS#7920 fix for slapacl 
This needs to be streamlined in 2.5, current tool API is a mess.
 2014-08-13 20:49:05 -07:00
Howard Chu
3f0839d8df ITS#7838 fix typos in prev commit 2014-08-13 19:53:56 -07:00
Howard Chu
10b6c9f0f2 ITS#7919 fix cache DB config 
Don't accept config directives for cache DB until the cache backend type
has been set.
 2014-08-13 19:22:17 -07:00
Howard Chu
d8e280e87c ITS#7906 more cleanup 
db_open/close were not symmetric with init/destroy
 2014-08-11 13:48:29 -07:00
Howard Chu
8b89b45615 ITS#7906 minor cleanup 
rename ppolicy_close -> ppolicy_db_close for consistency
 2014-08-05 19:37:28 -07:00
Howard Chu
08792a77fd ITS#7906 better fix 
don't free pwcons unless we're actually destroying this DB
 2014-08-05 19:36:30 -07:00
Howard Chu
7f7a82c0f5 ITS#7915 fix translucent_modify 
Go directly to local backend when fetching local entry
 2014-08-04 13:42:35 -07:00
Howard Chu
d8c060104d ITS#7915 fix mdb_entry_release 
In server mode, make sure the entry was actually ours
 2014-08-04 13:36:48 -07:00
Howard Chu
f7a2438112 ITS#7895 drop toolmode checks in str2entry 
They were obsoleted by ITS#6737 and have been redundant ever since.
(commit 15f1e7bdb7)
 2014-08-02 11:17:12 -07:00
Howard Chu
5ac3dbefcd ITS#7912 fix index config 2014-07-31 11:31:14 -07:00
Howard Chu
e5dae640f2 ITS#7909 fix slap_callback init 2014-07-30 06:55:36 -07:00
Quanah Gibson-Mount
e091e0bb63 ITS#7908 
Add olcSssVlvMaxPerConn to the olcSssVlvConfig objectClass
 2014-07-28 13:04:43 -05:00
Howard Chu
05402c396d ITS#7906 fix ppolicy_connection_destroy 
It can still run after ppolicy_close has freed the connection table
 2014-07-24 17:04:56 -07:00
Howard Chu
e17878933f ITS#7904 writewait patch 
Assigned ITS#, tweaking. This ITS includes
	4f05d992f2
	716b35e191
	be792fae2c
 2014-07-23 13:12:51 -07:00
Howard Chu
4f05d992f2 Fix prev commit 2014-07-22 21:55:23 -07:00
Howard Chu
716b35e191 More for writewait callback 
Must also reset search cursors
 2014-07-22 21:52:24 -07:00
Howard Chu
031640456b ITS#7903 preserve Sorted status of attrs 2014-07-22 20:24:58 -07:00
Howard Chu
f0475bab5a ITS#7902 fix str2entry / sorted vals 2014-07-22 20:21:35 -07:00
Howard Chu
be792fae2c Add sc_writewait callback 
Invoked before a blocked writer waits for socket to be writable.
Use in back-mdb to release reader txn while waiting.
 2014-07-22 19:17:15 -07:00
Ondřej Kuzník
a773a0cc14 ITS#7894 Let back-config use backend to release entries 2014-07-22 14:49:20 -07:00
Howard Chu
03d927485e ITS#7249 partial fix for memberof on frontendDB 2014-07-21 08:44:42 -07:00
Michael Stroeder
8605eedb31 ITS#7838 add ORDERING rules to ppolicy attrs 2014-07-18 13:04:15 -07:00
Howard Chu
8c62b323ba ITS#7868 fix slapo-sock db_init 2014-07-18 12:03:07 -07:00
Howard Chu
1f168a0b8f ITS#7893 (#6508) fix a_numvals 2014-07-09 13:07:53 -07:00
Howard Chu
b9abbdf623 Add missing mdb_strerror calls to debug msgs 2014-07-09 11:21:41 -07:00
Ondrej Kuznik
01f698bce9 ITS#7256 A few issues discovered during testing slapmodify. 
- bdb deallocates cursor after some tool operations but expects it to be
  around every time it is called
- mdb tries to allocate a second transaction while it already holds one,
  deadlocking
- op->o_hdr must exist for most uses of op, but o_tmpmfuncs need not
- what about indexing after a tool modify? Does it happen automatically?
 2014-07-08 17:28:12 -07:00
Ondrej Kuznik
d3a5ab824d ITS#7256 Consolidate cleanup code at one location. 2014-07-08 17:28:12 -07:00
Ondrej Kuznik
07c563b8a5 ITS#7256 Rework entry retrieval and cleanup. 
When doing deletes, lastmod has no entry to work on.
 2014-07-08 17:28:11 -07:00
Ondrej Kuznik
fde1f80aa8 ITS#7256 Add some necessary checks. 2014-07-08 17:28:10 -07:00
Ondrej Kuznik
304c0cbbff ITS#7256 Set backend for operation. 
slap_tool_entry_check does it but it is not called every time.
 2014-07-08 17:28:09 -07:00
Ondrej Kuznik
7810dccdff ITS#7256 Let slapmodify ignore unknown operations 
ldapmodify already does the same.
 2014-07-08 17:28:07 -07:00
Ondrej Kuznik
cede821cef ITS#7256 Allow deletes with slapmodify 2014-07-08 17:28:06 -07:00
Ondrej Kuznik
f05602927d ITS#7256 mplement bi_tool_entry_delete for back-ldif 2014-07-08 17:28:04 -07:00
Ondrej Kuznik
c048b7cad6 ITS#7256 Introduce bi_tool_entry_delete 2014-07-08 17:26:05 -07:00
Ondrej Kuznik
17e223b896 ITS#7212 rudimentary slapmodify support for back-config 2014-07-08 17:25:58 -07:00
Ondrej Kuznik
5ee5251fa4 ITS#7212 slapmodify support for back-ldif 2014-07-08 17:25:58 -07:00
Howard Chu
282d215924 Fixup for win64 commit 
couldn't avoid ifdefs. Silence warnings.
 2014-06-23 08:21:36 -07:00
Howard Chu
dda779d83e Windows64 32/64 silliness 
On Windows64, long is the same size as int. Use size_t when we
need an actual 64 bit unsigned long.
 2014-06-23 08:00:11 -07:00
Paul B. Henson
85d467aca6 ITS#7161 ppolicy pwdFailureTime resolution should be better than 1 second 2014-06-15 13:42:46 -07:00
Howard Chu
8fc7e06d22 Revert "ITS#7616 defer searches while consumer refreshing" 
This reverts commit cf4aa8f9d9.

There appears to be no safe way for this to work with MMR.
 2014-06-12 13:23:29 -07:00
Howard Chu
e4e265c153 ITS#7873 check for pauses 2014-06-04 14:24:20 -07:00
Howard Chu
4afa10d059 ITS#7872 plug memleak of matchedDN 2014-06-04 14:02:06 -07:00
Howard Chu
45ff842542 Plug one-time leaks 2014-06-04 02:23:18 -07:00
Howard Chu
a01d3f965b ITS#7870 ignore index DBs in slapcat 2014-06-03 20:38:21 -07:00
Howard Chu
33e12f4de3 Don't do any merging if manageDSAit was used 
Just passthru search to local DB
 2014-05-27 18:12:49 -07:00
Howard Chu
932a11ac76 ITS#7849 make sure to send cookie after fallback 2014-05-23 06:56:56 -07:00
Howard Chu
cf4aa8f9d9 ITS#7616 defer searches while consumer refreshing 2014-05-23 06:56:16 -07:00
Howard Chu
5a08b66141 ITS#7705,#7800 fix prev commit 
Better check for missing IDs
 2014-05-15 21:27:21 -07:00
Howard Chu
437f21b16e ITS#7705,#7800 fix back-mdb pagedResults search 
mdb_idscopes was remembering the IDs of every entry it checked;
it should only have been saving the IDs of entries that were
actually in the search scope. The extra entries filled the scopes
array, causing a loop searching for a parent entry that was
never inserted.
 2014-05-15 21:06:17 -07:00
Howard Chu
141f168093 ITS#7850 catch invalid naming attr 2014-05-09 11:29:45 -07:00
Quanah Gibson-Mount
e5443fd279 Relocate the maxsize bit 2014-04-25 14:43:12 -05:00
Quanah Gibson-Mount
ea2fbe2152 Sample slapd.ldif is missing the olcDbMaxSize parameter 2014-04-25 14:36:09 -05:00
Howard Chu
c84ae5db07 ITS#7827 slapacl requires a valid suffix 2014-03-25 15:18:17 -07:00
Howard Chu
052aef5960 ITS#7587 fix double-free 
Related to bb3e14ddba (ITS#6254)
 2014-03-18 11:47:31 -07:00
Howard Chu
5f92a0bb16 ITS#7803 reference slapd-config(5) 
Also replace BDB example with LMDB
 2014-02-28 12:52:39 -08:00
Howard Chu
5cab6b77e4 ITS#7798 fix mdb_entry_decode() 2014-02-07 03:02:33 -08:00
Kurt Zeilenga
5c878c1bf2 Happy new year (belated) 2014-01-25 05:21:25 -08:00
Howard Chu
b1ed3bf10a ITS#7778 fix regression from #7329 2014-01-13 11:26:46 -08:00
Pierangelo Masarati
3be02f83df handle softadd/softdel (internal modifications; ITS#7773) 2013-12-28 16:20:08 +01:00
Hallvard Furuseth
5415e1e6de ITS#6758 Rewrite code for contrib:wrap_slap_ops. 
Tweak slapd code so wrap_slap_ops can process it: Use pointers
BackendInfo *bi instead of array "func" = &bi->bi_op_bind. In
slapo-chain, keep a slap_operation_t instead of a function ptr.
 2013-12-11 14:40:45 +01:00
Hallvard Furuseth
7bb8b706c5 ITS#6758 Add SLAP_OP() &co, contrib:wrap_slap_ops. 
Add framework for debug macros SLAP_OP(), slap_be_op(),
slap_bi_op() around LDAP-operation backend calls.

contrib/slapd-tools/wrap_slap_ops converts code to use them.

Code compiles as before by default.  #define USE_RS_ASSERT
enables debugging, $NO_RS_ASSERT tweaks it. See slapd/result.c.
 2013-12-11 14:40:45 +01:00
Howard Chu
26ce222b6a ITS#7761 bail out of search if config is pausing 2013-12-10 18:08:36 -08:00
Howard Chu
ac9ac0094e ITS#7749 more for prev commit 2013-11-21 11:18:24 -08:00
Howard Chu
a4b9cab04f ITS#7750 fix olcDbConfig modification 2013-11-18 20:39:35 -08:00
Howard Chu
1682691f50 Fix typo for Windows 2013-11-14 21:17:13 -08:00
Howard Chu
06e384d55b ITS#7749 propagate op->o_extra in syncprov_findbase 2013-11-14 19:16:57 -08:00
Howard Chu
5328340d35 ITS#7746 fix for cert with NULL issuerDN 2013-11-14 03:02:07 -08:00
Howard Chu
66bb780b16 ITS#7743 Fix indexed AND filter 
Partially revert 47f6aec61e
Was using RANGE_FIRST/RANGE_LAST on an IDL known to *not* be a range.
 2013-11-11 21:01:33 -08:00
Howard Chu
3d1a0bb17e ITS#7741 Fix entryDN index lookup 
DN notfound is authoritative, don't ignore the result
 2013-11-06 09:41:42 -08:00
Howard Chu
6711876a35 Fix CONFIG_DELETE crash 
Closing a connection can abandon its ops without going thru the threadpool,
so make sure to lock the si_ops_mutex before walking the list.
 2013-11-05 12:59:56 -08:00
Howard Chu
a12bedc2d8 ITS#7735 fix memctx usage in prev commit 2013-11-05 11:49:43 -08:00
Howard Chu
eef667fd49 ITS#7739 fix for empty nested include 2013-11-05 07:34:30 -08:00
Jorge Perez Burgos
66e0d6017a ITS#7740 back-meta: avoid blocking other threads 
Don't lock other threads while trying to connect to remote node.
 2013-11-05 06:45:40 -08:00
Howard Chu
ed09222963 Fix slap_reparse_sync_cookie prototype 2013-11-02 14:20:15 -07:00
Howard Chu
0645878d5d ITS#7735 plug memleak 
Introduced in commit 48cdd54d9a
 2013-11-01 11:07:51 -07:00
Quanah Gibson-Mount
e70bc5dd64 ITS#7737 Add a matching rule for OlcDbEnvFlgs 2013-11-01 09:57:20 -07:00
Howard Chu
80d8c56afd ITS#7725 add nordahead envflag 2013-10-12 16:25:33 -07:00
Howard Chu
d47524d8f9 ITS#7692 no-op if target entry doesn't exist 2013-10-12 15:35:05 -07:00
Ted C. Cheng
a2e1b9b545 ITS#7699 fixed one dds start-up assertion failure 2013-10-12 15:23:19 -07:00
Howard Chu
d51ee964fc ITS#7694 more for IPv6 CLDAP, slapd fix 2013-10-10 10:48:08 -07:00
Howard Chu
63314e9c4a ITS#7710 fix typo 2013-10-10 04:04:44 -07:00
Howard Chu
44504848ac ITS#7329 optimize index update for simple add ops 
Don't need to reindex all the attr values if there were no deletes.
 2013-10-09 07:55:50 -07:00
Howard Chu
c350b51a63 ITS#7710 fix for non-replicated internal ops 
Their completion was making slap_graduate_commit_csn() cleanup
their parent op's CSN, thus preventing that CSN from propagating
to any consumers.
 2013-10-09 04:58:37 -07:00
Howard Chu
c82dcab9bd ITS#7720 don't do ptr arithmetic on void *s 2013-10-08 10:40:51 -07:00
Quanah Gibson-Mount
a672161ab7 Add maxsize parameter for mdb examples 2013-09-19 15:03:53 -07:00
Quanah Gibson-Mount
74c52fb136 Switch example slapd.conf to use mdb instead of bdb 2013-09-19 14:23:11 -07:00
Quanah Gibson-Mount
1a712bf18e Enable features that were hidden behind LDAP_DEVEL 2013-09-19 09:50:52 -07:00
Pierangelo Masarati
919a0f5b54 ITS#7687: password modify can muck with controls (quick fix) 2013-09-10 22:03:32 +02:00
Howard Chu
819566415e ITS#7381 more for prev commit 2013-09-09 04:59:20 -07:00
Howard Chu
c0e2961f81 Drop unused var in prev commit 2013-09-07 14:58:18 -07:00