Commit graph

1159 commits

Author SHA1 Message Date
Howard Chu
7e2290c52b MDB_VL32 plug rpage leak
mdb_cursor_set wasn't unref'ing as intended.
2016-08-11 21:30:56 +01:00
Hallvard Furuseth
77d522d151 Comment MDB_page 2016-08-02 22:17:54 +02:00
Hallvard Furuseth
8670805b4f Doc fixes: VALID_FLAGS, mm_last_pg, mt_loose_count 2016-08-02 22:16:09 +02:00
Hallvard Furuseth
58b0ce50b3 mdb_size comments 2016-08-02 21:04:17 +02:00
Hallvard Furuseth
4d47e89f4d MDB_VL32: Switch to mdb_size_t formats PRIu64 & co
Drop macro Y=MDB_FMT_Y, add Yu/Yd=MDB_PRIy(). Replace
Y"d..." -> Yd"...", Y"u..." -> Yu"..." / MDB_SCNy(u)"...".
2016-08-02 21:02:35 +02:00
Hallvard Furuseth
65d9791ada Refactor mdb_page_get() 2016-07-23 12:45:46 +02:00
Hallvard Furuseth
a43fcad8c6 MDB_VL32: Match mdb_size_t type with format modifier.
When using format modifier "ll" or "I64", use the matching
type unsigned <long long / __int64> rather than uint64_t.
2016-07-23 12:43:16 +02:00
Hallvard Furuseth
f25d716513 Fix MDB_INTEGERKEY doc of integer types 2016-07-23 12:18:01 +02:00
Hallvard Furuseth
0842f998ee Use mdb_size_t for line numbers in mdb_load
This matches the mdb_size_t entry counts.
2016-07-23 12:17:04 +02:00
Hallvard Furuseth
12ad38d67f Fix size_t/formats -> mdb_size_t for MDB_VL32 2016-07-23 12:16:20 +02:00
Hallvard Furuseth
dff8bafb36 Factor some MDB_VL32-related '#if's out to macros
Add MC_OVPG() + MC_SET_OVPG(), NEED_CMP_CLONG(), MDB_CURSOR_UNREF().
2016-07-23 12:11:34 +02:00
Hallvard Furuseth
32764bcb52 Factor out MDB_SIZE_MAX, MDB_FMT_Y, MDB_FMT_Z 2016-07-23 12:08:12 +02:00
Hallvard Furuseth
84610e65da Add error MDB_PROBLEM, replace some MDB_CORRUPTED
When problem is most likely in txn, not on disk.
2016-07-14 05:53:21 +02:00
Hallvard Furuseth
291c69ddbd ITS#8209 Tweak previous fixes
Some _aligned_malloc() doc seems to think arg NULL = user error.
Don't know if posix_memalign() pointer is defined after failure.
2016-06-29 06:25:37 +02:00
Hallvard Furuseth
5ea12b0be8 ITS#8209 MDB_CP_COMPACT: Handle empty or broken DB
Preserve DB flags (use metapage#1) when main DB is empty.
Fail if metapage root != actual root in output file.
2016-06-25 07:57:04 +02:00
Hallvard Furuseth
eb7bbed967 ITS#8209 MDB_CP_COMPACT fixes
Handle errors.  Fix cond_wait condition so mc_new
is the sole control var.  Drop specious cond_waits.
Do not look at 'mo' while copythr writes it.
2016-06-25 07:55:34 +02:00
Hallvard Furuseth
c4c7833d24 mdb_env_setup_locks: Plug mutexattr leak on error 2016-06-05 23:42:44 +02:00
Hallvard Furuseth
53a0fdf1be Init "locked" flag for SysV semaphores 2016-06-03 06:11:54 +02:00
Howard Chu
c367c1f696 ITS#8339 Solaris 10/11 robust mutex fixes
Check for PTHREAD_MUTEX_ROBUST_NP definition (this doesn't work
on Linux/glibc because they used an enum). Zero out mutex before
initing.
2016-06-02 21:01:27 +01:00
Howard Chu
b045bce260 ITS#8424 init cursor in mdb_env_cwalk 2016-05-15 00:44:54 +01:00
Hallvard Furuseth
e2b8b6448d Comment ovpage code in mdb_cursor_put() 2016-05-10 07:11:44 +02:00
Howard Chu
a04aad31c2 ITS#8412 fix NEXT_DUP after cursor_del 2016-04-26 12:52:21 +01:00
Howard Chu
37081325f7 ITS#8406 fix xcursors after cursor_del
Don't leave them uninit'd if they now point at a valid DUP node
2016-04-18 18:07:56 +01:00
Howard Chu
c8dbd772f7 mdb_drop optimization
If we know there are no sub-DBs and no overflow pages, skip leaf scan.
2016-04-09 20:42:45 +01:00
Howard Chu
8fff90db7e ITS#8393 fix MDB_GET_BOTH on non-dup record 2016-03-28 01:36:26 +01:00
Howard Chu
e46d78b7b0 MDB_VL32 - increase max write txn size 2016-03-02 16:29:54 +00:00
Howard Chu
3f62b727cc Tweak MDB_PREV_MULTIPLE for uninit'd cursor 2016-02-16 23:38:43 +00:00
Howard Chu
d909ab2f36 Tweak Win32 errmsg buffer 2016-02-15 00:07:04 +00:00
Howard Chu
5ef1908224 ITS#8324 Map NTAPI result codes to WIN32 codes 2016-02-14 23:53:05 +00:00
Hallvard Furuseth
fcac8d0774 ITS#7992 Fix memleak in prev change 2016-02-04 03:23:13 +01:00
Howard Chu
5f5f4dab9c Happy New Year 2016-01-30 12:54:32 +00:00
Hallvard Furuseth
e394e023e4 Fix MDB_VL32 mdb_cursor_count()/entrycount types 2016-01-28 19:45:01 +01:00
Howard Chu
3f62ddc81c MDB_VL32 change overflow page scan
Just check the requested page, don't worry about any other pages
2016-01-28 14:23:02 +00:00
Howard Chu
5bf313e820 ITS#8363 Fix off-by-one in mdb_midl_shrink 2016-01-28 04:21:32 +00:00
Howard Chu
6f653ca205 MDB_VL32 more for 1ba5adb2ec
fix 32bit overflow in set_mapsize
2016-01-27 11:48:22 +00:00
Howard Chu
8f88b1b0ba ITS#8324 fix a6ccef73ed
Removing the WRITEMAP test dropped this into the MDB_VL32 code path,
which was wrong.
2016-01-26 22:13:01 +00:00
Howard Chu
8c215aa970 ITS#8355 fix subcursors
make sure C_DEL gets reset in subcursor after it moves.
2016-01-24 11:35:42 +00:00
Howard Chu
b5018e26bc Update WRITEMAP doc 2016-01-23 16:51:42 +00:00
Howard Chu
20dec1f69b WIN64 needs off_t redefined too 2016-01-20 01:30:57 +00:00
Howard Chu
a6ccef73ed ITS#8324 fix c4e31434c7
Actually, there is no guarantee that Windows will map newly written
data, so we need VirtualAlloc even for non-WRITEMAP.
2016-01-16 17:13:25 +00:00
Hallvard Furuseth
d6995599b4 lmdb.h Caveats: Reserved vs. actual mem/disk usage 2016-01-12 23:18:06 +01:00
Howard Chu
15880014ba ITS#8346 fix typo in prev commit 2016-01-12 07:13:48 +00:00
Howard Chu
a5bf1648c6 ITS#8347 fix off-by-one in VL32 purge 2016-01-11 20:25:33 +00:00
Howard Chu
447683a824 ITS#8346 free last txn0->mt_rpages in env_close 2016-01-11 20:17:42 +00:00
Howard Chu
27b1c5f366 Add MDB_PREV_MULTIPLE
Logical counterpart to GET_MULTIPLE, NEXT_MULTIPLE
2016-01-07 18:28:29 +00:00
Howard Chu
5db0b54ca1 Fixups for env_copy with large files
wsize was being truncated to 32bits on Windows.
Only try to write 1GB at a time on Windows64;
larger writes fail with ERROR_WORKING_SET_QUOTA.
2016-01-02 12:31:49 +00:00
Howard Chu
53f624bff0 MDB_VL32 fix cursor_unref - ignore cursor with empty stack 2015-12-28 20:31:09 +00:00
Howard Chu
1c2a5888cf ITS#8342 MDB_VL32/WIN32 - close file mapping handle in env_close 2015-12-28 19:38:32 +00:00
Howard Chu
c3852f29af MDB_VL32 tweak prev commit 2015-12-28 19:38:32 +00:00
Howard Chu
7b9928ced4 MDB_VL32 - prevent mixing with non-VL32 builds 2015-12-23 23:02:06 +00:00
Howard Chu
90d1ee279f MDB_VL32 - Fix me_rpmutex usage 2015-12-22 20:24:26 +00:00
Howard Chu
825ab2ad52 MDB_RESERVE doc
Add mdb_put text to mdb_cursor_put description for people who
fail to draw logical conclusions.
2015-12-22 18:30:41 +00:00
Howard Chu
9d75a82ae1 MDB_VL32 - fix prev commit
Only tweak length for read-only envs
2015-12-22 06:13:25 +00:00
Howard Chu
5eb25c5cb9 MDB_VL32 - fix for Win32 read-only envs
We can't map with MEM_RESERVE because that requires write access
to the underlying file/section. Mapping with the default (MEM_COMMIT)
requires that we don't map past the end of the file.
2015-12-22 05:20:33 +00:00
Howard Chu
3a2ac24f5b MDB_VL32 - track overflow pages too
Otherwise they'll fill up the txn's pageref list when traversing
a DB with lots of overflow records.
2015-12-22 04:22:01 +00:00
Hallvard Furuseth
6534b804a5 mdb_page_alloc(): Use original snapshot of freeDB.
I can't help thinking this should be safer, and useful somewhere.
2015-12-22 04:21:23 +00:00
Hallvard Furuseth
33025182cc Prep for next commit: C_WRITEMAP, C_ORIG_RDONLY.
No change in behavior.
2015-12-22 04:21:13 +00:00
Hallvard Furuseth
397d85d13c Pass cursor to mdb_page_get(), mdb_node_read().
No change in behavior.
2015-12-22 04:20:41 +00:00
Howard Chu
209b56fead ITS#8324 fix for WRITEMAP
We called FlushViewOfFile with (map,mapsize) which worked fine
when we had allocated the entire map already. Now we have to make
sure to only flush as much as was actually written. Add a numpgs
argument to tell how much to flush in env_sync0().
2015-12-21 02:36:20 +00:00
Howard Chu
860527f66e Note that we're prepping for 1.0 2015-12-20 01:08:18 +00:00
Howard Chu
29ebd02efd MDB_VL32 support 64 bit DBs on 32 bit processors 2015-12-20 01:08:18 +00:00
Howard Chu
1ba5adb2ec MDB_VL32 preparation
Use 64 bit types consistently. This keeps database structures the
same size for MDB_VL32 and native 64 bit builds.
2015-12-20 00:19:12 +00:00
Howard Chu
86ae31ebf5 Fix typos 2015-12-19 22:57:00 +00:00
Howard Chu
2cc88d20cc Add Getting Started doc 2015-12-19 22:53:26 +00:00
Howard Chu
c7a786eb00 ITS#7992 cleanup
check for utf8_to_utf16 failures
2015-12-15 18:45:34 +00:00
Hallvard Furuseth
791badd096 mdb_dbi_open(): Catch strdup failure 2015-12-12 19:25:06 +01:00
Howard Chu
8b95e7d13e ITS#8324 fix for read-only envs 2015-12-08 19:35:59 +00:00
Howard Chu
58d1fd4c73 ITS#8336 fix page_search_root assert on FreeDB
Let "illegal" branch pages thru on the FreeDB - the condition
is only temporary and will be fixed by the time rebalance finishes.
2015-12-08 18:21:48 +00:00
Hallvard Furuseth
abb13ba176 ITS#8334 Fix MDB_APPENDDUP vs. rewrite(single item) 2015-12-08 16:43:55 +01:00
Howard Chu
c4e31434c7 ITS#8324 additional tweaks
VirtualAlloc is only needed with WRITEMAP. Regular writes
already extend the mmap implictly.
2015-12-06 20:54:23 +00:00
Sebastien Launay
4198bbde17 ITS#8330 Fix robust mutex detection for glibc 2.10 and 2.11
pthread_mutexattr_setrobust and pthread_mutex_consistent are provided since 2.12 not 2.10:
https://sourceware.org/git/?p=glibc.git;a=commit;h=402cd98775db1478f64c9b0dbe00664b89eb2773
https://sourceware.org/git/?p=glibc.git;a=commit;h=78ee21859939ff75ccf8bbe00499b0c462df2e2d
2015-12-03 19:03:47 +00:00
Howard Chu
45fe870c2e ITS#8169 more Makefile tweaks
Use all the same vars as main OpenLDAP makefiles
2015-12-01 14:10:12 +00:00
Howard Chu
50949b4606 ITS#8169 more for prev patch
Missed the mkdir command
2015-12-01 13:48:29 +00:00
Howard Chu
fb5a768a77 ITS#8324 incremental DB file growth for Windows 2015-11-30 18:46:19 +00:00
Howard Chu
dbbbfa10be ITS#8321 cleanup unused var
from da67af1a4b
2015-11-24 20:21:51 +00:00
Heiko Becker
6cff716f60 ITS#8169 Allow passing mandir to make install
The motivation for this change is my distribution moving to a multiarch
layout. While the architecture specific stuff (binaries, libraries,
etc.) is installed under /usr/${host}/{bin,lib,...} architecture-independent
data should still be installed to /usr/share/.
2015-11-24 16:07:10 +00:00
Heiko Becker
3a4fd79cbf ITS#8168 Allow passing AR to make
This is helpful when the ar executable is named differently, for
example with an arch specific prefix.
2015-11-24 16:04:01 +00:00
Howard Chu
da67af1a4b ITS#8321 fix ambiguity in cursor_put fixup
After delete/add of a node, other nodes may no longer be
pointing at the data they intended. This can confuse subsequent
fixups.
2015-11-24 15:17:28 +00:00
Howard Chu
50d96511f8 Cleanup C_DEL flag usage
Only set it if the cursor's current position was deleted
2015-11-24 15:17:28 +00:00
Howard Chu
1424aa06a6 ITS#8321 More cursor fixup
Based on page_touch fixup from ITS#7594 but expanded:
make sure sub-cursors agree with main cursors.
2015-11-24 15:17:23 +00:00
Howard Chu
69829288dc ITS#8321 page_touch - don't fixup the cursor we just touched 2015-11-24 15:17:19 +00:00
Howard Chu
db02a71dd8 ITS#8321 mdb_put cursor needs tracking too 2015-11-24 15:17:15 +00:00
Howard Chu
cf8677e1b8 ITS#8321 Fix mdb_cursor_set
Always reinit mc_pg[0] if cursor is not C_INITIALIZED
It might have a stale value when using nested txns
2015-11-24 15:17:10 +00:00
Howard Chu
b5ce8108e8 ITS#8321 deinit empty cursors
Always unset C_INIT flag if the cursor's target DB has been deleted
2015-11-24 15:17:06 +00:00
Howard Chu
83258ca81e ITS#8323 Fix nested commit
Must remove our spilled pages from parent's dirty list
2015-11-24 12:46:57 +00:00
Hallvard Furuseth
fae01c8df5 CURSOR_TMP_[UN]TRACK() -> WITH_CURSOR_TRACKING() 2015-11-23 13:03:09 +01:00
Orivej Desh
85d2f9804a ITS#8320 mdb_load: fix loading data from simple text files
mdb_load -T was supposed to read escaped text, but 21b51cb7 "Add mdb_load"
made it read hex.
2015-11-23 02:01:37 +00:00
Orivej Desh
e29cfa0b49 ITS#8319 mdb_load: explain readline and mdb_cursor_put errors 2015-11-23 02:01:21 +00:00
Howard Chu
6fdaea4165 ITS#8321 reorganize page_split fixups
DUPFIXED fixups needed to occur after separator update.
MDB_RESERVE handling moved after split fixup.
2015-11-23 01:40:56 +00:00
Howard Chu
fd598083a7 ITS#8321 simplify page_split fixups 2015-11-23 01:40:56 +00:00
Howard Chu
3a31dd5a8a ITS#8321 track temporary cursors
In rebalance/split operations, temporary cursors need to be visible
to propagate fixups
2015-11-23 01:40:56 +00:00
Howard Chu
828107eb63 ITS#8321 fix mdb_cursor_put
Ignore sub-cursors that shouldn't be fixed up
2015-11-23 01:40:56 +00:00
Howard Chu
0d5ebc508e ITS#8321 fix mdb_cursor_shadow()
Set a valid txn so that cursor fixup code works on the shadows
2015-11-23 01:40:56 +00:00
Howard Chu
88ac698707 ITS#8321 fix mdb_cursor_chk()
It was reporting spurious errors due to uninit'd cursors
2015-11-23 01:40:56 +00:00
Howard Chu
3b9f857d8b ITS#8321 don't skip fixups on splitting cursors
Adjustments can't be skipped, in recursive calls each level must
fixup their own level.
2015-11-23 01:40:56 +00:00
Howard Chu
f3eb26c9bb ITS#8321 Fix del/dupsort
When deleting a dupsort key, if other cursors pointed at that key,
set them to uninit'd, not EOF. They no longer have anything to
point at.
2015-11-23 01:40:45 +00:00
Howard Chu
f3e38565e4 ITS#8316 more for 60c34d14ec 2015-11-23 01:40:01 +00:00
Howard Chu
d6ae2553df ITS#8300 more for prev commit
Just tell explicitly which direction we moved/merged from
2015-11-23 01:02:57 +00:00
Howard Chu
946e4d3b21 Silence some valgrind uninit warnings 2015-11-20 09:47:56 +00:00
Howard Chu
1bfe7578bd Refix root split check from 5da67968af 2015-11-20 09:20:16 +00:00