upstream/openldap
1
0
Fork 0
mirror of https://git.openldap.org/openldap/openldap.git synced 2025-12-20 22:59:34 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions
24520 commits 38 branches 309 tags 68 MiB
Commit graph

640 commits

Author SHA1 Message Date
Hallvard Furuseth
de5b689308 Simpler mdb_env_write_meta() 2015-10-25 10:56:39 +01:00
Hallvard Furuseth
bde5c231bc Kill magic numbers for NUM_METAS, databases 2015-10-25 10:56:38 +01:00
Hallvard Furuseth
8901d9cfbc ITS#7377 Catch mdb_put() to blocked/read-only txns 
...early enough that txn state is left unchanged.
 2015-10-25 10:55:22 +01:00
Hallvard Furuseth
01342bd5d2 ITS#7377 Always notice env error on txn startup. 
Move the check to the end of txn startup.  Catches env
breakage which happens while the new txn waits for a lock.
 2015-10-25 10:55:22 +01:00
Hallvard Furuseth
602c978761 Cleanup: Drop !mt_dbxs hack, use MDB_TXN_FINISHED 2015-10-25 10:55:22 +01:00
Hallvard Furuseth
a3ae2e7db1 Catch most uses of finished/parent txns. 
* Add MDB_TXN_FINISHED, MDB_TXN_HAS_CHILD, MDB_TXN_BLOCKED.
* Clear mt_numdbs in writers, for TXN_DBI_EXIST() to catch.
  We already do in readers.
 2015-10-25 10:55:22 +01:00
Hallvard Furuseth
9266843fa6 Move code into mdb_txn_end(). Was mdb_txn_reset0. 
Side effects:
* Clean txn up a bit even before freeing it.
* Tweak DEBUG output at txn end. Add DEBUG after commit(writer).
 2015-10-25 10:55:22 +01:00
Hallvard Furuseth
0cfc0a9736 Factor me_metas[toggle] out to mdb_env_pick_meta() 2015-10-25 10:55:22 +01:00
Hallvard Furuseth
490243424c Simpler mdb_node_add() 2015-10-25 10:55:22 +01:00
Hallvard Furuseth
6318038138 More ESECT declarations 2015-10-25 10:55:22 +01:00
Hallvard Furuseth
110fba2ef1 Add DB_USRVALID, to avoid 'dbi == FREE_DBI' tests 2015-10-25 10:55:22 +01:00
Hallvard Furuseth
b6f0179683 Simpler flag/DBI checks and MDB_DEBUG 2015-10-25 10:55:22 +01:00
Hallvard Furuseth
06df0a4655 Simpler mdb_drop(). 
MDB_DBI_CHANGED(,MAIN_DBI) is never true.
 2015-10-25 10:55:22 +01:00
Hallvard Furuseth
e5f41ce56b Simpler mdb_node_shrink() 2015-10-25 10:55:22 +01:00
Hallvard Furuseth
9d6c973f76 Simpler mdb_txn_commit(). 
mt_env is always set.
Commit(mt_child) resets mt_child, so parent need not.
 2015-10-25 10:55:22 +01:00
Hallvard Furuseth
ee06adb311 mdb_txn_begin() cleanup 2015-10-25 10:55:22 +01:00
Hallvard Furuseth
cc2a50aca2 mdb_drop0(): Omit scanning DUPSORT sub-DB leaves 2015-10-25 10:55:21 +01:00
Hallvard Furuseth
70788bfe45 Use mdb_cmp_long() for FREE_DBI 2015-10-25 10:55:21 +01:00
Hallvard Furuseth
a36f7a7fc2 mdb_env_get_flags(): Hide internal flags 2015-10-25 10:55:21 +01:00
Hallvard Furuseth
600e2b6ce0 Support robust mutexes/locks. Add mdb_mutex_t etc. 2015-10-25 10:55:21 +01:00
Hallvard Furuseth
3a71450436 Add MDB_USE_POSIX_MUTEX. 
So far just to help aligning mdb.master and mdb.RE.
We'll make it an option later.
 2015-10-25 10:55:21 +01:00
Hallvard Furuseth
f25c4f0db9 Whitespace (align with mdb.master) 2015-10-25 10:55:21 +01:00
leo@yuriev.ru
086bc04cd2 ITS#7969 Use __sync_synchronize() 
The rest of 9a80a8a8e8
plus commit a937740aa0.
 2015-10-25 10:55:21 +01:00
Hallvard Furuseth
3f6fa7aece Set/clear mp_pad, md_pad (MDB_DUPFIXED data size). 
mdb_xcursor_init1(): md_pad is only used when MDB_DUPFIXED.
mdb_page_split():    Copy mp_pad too. Used by mdb_page_list().
 2015-10-25 10:55:21 +01:00
Hallvard Furuseth
c616689d9a Cleanup MDB_env.me_txn0. 
More fallout from 4d02c741b1.
 2015-10-25 10:55:21 +01:00
Hallvard Furuseth
c0170bc0ec Copy some env flags to txn. Factor out flags. 
Taken from mdb_txn_begin(,,MDB_NOMETASYNC, MDB_NOSYNC,,)
without adding those two flags yet, to align with mdb.master:
Part of 54516639ac (Renumber...)
+ 8adee9464f (Fix per-txn...).
 2015-10-25 10:55:21 +01:00
leo@yuriev.ru
c65ca298b9 ITS#7971 mdb_txn_renew0(): Fix new readers slots. 
commit 9a8eb95674 (mdb_txn_renew0)
plus b2ab9910dd (reader allocation)
from mdb.master.
 2015-10-25 10:55:21 +01:00
David Barbour
076b773d6b ITS#7994 Access to current transaction ID. 
commit b660491d3f (mdb_txn_id())
plus c36c167cc4 (fix prev commit)
from mdb.master.
 2015-10-25 10:55:21 +01:00
Hallvard Furuseth
f3d3f60e3d Try to avoid an invalid datafile after failed init 2015-10-25 10:55:21 +01:00
Hallvard Furuseth
aa10c98f3f For ITS#7789: Ensure mapsize >= pages in use. 
Check new mapsizes against mm_last_pg.  Move
mdb_env_init_meta0() so it can set mm_last_pg earlier.
 2015-10-25 10:55:21 +01:00
Ignacio Casal Quinteiro
52446f93e7 ITS#8270 win32: fix conversion error with MSVC 2015-10-25 08:10:34 +00:00
Howard Chu
24add6589b ITS#7771 fix cursor tracking on fake pages 
node_del shifts nodes around, cursors pointing at fake pages
need to have their mc_pg[0] corrected.
 2015-10-25 08:10:13 +00:00
Hallvard Furuseth
448b4c815a ITS#8263 streamline prev patch 2015-10-25 08:09:16 +00:00
Howard Chu
7e3c532823 ITS#8263 fix cursor tracking in cursor_put 2015-10-25 08:09:06 +00:00
Howard Chu
9ed1e57440 ITS#8264 fix cursor_del cursor tracking 
Some destination fixups need to happen immediately after nodes
are moved, before rebalancing
 2015-10-25 08:08:53 +00:00
Howard Chu
8bdadf68c5 ITS#8258 fix rebalance/split 
The tree height can also increase during rebalance, not just shrink.
This can happen if update_key needs to split a parent branch page.
 2015-10-04 02:13:07 +01:00
Howard Chu
be1795a616 ITS#8221 fix typos 2015-09-29 17:32:25 +01:00
Howard Chu
4b01cb3727 ITS#8221 don't merge branch pages needlessly 2015-09-27 22:35:54 +01:00
Howard Chu
d84fae3fe3 ITS#8237 fix ITS#7589 regression 2015-09-12 23:07:16 +01:00
Hallvard Furuseth
7f151b1137 ITS#7377 mdb_env_init_meta(): Catch calloc error 2015-09-12 23:07:07 +01:00
Howard Chu
d139771b43 ITS#8192 fix reference to EINTR on WIN32 from ITS#8106 2015-07-30 00:51:04 +01:00
Hallvard Furuseth
4b58502c77 ITS#8200 Fix mdb_midl_shrink() usage, return void 2015-07-28 15:13:22 +01:00
Hallvard Furuseth
1fd0341f76 ITS#8181 Verify that records are/aren't DBs. 
Except we don't catch the user passing F_SUBDATA to
mdb_cursor_<put/del>, like an internal LMDB call.
 2015-07-28 15:13:10 +01:00
Howard Chu
7513bd4618 ITS#8190 fix cursor EOF bug 2015-07-28 15:12:58 +01:00
Hallvard Furuseth
a0b96697c5 ITS#8156 Fix MDB_MAXKEYSIZE doc 2015-05-28 20:51:39 +02:00
Hallvard Furuseth
6bfadb9178 ITS#8157 mdb_txn_renew0(): init after error checks 2015-05-28 00:12:18 +02:00
Hallvard Furuseth
822b2d502f ITS#8117 Fix MDB_INTEGERDUP keysize doc + md_dcmp 2015-05-28 00:08:51 +02:00
Howard Chu
6bd97d4286 ITS#8117 better fix 
Don't change mc_dbx because we would need to undo the change if
the txn aborts. Make the fix (for get) match existing code for put.
 2015-05-03 07:52:47 +01:00
Howard Chu
7127753244 Revert "ITS#8117 cleanup prev commit" 
This reverts commit 47c4e747a0.

Revert "ITS#8117 fix INTEGERDUP compare"

This reverts commit ba45e0c05a.
 2015-05-03 07:43:50 +01:00
Howard Chu
47c4e747a0 ITS#8117 cleanup prev commit 2015-04-29 17:30:02 +01:00
Howard Chu
ba45e0c05a ITS#8117 fix INTEGERDUP compare 2015-04-29 17:12:40 +01:00
Howard Chu
b7511480c5 ITS#8109 fix mdb_cursor_del0 on empty DB 2015-04-23 05:50:48 +01:00
Howard Chu
32d46d4ea2 ITS#8106 retry writes on EINTR 2015-04-23 03:26:03 +01:00
Hallvard Furuseth
f46b642b06 mdb_txn_renew(): Clear error from previous txn 2015-04-19 03:05:47 +02:00
Howard Chu
dce0911b17 ITS#8062 fix uninit'd cursor index 2015-04-19 03:05:47 +02:00
Howard Chu
b0032feb85 ITS#8062 also handle subcursors 2015-04-16 00:19:40 +01:00
Howard Chu
97c7b6151e ITS#8062 fix rebalance 
(Probably fixes the ITS, definitely fixes a bug) when collapsing
the root page, fixups of other cursors was incomplete.
 2015-04-15 23:30:52 +01:00
Quanah Gibson-Mount
21a374f2d4 Happy New Year 2015-02-12 11:28:21 -06:00
leo@yuriev.ru
8230b1b630 ITS#7970 LMDB: Critical Heisenbug 
Inconsistent reading & SIGSEGV due to the race condition.
 2015-01-14 19:24:18 +01:00
leo@yuriev.ru
1e5d79831c ITS#7969 LMDB: volatile. 
Globally shared fields of meta-data were not 'volatile'.
Code from 9a80a8a8e8,
except the unportable __synchronize().
 2015-01-14 19:24:18 +01:00
Howard Chu
ea80418cfc Fix potential null deref (coverity) 2015-01-13 19:22:42 +00:00
Howard Chu
bf3961e3c7 More cleanup for fdatasync hack 2015-01-12 10:41:32 +00:00
Howard Chu
e85c944a3a Tweak conditionals for fdatasync hack 2015-01-11 11:41:08 +00:00
Howard Chu
0b9f42d1f4 ITS#8021 env_sync is invalid in RDONLY env 2015-01-09 11:25:07 +00:00
Howard Chu
4500d49f36 fdatasync hack, again 
Check for ext3/ext4 fs, then check kernel version.
 2015-01-08 13:03:55 +00:00
Howard Chu
888a76f651 Revert "Fix prev commit for env_sync0" 
This reverts commit e95c9231fc.

Revert "Hack for potential ext3/ext4 corruption issue"

This reverts commit 91155b9d67.
 2015-01-08 12:57:08 +00:00
Howard Chu
e95c9231fc Fix prev commit for env_sync0 2014-12-21 00:14:16 +00:00
Howard Chu
91155b9d67 Hack for potential ext3/ext4 corruption issue 
Use regular fsync() if we think this commit grew the DB file.
 2014-12-18 04:45:02 +00:00
Leo Yuriev
196e07ca58 ITS#7987 fix excessive space for single write txn 2014-12-05 21:07:55 +00:00
Hallvard Furuseth
f284c3232d Fix WIN32 -> _WIN32 2014-12-05 18:43:07 +01:00
Hallvard Furuseth
8704eff591 mdb_strerror: Silence warning @ Windows 2014-12-01 20:17:27 +01:00
Hallvard Furuseth
5bf495abdc Fix comments 2014-12-01 20:17:27 +01:00
Hallvard Furuseth
3aa7537adc Simplify recent changes a bit. 2014-12-01 20:17:27 +01:00
Hallvard Furuseth
17bf75b12e ITS#7961,#7987 Re-fix txn init. 
More fallout from 4d02c741b1:
Don't modify another thread's write txn. Reinit me_txn0 fully.
 2014-12-01 20:17:13 +01:00
Howard Chu
3ce002fd13 ITS#7959 fix prev commit 
fstat returns -1, not an errno. Move code into its own function
for reuse.
 2014-12-01 20:15:36 +01:00
Howard Chu
ce40f4f314 ITS#7961 fix txn init 
More fallout from 4d02c741b1
 2014-12-01 20:15:36 +01:00
Jean-Christophe DUBOIS
042e76685e ITS#7959 Check fstat return value 
Signed-off-by: Jean-Christophe DUBOIS <jcd@tribudubois.net>
 2014-12-01 20:15:36 +01:00
Howard Chu
98ed192949 ITS#7956 fix compact of empty env 2014-12-01 20:15:36 +01:00
Howard Chu
af99820ac8 ITS#7955, #7671 fix MDB_PREV_DUP 2014-12-01 20:15:36 +01:00
Howard Chu
df9da7c7be Must do dlist_free before releasing Wmutex 2014-12-01 20:15:35 +01:00
Howard Chu
9eede0b103 Free write mutex earlier in txn_reset0 2014-12-01 20:15:30 +01:00
Howard Chu
a7639a66a4 Android also only has memalign 2014-09-25 19:25:56 +01:00
Howard Chu
62e4eeb7f7 ITS#7943 reinit txn flags 
When reusing the main write txn
 2014-09-19 01:45:43 +01:00
Howard Chu
891e662754 Plug leak in 4d02c741b1 
Free writer txn on env_close
 2014-09-18 01:22:02 +01:00
Quanah Gibson-Mount
5ee99f1125 Change retry to num times 60. Testing shows that on a known dataset, this has the same growth behavior as 2.4.39, while num times 20 resulted in significant growth. 2014-09-13 16:21:17 -05:00
Howard Chu
3646ba966c More for me_pgoldest 
Leave it in main env struct, it doesn't need to be rolled back
with nested txns.
 2014-09-09 19:44:23 +01:00
Howard Chu
29fd241fad Remember oldest reader txnid 
Don't walk the readers table unless we really need to.
 2014-09-09 19:40:05 +01:00
Howard Chu
4d02c741b1 Use a single write txn 2014-09-04 10:40:11 +01:00
Howard Chu
a054a194e8 ITS#7913 cleanup 
we already checked for data == NULL, drop unnecessary if
 2014-08-24 21:18:03 +01:00
Howard Chu
8fbbc71506 More for MIPS 
Move CACHEFLUSH, avoid unnecessary if()
 2014-08-21 17:40:20 -07:00
Howard Chu
4008e5e583 Partially revert ada2630699 
Of course, MacOSX only has posix_memalign, and only in recent versions.
(Older versions could use valloc instead. That precludes ever changing
the LMDB pagesize to be different from the OS pagesize.) Not all that
crucial since it only affects mdb_env_copyfd1.
 2014-08-17 20:44:53 -07:00
Hallvard Furuseth
cf4fe3b1fb Microoptimize loose pages 2014-08-17 01:50:32 +02:00
Hallvard Furuseth
1e7eeed28d Fix loose pages in mdb_freelist_save(). 
Leaving them in dirty_list caused breakage.  Instead merge them
into me_pghead at the end, when no more pages will be allocated.
 2014-08-17 00:29:12 +02:00
Hallvard Furuseth
983f896aa7 Split out mdb_midl_xmerge, add MDB_IDL_ALLOCLEN 2014-08-16 11:34:44 +02:00
Howard Chu
322cd26a7b ITS#7917 fix mdb_dbi_open 
Don't let dummy go out of scope
 2014-08-11 11:00:11 -07:00
Howard Chu
ada2630699 Just use memalign, not posix_memalign 
Everything has it. Solaris doesn't have posix_memalign.
 2014-08-07 11:06:53 -07:00
Howard Chu
899b23f89d More for MIPS 
Do a cacheflush after writing data pages, separate from meta's cacheflush
 2014-08-04 11:40:24 -07:00
Howard Chu
ae0c9f484d ITS#7793 more for branch key update 2014-08-04 09:26:35 -07:00
Howard Chu
f21f15e5a0 ITS#7793 update branch key if needed 2014-08-04 04:57:53 -07:00
Howard Chu
9febe03eb5 More for MIPS 
Paranoia for 3630066843 do the
cacheflush before setting mti_txnid.
 2014-08-02 10:33:35 -07:00
Howard Chu
8498c6cba2 ITS#7913 mdb_cursor_get(*_DUP) cleanup 
FIRST_DUP/LAST_DUP should succeed even on non-duplicate values
PREV_DUP should reset cursor's EOF flag.
 2014-07-31 09:59:52 -07:00
Howard Chu
3630066843 Fix MIPS cache coherency on Linux 
MIPS chips require manual control of on-chip caches. The cacheflush
syscall being used here only exists on MIPS Linux, other OSs will
require revisiting.
 2014-07-26 18:16:02 -07:00
Howard Chu
082bac1492 more for mdb_cursor_count 
return MDB_NOTFOUND if the cursor is empty
 2014-07-24 04:13:55 -07:00
Hallvard Furuseth
6cb1166635 Fix mdb_copy & co when MDB pagesize < OS pagesize 2014-07-24 04:04:24 -07:00
Hallvard Furuseth
81b502e17e ITS#7789 Fix mdb_env_write_meta(). 
Always write mapsize = max(other metapage:mapsize, env:mapsize).
 2014-07-23 17:25:42 -07:00
Howard Chu
7ef970436d Revert ITS#7789 commits, let's try this again. 
Revert "ITS#7789 Fix resize vs MDB_NOMETASYNC, and a comment."
Revert "ITS#7789 more"
Revert "Revert "ITS#7789 update RESIZED errmsg text""
Revert "ITS#7789 update RESIZED errmsg text"
Revert "ITS#7789 persist mapsize changes"

This reverts commit 02285aca58.
This reverts commit 38e71c68de.
This reverts commit a5e4eecb1e.
This reverts commit d8e18551c3.
This reverts commit 5926e54bba.
 2014-07-23 17:19:33 -07:00
Howard Chu
58e9c3add8 Fix mdb_cursor_count, reject uninit'd cursor 2014-07-21 08:33:59 -07:00
Howard Chu
9049efe493 ITS#7896 fix for mdb_env_map 
Don't pass non-NULL map address unless MDB_FIXEDMAP was used.
 2014-07-14 09:53:36 -07:00
Howard Chu
886ee41d55 More for cursor EOF 
Must also set in sub-cursor if deleting entire subDB
 2014-07-09 15:03:54 -07:00
Howard Chu
7f038d0f15 Zero-init copy2 writebuf 2014-07-09 12:05:37 -07:00
Hallvard Furuseth
2825ad64c2 MDB_MAXKEYSIZE = 0 (dynamic value) when MDB_DEVEL 2014-07-09 20:18:08 +02:00
Hallvard Furuseth
b3dedde612 MDB_DEVEL doxygen fix 2014-07-09 20:17:13 +02:00
Hallvard Furuseth
02285aca58 ITS#7789 Fix resize vs MDB_NOMETASYNC, and a comment. 2014-07-09 20:16:33 +02:00
Howard Chu
bda6a60ad4 Windows fixes 
Always set the filesize when opening for writes. Otherwise
can't use backups from mdb_copy.
 2014-07-09 10:22:25 -07:00
Howard Chu
f3573a7383 Windows compat 
We mainly use Win32 functions, so cannot just use C-runtime strerror
to return error messages. We have to use Win32-specific messages.
Unfortunately, we document the API to return C-runtime error codes,
so we can't just switch to all Win32 error codes.
 2014-07-09 10:02:21 -07:00
Howard Chu
38e71c68de ITS#7789 more 
persist size changes from env_open() as well. This was the
original behavior.
 2014-07-09 06:54:32 -07:00
Howard Chu
a5e4eecb1e Revert "ITS#7789 update RESIZED errmsg text" 
This reverts commit d8e18551c3.
And partially reverts mapsize check. Only mapsize increases are relevant.
 2014-07-09 06:19:06 -07:00
Howard Chu
d5371347e8 ITS#7825 more 
Set read txn's dbiseqs to env's. Set child txn's dbiseqs to parent's.
Simplify DBI_CHANGED test, no need to check md_name. No-op dbi_close
of already closed handle.
 2014-07-09 05:55:30 -07:00
Howard Chu
276aa55969 ITS#7825 more 
only update dbiseq in dbi_open on write txns
 2014-07-08 21:31:48 -07:00
Howard Chu
04851e442f ITS#7825 tweak prev commit 
dbiseqs are only checked in write txns so omit from read txns
 2014-07-08 21:22:07 -07:00
Howard Chu
0401f2deed ITS#7825 add MDB_BAD_DBI error code 
Use DBI sequence numbers to detect DBIs being closed while in use.
 2014-07-08 21:02:40 -07:00
Howard Chu
d8e18551c3 ITS#7789 update RESIZED errmsg text 2014-07-08 20:05:31 -07:00
Howard Chu
5926e54bba ITS#7789 persist mapsize changes 
Write decreases too, not just increases. Check for any size change
that was not requested by this process.
 2014-07-08 19:18:02 -07:00
Howard Chu
2f04728471 ITS#7892 Fix MacOSX section name 2014-07-08 16:27:03 -07:00
Hallvard Furuseth
e1a676eb18 ITS#7713 cleanups 
'#ifdef MDB_DEVEL' -> '#if MDB_DEVEL'
Fix comments, use actual PAGEBASE macro as originally intended.
Actually enable 64K pages. Set MDB_DATA_VERSION for testing only.
 2014-07-08 15:01:18 -07:00
Hallvard Furuseth
6ed295b256 Fixes for loose pages 
mdb_txn_commit(child): Give loose pages to parent.
Use a pointer beyond the page header instead of mp_next, so
we will not need to save/restore mp_pgno. This avoids a crash
caused by references to mp_pgno.
 2014-07-08 14:39:57 -07:00
Howard Chu
b3e8c71dc7 Re-fix cursor EOF 
Fix in 534dcc7212 was in wrong place
 2014-07-08 11:54:24 -07:00
Howard Chu
68e6faad5c ITS#7713 handle 65536 byte page size 
Fix mp_lower/mp_upper to exclude PAGEHDRSZ, which means our
max mp_upper is now pagesize - PAGEHDRSZ and won't overflow.
Currently must define MDB_DEVEL to use. Will be default for
LMDB 1.0/OpenLDAP 2.5
 2014-07-07 17:31:15 -07:00
Howard Chu
534dcc7212 Set xcursor EOF after deleting last entry 2014-07-07 17:13:51 -07:00
Howard Chu
1ac5147fc1 Compacting copy doesn't need to snapshot metas 2014-07-06 17:47:25 -07:00
Howard Chu
61f7ec9bfa Windows fixes 2014-07-06 07:49:38 -07:00
Howard Chu
7d996d7f3d Play games with object file layout 
Use gcc section attribute to keep less frequently used functions
away from main code.
 2014-07-05 08:48:47 -07:00
Howard Chu
3e98addbe2 Rationalize mdb_env_copy2 API 2014-07-05 07:49:10 -07:00
Howard Chu
059b357d1a More tweaks to copyfd2 
Make sure the writer thread starts and stops when we expect it to.
 2014-07-03 14:26:14 -07:00
Howard Chu
03f0ecb001 More copyfd2 tweaks 2014-07-03 10:49:05 -07:00
Howard Chu
6043103c13 Fix envinfo to return fixed map address 2014-07-03 08:31:57 -07:00
Howard Chu
64191264b8 Windows compat 2014-07-03 07:49:22 -07:00
Howard Chu
8836b78e94 Fix subDB/ovpage copying 2014-07-02 11:44:06 -07:00
Howard Chu
af3c340758 Larger WBUF still better on large DB 2014-07-02 08:07:11 -07:00
Howard Chu
342cd72f25 Don't check LEAF2 pages for subnodes 2014-07-02 07:45:12 -07:00
Howard Chu
4009c9ae65 Add mdb_env_copy2() 
And mdb_env_copyfd2(). Perform compaction on the copy. Trims out
freed pages and renumbers data pages in sequential order. This is
more CPU-intensive since it copies and modifies data pages.
 2014-07-01 21:45:43 -07:00
Howard Chu
b09e46904c ITS#7886 fix mdb_copy write size 
Don't try to write past end of file
 2014-06-30 04:41:50 -07:00
Hallvard Furuseth
91d8ad1d3c Fix mdb_page_loose() vs. mdb_page_flush(). 
Do not overwrite loose pages' mp_pgno with mp_next.
mdb_page_flush() will use mp_pgno to rebuild dirty_list.
 2014-06-28 13:38:03 +02:00
Howard Chu
a3e5539505 More for mdb_page_loose 
Require that the page is dirty in the current txn,
not a parent txn.
 2014-06-24 11:43:13 -07:00
Howard Chu
7fe85f5c82 More MDB -> LMDB renames 2014-06-24 04:42:44 -07:00
Howard Chu
225bcae3e7 Flesh out mdb_cmp_cint for BigEndians 2014-06-23 07:36:38 -07:00
Howard Chu
aa89ca31b3 More for page_loosen 
Don't try this when working on the FreeDB. Again,
too much hassle to unkink the recursions...
 2014-06-22 16:39:14 -07:00
Howard Chu
d9423e13f8 More cleanup for page_merge, page_loosen 
Only loosen src page if it's actually dirty.
Refactor page refs in page_merge.
 2014-06-21 15:53:41 -07:00
Howard Chu
7cab7b95e2 Handle loose pages 
Pages that were dirtied and deleted in the same txn should be
reused, instead of consuming freeDB pages.
 2014-06-21 03:30:34 -07:00
Howard Chu
eebbd22c2f Fix mdb_page_merge 
Similar to prev commit for mdb_node_move, the call of
mdb_page_serch_lowest() was leaving csrc unusable.
 2014-06-20 23:40:44 -07:00
Howard Chu
79e8462d74 Fix mdb_node_move 
Was leaving stale info in dst cursor
 2014-06-20 17:56:04 -07:00
Howard Chu
3e83b5b27b Add mdb_dump, update copyrights 2014-06-20 06:36:30 -07:00
Howard Chu
39ed8bef04 Tweak ovpage search 
Use num*20, chosen from empirical testing
 2014-06-18 13:37:04 -07:00
Howard Chu
b4ecbd78d9 Fix some overwrite quirks 
Was skipping the overwrite in some cases, if the cmp function
said the new and old already matched. We should always perform
the overwrite anyway, since the cmp function may only be doing
a prefix compare and the data may actually be different.
 2014-06-18 12:29:13 -07:00
Howard Chu
dc7f2530dd Tweak prev patch for ovpage search 2014-06-18 09:07:39 -07:00
Howard Chu
2db55c7d99 Shorten search for ovpage space 2014-06-18 03:02:08 -07:00
Howard Chu
17c09fa476 ITS#7875 fix #7681 regression 
Due to commit 18a07eb7c2
 2014-06-11 02:27:56 -07:00
Alexey Naumov
a93810cc3d Fix possible crash in DLL_THREAD_DETACH (explodes in .Net Framework) 2014-05-30 23:39:44 -07:00
Hallvard Furuseth
c0d64cf182 Comment ~MDB_APPEND, from earlier commit message. 2014-05-30 10:50:04 +02:00
Hallvard Furuseth
cb5656c726 Factor out mdb_cmp_clong() 2014-05-30 10:47:56 +02:00
Hallvard Furuseth
64a02e2279 More for big MDB_MAXKEYSIZE with MDB_DUPSORT. 
With mdb_cursor_put(new key, data item big enough to need a sub-DB):
- Track cursors as when adding other nodes.  The "!do_sub" is now
  unneeded.  Before ITS#7861 it distinguished inserting key from data.
- Set MDB_TXN_ERROR if an empty sub-DB was created.  I.e. adding
  key:subDB succeeded, but inserting the data item failed.
 2014-05-30 10:47:56 +02:00
Hallvard Furuseth
b37b2a651f Factor out MDB_TXN_ERROR 2014-05-30 09:06:08 +02:00
Hallvard Furuseth
ba8f59edf4 Simplify MDB_MULTIPLE 2014-05-30 09:06:08 +02:00
Hallvard Furuseth
ac158c7e1e ITS#7834 Fix MDB_MULTIPLE writing multiple keys. 
Update the state before looping, so the key is not duplicated.
Broke in 4c8f57615c (mostly).
 2014-05-30 09:06:08 +02:00
Hallvard Furuseth
d170df58fb ITS#7861 Re-fix MDB_db.md_entries. 
mdb_cursor_del(): Fix md_entries with MDB_NODUPDATA.
mdb_cursor_put(): Check in xcursor whether an item got inserted. Count
data instead of keys after 13d6d59c51.
 2014-05-30 09:06:08 +02:00
Hallvard Furuseth
83676dc0f0 Document DBI issues, extend MDB_BAD_VALSIZE. 2014-05-30 09:06:08 +02:00
Hallvard Furuseth
2f33effcdc More ITS#7793 Check key->mv_size with MDB_CURRENT. 
Since non-NULL key must be provided now.
 2014-05-30 09:06:08 +02:00
Howard Chu
4b9aed26a5 Fix mdb_rebalance collapsing root 
Shift the rest of the cursor stack as needed
 2014-05-20 08:47:28 -07:00
Howard Chu
4844a72d01 ITS#7829 more for mdb_rebalance 
Make sure to propagate rebalance results all the
way back to original caller's cursor.
 2014-04-03 12:51:41 -07:00
Hallvard Furuseth
2764360a7b ITS#7829 Simplify last commit 2014-04-02 07:02:14 +02:00
Howard Chu
fca18d2586 ITS#7829 more for prev commit 2014-03-31 13:42:19 -07:00
Howard Chu
ac3acc1218 ITS#7829 fix rebalance 
Fixup cursor state after node_move/page_merge
 2014-03-28 13:51:59 -07:00
Howard Chu
13d6d59c51 ITS#7793/7828 
Fix md_entries count, test for insert on md_entries increment
 2014-03-26 08:59:43 -07:00
Howard Chu
f537429b64 ITS#7828, #7793 
Clarify MDB_CURRENT key usage, simplify freelist_save
 2014-03-26 02:35:56 -07:00
Howard Chu
9026894e05 Revert "ITS#7793 mdb_cursor_put(): Fix MDB_CURRENT." 
This reverts commit 4e954f8ae8.
Caused ITS#7828.
 2014-03-26 02:35:45 -07:00
Hallvard Furuseth
86d9675543 Revert "Update MDB_PANIC description" (thinko). 
This reverts commit 6bd34d0534.
 2014-03-23 13:06:03 +01:00
Hallvard Furuseth
6bd34d0534 Update MDB_PANIC description 2014-03-22 22:27:10 +01:00
Hallvard Furuseth
1519f4bc3d Tweak mdb_mid2l_insert() call from ITS#7775. 
It does not return MDB error codes.
 2014-03-22 22:27:10 +01:00
Hallvard Furuseth
68e97b2184 Handle more errors. Invalidate txn if needed. 2014-03-16 12:42:43 +01:00
Hallvard Furuseth
937b5eff07 Don't use non-existent node info in branch/leaf2 2014-03-16 12:42:42 +01:00
Hallvard Furuseth
86f8b203f5 Move code out of mdb_cursor_del0() and mdb_del(). 
Prepares for the next commits.
 2014-03-16 12:42:42 +01:00
Hallvard Furuseth
012d7b5de7 More checks for closed DBIs and invalidated txns. 
Factor txn/DBI-checks out to TXN_DBI_EXIST().
mdb_audit(): Skip closed DBIs.
mdb_cursor_renew(), mdb_stat(): Check DBI and txn.
mdb_cursor_count(): Check txn.
mdb_dbi_flags(): Check DBI.
 2014-03-16 12:42:42 +01:00
Hallvard Furuseth
3e7c1bd4e2 mdb_page_list(): Support & display all page types 2014-03-16 12:42:42 +01:00
Hallvard Furuseth
a22c31115f mdb_txn_renew0(): Fix un-mutexed me_flags update. 
Replace env flag MDB_LIVE_READER with field me_live_reader.
 2014-03-16 12:42:42 +01:00
Hallvard Furuseth
684bb867ce Doxygen fixes 2014-03-16 12:42:42 +01:00
Howard Chu
797ff136a8 ITS#7815 more for page_split 
This case didn't come up in testing. Needs finer grained test.
 2014-03-05 20:40:12 -08:00
Howard Chu
0e7fba73b7 ITS#7815 fix mdb_page_split 
Was leaving cursor pointed at wrong page if the newindx was
in the right sibling page, and the parent was also split.
 2014-03-05 20:04:42 -08:00
Hallvard Furuseth
4e954f8ae8 ITS#7793 mdb_cursor_put(): Fix MDB_CURRENT. 
Ignore key, broken by 5bda3565a9
and some older code.  Document and clarify MDB_CURRENT usage.

Also affects non-MDB_CURRENT put() with empty data and a key
which matches by the mdb_set_compare function but not by memcmp.
 2014-01-28 14:27:27 +01:00
Hallvard Furuseth
98f3bc88bf Revert "ITS#7772 Reduce spurious sub-page growth." 
This reverts commit 75494c08b4,
which must await a fix to ITS#7771 (DUPSORT cursor tracking).
 2014-01-13 20:46:08 +01:00
Howard Chu
3f241365d5 Make sure mapsize changes take effect on Windows. 2014-01-12 20:04:50 -08:00
Hallvard Furuseth
5bda3565a9 ITS#7775 Drop <assert.h>, drop/replace assert()s. 
db_mid2l_insert(): Move assert to mdb.c.
mdb_cursor_set(): Previous assert cannot fail now.
mdb_cursor_put(): Check mc/key and return EINVAL.
mdb_cursor_dbi(): No error return, so just segfault if cursor==NULL.
 2014-01-06 23:21:54 +01:00
Howard Chu
6fb561d33e ITS#7775 Cleanup mdb_node_del() 2014-01-06 23:21:44 +01:00
Hallvard Furuseth
88342f9661 ITS#7775 Add mdb_env_set_assert() 2014-01-06 23:17:38 +01:00
Hallvard Furuseth
e40dae1064 Add mdb_env_<set,get>_userctx() 2014-01-06 23:17:38 +01:00
Hallvard Furuseth
c99525f42a ITS#7377 Invalidate txn on page-allocation errors 
This should likely be reverted when all callers handle these errors.
 2014-01-06 23:17:37 +01:00
Hallvard Furuseth
123b6e3c3e Wrap __func__ in mdb_func_ 2014-01-05 16:37:26 +01:00
Hallvard Furuseth
21621cc741 Invalidate the txn on corruption/internal errors 2014-01-05 16:26:21 +01:00
Howard Chu
c48cdd7a16 ITS#7775 cleanup unnecessary assert()s 2014-01-03 12:40:28 -08:00
Hallvard Furuseth
1f191ba930 mdb_page_malloc(): Move VGMEMP_ALLOC before memset 2013-12-31 02:16:19 +01:00
Hallvard Furuseth
ce2a0d4016 ITS#7771 mdb_cursor_del0(): Fix xcursor tracking. 2013-12-29 15:58:21 +01:00