upstream/openldap
1
0
Fork 0
mirror of https://git.openldap.org/openldap/openldap.git synced 2026-05-28 04:35:57 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

ITS#10475 Escape asserted value before pasting into filter

Browse source
This commit is contained in:
Ondřej Kuzník 2026-04-07 15:52:47 +01:00 committed by Quanah Gibson-Mount
parent cb38aa58ad
commit ff744ba11e
3 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
servers/slapd/overlays/constraint.c
View file

@ -657,7 +657,7 @@ constraint_violation( constraint *c, struct berval *bv, Operation *op )
int found = 0;
int rc;
size_t len;
struct berval filterstr;
struct berval filterstr, escaped;
char *ptr;
cb.sc_response = constraint_uri_cb;
@ -701,11 +701,13 @@ constraint_violation( constraint *c, struct berval *bv, Operation *op )
c->filter.bv_len +
STRLENOF(")(|");
filter_escape_value_x( bv, &escaped, op->o_tmpmemctx );
for (i = 0; c->attrs[i]; i++) {
len += STRLENOF("(") +
c->attrs[i]->ad_cname.bv_len +
STRLENOF("=") +
bv->bv_len +
escaped.bv_len +
STRLENOF(")");
}
@ -719,7 +721,7 @@ constraint_violation( constraint *c, struct berval *bv, Operation *op )
*ptr++ = '(';
ptr = lutil_strcopy( ptr, c->attrs[i]->ad_cname.bv_val );
*ptr++ = '=';
ptr = lutil_strcopy( ptr, bv->bv_val );
ptr = lutil_strcopy( ptr, escaped.bv_val );
*ptr++ = ')';
}
*ptr++ = ')';
@ -748,6 +750,7 @@ constraint_violation( constraint *c, struct berval *bv, Operation *op )
rc, found );
}
op->o_tmpfree(filterstr.bv_val, op->o_tmpmemctx);
op->o_tmpfree(escaped.bv_val, op->o_tmpmemctx);
if ((rc != LDAP_SUCCESS) && (rc != LDAP_NO_SUCH_OBJECT)) {
return rc; /* unexpected error */

1
tests/data/constraint/constraint.out
View file

@ -29,6 +29,7 @@ FAIL
FAIL
FAIL
FAIL
FAIL
OK
FAIL
FAIL

5
tests/data/constraint/t_fail_17.ldif Normal file
View file

@ -0,0 +1,5 @@
dn: cn=John Doe,ou=users,dc=example,dc=com
changetype: modify
replace: uid
uid: 2*