From ea836279294b356b74a0ccb0aed26562a338c15b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Kuzn=C3=ADk?= Date: Wed, 13 Dec 2017 12:17:23 +0000 Subject: [PATCH] request_abandon RFC4511 conformance --- servers/lloadd/client.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/servers/lloadd/client.c b/servers/lloadd/client.c index fb91cde901..43dcfed822 100644 --- a/servers/lloadd/client.c +++ b/servers/lloadd/client.c @@ -39,10 +39,8 @@ request_abandon( Connection *c, Operation *op ) "connid=%lu msgid=%d invalid integer sent in abandon request\n", c->c_connid, op->o_client_msgid ); - if ( operation_send_reject_locked( op, LDAP_PROTOCOL_ERROR, - "invalid PDU received", 0 ) == LDAP_SUCCESS ) { - CONNECTION_DESTROY(c); - } + operation_destroy_from_client( op ); + CONNECTION_DESTROY(c); return -1; } @@ -221,8 +219,8 @@ handle_one_request( Connection *c ) handler = request_bind; break; case LDAP_REQ_ABANDON: - /* FIXME: We need to be able to abandon a Bind request, handling - * ExOps (esp. Cancel) will be different */ + /* We can't send a response to abandon requests even if a bind is + * currently in progress */ handler = request_abandon; break; case LDAP_REQ_EXTENDED: