upstream/openldap
1
0
Fork 0
mirror of https://git.openldap.org/openldap/openldap.git synced 2025-12-25 00:59:45 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

ITS#5100 ldap_control_dup - OID must be non-NULL

Browse source
This commit is contained in:
Howard Chu 2007-10-09 01:38:50 +00:00
parent a79bc9195d
commit cbb6f3bd50
1 changed files with 5 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
libraries/libldap/controls.c
View file

@ -337,7 +337,7 @@ ldap_control_dup( const LDAPControl *c )
{
LDAPControl *new;
if ( c == NULL ) {
if ( c == NULL || c->ldctl_oid == NULL ) {
return NULL;
}
@ -347,17 +347,11 @@ ldap_control_dup( const LDAPControl *c )
return NULL;
}
if( c->ldctl_oid != NULL ) {
new->ldctl_oid = LDAP_STRDUP( c->ldctl_oid );
new->ldctl_oid = LDAP_STRDUP( c->ldctl_oid );
if(new->ldctl_oid == NULL) {
LDAP_FREE( new );
return NULL;
}
} else {
/* FIXME: how can a control have null OID? */
new->ldctl_oid = NULL;
if(new->ldctl_oid == NULL) {
LDAP_FREE( new );
return NULL;
}
if( c->ldctl_value.bv_val != NULL ) {