upstream/openldap
1
0
Fork 0
mirror of https://git.openldap.org/openldap/openldap.git synced 2025-12-21 15:19:34 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Plug unlikely memleak (coverity)

Browse source
This commit is contained in:
Howard Chu 2015-01-13 20:56:23 +00:00
parent 7d483f7aba
commit 9e69e0b559
1 changed files with 17 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
libraries/librewrite/subst.c
View file

@ -194,7 +194,6 @@ rewrite_subst_compile(
subs[ nsub ].bv_len = l; subs[ nsub ].bv_len = l;
subs[ nsub ].bv_val = malloc( l + 1 ); subs[ nsub ].bv_val = malloc( l + 1 );
if ( subs[ nsub ].bv_val == NULL ) { if ( subs[ nsub ].bv_val == NULL ) {
free( subs );
goto cleanup; goto cleanup;
} }
AC_MEMCPY( subs[ nsub ].bv_val, begin, l ); AC_MEMCPY( subs[ nsub ].bv_val, begin, l );
@ -213,8 +212,22 @@ rewrite_subst_compile(
s->lt_subs = subs; s->lt_subs = subs;
s->lt_num_submatch = nsub; s->lt_num_submatch = nsub;
s->lt_submatch = submatch; s->lt_submatch = submatch;
subs = NULL;
submatch = NULL;
cleanup:; cleanup:;
if ( subs ) {
for ( l=0; l<nsub; l++ ) {
free( subs[nsub].bv_val );
}
free( subs );
}
if ( submatch ) {
for ( l=0; l<nsub; l++ ) {
free( submatch[nsub].ls_map );
}
free( submatch );
}
free( result ); free( result );
return s; return s;