From 76df74dbeab47195e42946a474c3a5f8557c168d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Kuzn=C3=ADk?= Date: Fri, 15 Feb 2019 16:50:54 +0000 Subject: [PATCH] ITS#8731 Apply doc/devel/variadic_debug/07-shortcut.cocci --- servers/slapd/aclparse.c | 177 ++++++++------------- servers/slapd/back-asyncmeta/bind.c | 99 ++++-------- servers/slapd/back-asyncmeta/candidates.c | 8 +- servers/slapd/back-asyncmeta/conn.c | 43 ++--- servers/slapd/back-asyncmeta/init.c | 9 +- servers/slapd/back-asyncmeta/meta_result.c | 20 +-- servers/slapd/back-bdb/dn2id.c | 9 +- servers/slapd/back-ldap/bind.c | 28 +--- servers/slapd/back-ldif/ldif.c | 9 +- servers/slapd/back-meta/bind.c | 57 +++---- servers/slapd/back-meta/candidates.c | 8 +- servers/slapd/back-meta/conn.c | 43 ++--- servers/slapd/back-meta/init.c | 9 +- servers/slapd/back-meta/search.c | 94 +++++------ servers/slapd/back-monitor/init.c | 66 +++----- servers/slapd/back-sql/add.c | 27 ++-- servers/slapd/back-sql/config.c | 40 ++--- servers/slapd/back-sql/entry-id.c | 45 ++---- servers/slapd/back-sql/schema-map.c | 62 ++------ servers/slapd/back-wt/init.c | 10 +- servers/slapd/daemon.c | 20 +-- servers/slapd/overlays/memberof.c | 20 +-- servers/slapd/overlays/rwmconf.c | 20 +-- servers/slapd/schema_check.c | 116 +++++--------- servers/slapd/slapadd.c | 17 +- servers/slapd/syncrepl.c | 15 +- 26 files changed, 372 insertions(+), 699 deletions(-) diff --git a/servers/slapd/aclparse.c b/servers/slapd/aclparse.c index 2b6928c47c..2b65b6444c 100644 --- a/servers/slapd/aclparse.c +++ b/servers/slapd/aclparse.c @@ -168,12 +168,9 @@ regtest(const char *fname, int lineno, char *pat) { regerror(e, &re, error, sizeof(error)); - snprintf( buf, sizeof( buf ), - "regular expression \"%s\" bad because of %s", - pat, error ); - Debug( LDAP_DEBUG_ANY, - "%s: line %d: %s\n", - fname, lineno, buf ); + Debug(LDAP_DEBUG_ANY, + "%s: line %d: regular expression \"%s\" bad because of %s\n", + fname, lineno, pat, error ); acl_usage(); exit( EXIT_FAILURE ); } @@ -515,16 +512,11 @@ parse_acl( if( !mr_usable_with_at( a->acl_attrval_mr, a->acl_attrs[ 0 ].an_desc->ad_type ) ) { - char buf[ SLAP_TEXT_BUFLEN ]; - - snprintf( buf, sizeof( buf ), - "matching rule \"%s\" use " - "with attr \"%s\" not appropriate.", - mr, a->acl_attrs[ 0 ].an_name.bv_val ); - - - Debug( LDAP_DEBUG_ANY, "%s: line %d: %s\n", - fname, lineno, buf ); + Debug(LDAP_DEBUG_ANY, + "%s: line %d: matching rule \"%s\" use " "with attr \"%s\" not appropriate.\n", + fname, lineno, + mr, + a->acl_attrs[0].an_name.bv_val ); goto fail; } } @@ -539,12 +531,12 @@ parse_acl( regerror( e, &a->acl_attrval_re, err, sizeof( err ) ); - snprintf( buf, sizeof( buf ), - "regular expression \"%s\" bad because of %s", - right, err ); - - Debug( LDAP_DEBUG_ANY, "%s: line %d: %s\n", - fname, lineno, buf ); + Debug(LDAP_DEBUG_ANY, + "%s: line %d: regular expression \"%s\" bad because of %s\n", + fname, + lineno, + right, + err ); goto fail; } a->acl_attrval_style = ACL_STYLE_REGEX; @@ -574,45 +566,34 @@ parse_acl( } else if ( !strcasecmp( style, "children" ) ) { a->acl_attrval_style = ACL_STYLE_CHILDREN; } else { - char buf[ SLAP_TEXT_BUFLEN ]; - - snprintf( buf, sizeof( buf ), - "unknown val.