From 3add82a3bb30b94afd23ff5e2c00c59ca8a931d8 Mon Sep 17 00:00:00 2001 From: Quanah Gibson-Mount Date: Tue, 18 Dec 2018 18:45:20 +0000 Subject: [PATCH] ITS#8286 -- Add matching rules for attributes Add matching rules for all cases where it was missing. Cleanup incorrect types for a few attributes as well. Fix network-timeout handling in back-ldap/meta/asyncmeta. --- contrib/slapd-modules/adremap/adremap.c | 2 + contrib/slapd-modules/autogroup/autogroup.c | 1 + contrib/slapd-modules/lastbind/lastbind.c | 2 + contrib/slapd-modules/smbk5pwd/smbk5pwd.c | 3 + doc/man/man5/slapo-dds.5 | 10 ++-- servers/slapd/back-asyncmeta/config.c | 39 ++++++++++-- servers/slapd/back-bdb/config.c | 16 +++++ servers/slapd/back-ldap/config.c | 29 ++++++++- servers/slapd/back-mdb/config.c | 11 +++- servers/slapd/back-meta/config.c | 38 ++++++++++-- servers/slapd/back-perl/config.c | 1 + servers/slapd/back-sql/config.c | 31 ++++++++++ servers/slapd/bconfig.c | 66 ++++++++++++++++++++- servers/slapd/overlays/accesslog.c | 4 ++ servers/slapd/overlays/auditlog.c | 1 + servers/slapd/overlays/autoca.c | 9 +++ servers/slapd/overlays/dds.c | 7 +++ servers/slapd/overlays/dyngroup.c | 1 + servers/slapd/overlays/memberof.c | 7 +++ servers/slapd/overlays/pcache.c | 6 ++ servers/slapd/overlays/ppolicy.c | 4 ++ servers/slapd/overlays/refint.c | 2 + servers/slapd/overlays/retcode.c | 3 + servers/slapd/overlays/rwm.c | 3 + servers/slapd/overlays/sssvlv.c | 3 + servers/slapd/overlays/syncprov.c | 4 ++ servers/slapd/overlays/translucent.c | 6 ++ 27 files changed, 288 insertions(+), 21 deletions(-) diff --git a/contrib/slapd-modules/adremap/adremap.c b/contrib/slapd-modules/adremap/adremap.c index c21878185b..e5c64e80dc 100644 --- a/contrib/slapd-modules/adremap/adremap.c +++ b/contrib/slapd-modules/adremap/adremap.c @@ -72,6 +72,7 @@ static ConfigTable adremapcfg[] = { "( OLcfgCtAt:6.1 " "NAME 'olcADremapDowncase' " "DESC 'List of attributes to casefold to lower case' " + "EQUALITY caseIgnoreMatch " "SYNTAX OMsDirectoryString )", NULL, NULL }, { "adremap-dnmap", "dnattr targetattr newattr remoteOC localOC targetOC baseDN", 8, 8, 0, ARG_MAGIC|ADREMAP_DNV, adremap_cf_dnv, @@ -79,6 +80,7 @@ static ConfigTable adremapcfg[] = { "NAME 'olcADremapDNmap' " "DESC 'DN attr to map, attr from target to use, attr to generate, objectclass of remote" " group, objectclass mapped group, objectclass of target entry, base DN of target entry' " + "EQUALITY caseIgnoreMatch " "SYNTAX OMsDirectoryString )", NULL, NULL }, { NULL, NULL, 0, 0, 0, ARG_IGNORED } }; diff --git a/contrib/slapd-modules/autogroup/autogroup.c b/contrib/slapd-modules/autogroup/autogroup.c index 57100b144a..01050edfab 100644 --- a/contrib/slapd-modules/autogroup/autogroup.c +++ b/contrib/slapd-modules/autogroup/autogroup.c @@ -1724,6 +1724,7 @@ static ConfigTable agcfg[] = { 2, 2, 0, ARG_MAGIC|AG_MEMBER_OF_AD, ag_cfgen, "( OLcfgCtAt:2.2 NAME 'olcAGmemberOfAd' " "DESC 'memberOf attribute' " + "EQUALITY caseIgnoreMatch " "SYNTAX OMsDirectoryString SINGLE-VALUE )", NULL, NULL }, diff --git a/contrib/slapd-modules/lastbind/lastbind.c b/contrib/slapd-modules/lastbind/lastbind.c index 311be04f77..43d619e90a 100644 --- a/contrib/slapd-modules/lastbind/lastbind.c +++ b/contrib/slapd-modules/lastbind/lastbind.c @@ -74,12 +74,14 @@ static ConfigTable lastbindcfg[] = { "( OLcfgCtAt:5.1 " "NAME 'olcLastBindPrecision' " "DESC 'Precision of authTimestamp attribute' " + "EQUALITY integerMatch " "SYNTAX OMsInteger SINGLE-VALUE )", NULL, NULL }, { "lastbind_forward_updates", "on|off", 1, 2, 0, ARG_ON_OFF|ARG_OFFSET, (void *)offsetof(lastbind_info,forward_updates), "( OLcfgAt:5.2 NAME 'olcLastBindForwardUpdates' " "DESC 'Allow authTimestamp updates to be forwarded via updateref' " + "EQUALITY booleanMatch " "SYNTAX OMsBoolean SINGLE-VALUE )", NULL, NULL }, { NULL, NULL, 0, 0, 0, ARG_IGNORED } }; diff --git a/contrib/slapd-modules/smbk5pwd/smbk5pwd.c b/contrib/slapd-modules/smbk5pwd/smbk5pwd.c index 0dda119c65..deadf11282 100644 --- a/contrib/slapd-modules/smbk5pwd/smbk5pwd.c +++ b/contrib/slapd-modules/smbk5pwd/smbk5pwd.c @@ -719,16 +719,19 @@ static ConfigTable smbk5pwd_cfats[] = { 2, 0, 0, ARG_MAGIC|PC_SMB_ENABLE, smbk5pwd_cf_func, "( OLcfgCtAt:1.1 NAME 'olcSmbK5PwdEnable' " "DESC 'Modules to be enabled' " + "EQUALITY caseIgnoreMatch " "SYNTAX OMsDirectoryString )", NULL, NULL }, { "smbk5pwd-must-change", "time", 2, 2, 0, ARG_MAGIC|ARG_INT|PC_SMB_MUST_CHANGE, smbk5pwd_cf_func, "( OLcfgCtAt:1.2 NAME 'olcSmbK5PwdMustChange' " "DESC 'Credentials validity interval' " + "EQUALITY integerMatch " "SYNTAX OMsInteger SINGLE-VALUE )", NULL, NULL }, { "smbk5pwd-can-change", "time", 2, 2, 0, ARG_MAGIC|ARG_INT|PC_SMB_CAN_CHANGE, smbk5pwd_cf_func, "( OLcfgCtAt:1.3 NAME 'olcSmbK5PwdCanChange' " "DESC 'Credentials minimum validity interval' " + "EQUALITY integerMatch " "SYNTAX OMsInteger SINGLE-VALUE )", NULL, NULL }, { NULL, NULL, 0, 0, 0, ARG_IGNORED } diff --git a/doc/man/man5/slapo-dds.5 b/doc/man/man5/slapo-dds.5 index 7c29db2f45..b80b9e69ac 100644 --- a/doc/man/man5/slapo-dds.5 +++ b/doc/man/man5/slapo-dds.5 @@ -79,7 +79,7 @@ to avoid potential conflicts with directives specific to the underlying database or to other stacked overlays. .TP -.B dds\-max\-ttl +.B dds\-max\-ttl