mirror of
https://github.com/nginx/nginx.git
synced 2026-02-18 18:17:52 -05:00
Upstream: detect premature plain text response from SSL backend.
When connecting to a backend, the connection write event is triggered first in most cases. However if a response arrives quickly enough, both read and write events can be triggered together within the same event loop iteration. In this case the read event handler is called first and the write event handler is called after it. SSL initialization for backend connections happens only in the write event handler since SSL handshake starts with sending Client Hello. Previously, if a backend sent a quick plain text response, it could be parsed by the read event handler prior to starting SSL handshake on the connection. The change adds protection against parsing such responses on SSL-enabled connections.
This commit is contained in:
parent
86e5930e76
commit
a59f5f099a
1 changed files with 9 additions and 0 deletions
|
|
@ -2528,6 +2528,15 @@ ngx_http_upstream_process_header(ngx_http_request_t *r, ngx_http_upstream_t *u)
|
|||
return;
|
||||
}
|
||||
|
||||
#if (NGX_HTTP_SSL)
|
||||
if (u->ssl && c->ssl == NULL) {
|
||||
ngx_log_error(NGX_LOG_ERR, c->log, 0,
|
||||
"upstream prematurely sent response");
|
||||
ngx_http_upstream_next(r, u, NGX_HTTP_UPSTREAM_FT_ERROR);
|
||||
return;
|
||||
}
|
||||
#endif
|
||||
|
||||
u->state->bytes_received += n;
|
||||
|
||||
u->buffer.last += n;
|
||||
|
|
|
|||
Loading…
Reference in a new issue