upstream/nginx
1
0
Fork 0
mirror of https://github.com/nginx/nginx.git synced 2026-04-15 22:09:26 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Tests: RFC 5424 syslog MSGID parameter.

Browse source 
Config tests (syslog_rfc5424_config.t):
- msgid= accepted with rfc=rfc5424
- msgid= rejected when rfc=rfc5424 is not set
- msgid= with a non-ASCII byte (>0x7E) rejected
- msgid= exceeding 32 characters rejected
- 32-character msgid= accepted

Format tests (syslog_rfc5424.t):
- Explicit msgid=MYAPP appears in the MSGID field (position 6 of the
  RFC 5424 HEADER) of the emitted syslog message.
- Without msgid=, the MSGID field defaults to the nil value "-".
This commit is contained in:
Vadim Zhestikov 2026-03-25 10:57:43 -07:00
parent e25bdbc350
commit 8f6f7b287c
2 changed files with 48 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
t/syslog_rfc5424.t
View file

@ -26,7 +26,7 @@ select STDOUT; $| = 1;
plan(skip_all => 'win32') if $^O eq 'MSWin32';
my $t = Test::Nginx->new()->has(qw/http/)->plan(21);
my $t = Test::Nginx->new()->has(qw/http/)->plan(23);
###############################################################################
@ -69,6 +69,12 @@ http {
syslog:server=127.0.0.1:%%PORT_8982_UDP%%,rfc=rfc5424,tag=my-app,facility=user;
}
# RFC 5424 access log with explicit msgid=
location /a5424_msgid {
access_log syslog:server=127.0.0.1:%%PORT_8982_UDP%%,rfc=rfc5424,msgid=MYAPP
logf;
}
# RFC 3164 access log — verify backward compatibility
location /a3164 {
access_log syslog:server=127.0.0.1:%%PORT_8983_UDP%% logf;
@ -128,6 +134,18 @@ my ($pri) = $msg =~ /^<(\d+)>/;
my $fac = ($pri & 0x03f8) >> 3;
is($fac, 1, 'rfc5424: facility=user (1) encoded in PRI');
# RFC 5424 MSGID field: explicit msgid= value appears in position 6 of the header
$msg = get_syslog($s5424, '/a5424_msgid');
my ($msgid_field) = $msg =~ /^<\d+>1\s\S+\s\S+\s\S+\s\d+\s(\S+)\s/;
is($msgid_field, 'MYAPP', 'rfc5424: explicit msgid= appears in MSGID field');
# Without msgid=, the MSGID field defaults to nil "-"
$msg = get_syslog($s5424, '/a5424');
($msgid_field) = $msg =~ /^<\d+>1\s\S+\s\S+\s\S+\s\d+\s(\S+)\s/;
is($msgid_field, '-', 'rfc5424: default MSGID is nil "-"');
# Global error_log uses rfc5424 — check via background-daemon log file
http_get('/a5424');

29
t/syslog_rfc5424_config.t
View file

@ -105,6 +105,35 @@ like($out, qr/tag length exceeds 48/, 'rfc5424: 49-char tag rejected');
$out = config_check("syslog:server=127.0.0.1:5140,rfc=rfc3164,tag=$tag49");
like($out, qr/tag length exceeds 48/, 'rfc3164: 49-char tag rejected');
# msgid= is accepted with rfc=rfc5424.
$out = config_check('syslog:server=127.0.0.1:5140,rfc=rfc5424,msgid=MYAPP');
like($out, qr/test is successful/i, 'rfc5424: msgid= accepted');
# msgid= without rfc=rfc5424 must be rejected.
$out = config_check('syslog:server=127.0.0.1:5140,msgid=MYAPP');
like($out, qr/requires rfc=rfc5424/, 'msgid= without rfc5424 rejected');
# msgid= with a non-ASCII byte (>0x7E) must be rejected.
# Space cannot be tested this way because nginx's config parser splits on
# whitespace before syslog parsing sees the value.
$out = config_check("syslog:server=127.0.0.1:5140,rfc=rfc5424,msgid=MY\xc3APP");
like($out, qr/printable US-ASCII/, 'msgid= with non-ASCII byte rejected');
# msgid= must not exceed 32 characters.
my $msgid33 = 'x' x 33;
$out = config_check("syslog:server=127.0.0.1:5140,rfc=rfc5424,msgid=$msgid33");
like($out, qr/msgid length exceeds 32/, 'msgid= 33-char rejected');
# A 32-character msgid is within the limit and must be accepted.
my $msgid32 = 'x' x 32;
$out = config_check("syslog:server=127.0.0.1:5140,rfc=rfc5424,msgid=$msgid32");
like($out, qr/test is successful/i, 'msgid= 32-char accepted');
done_testing;
###############################################################################