mirror of
https://github.com/nextcloud/server.git
synced 2026-02-20 00:12:30 -05:00
e2453d78c0
Despite it's PHPDoc the function might return `null` which was not properly catched and thus in some situations the share was resolved to the sharing users root directory. To test this perform the following steps: * Share file in owncloud 7 (7.0.4.2) * Delete the parent folder of the shared file * The share stays is in the DB and the share via the sharelink is inaccessible. (which is good) * Upgrade to owncloud 8 (8.0.2) (This step is crucial. The bug is not reproduceable without upgrading from 7 to 8. It seems like the old tokens are handled different than the newer ones) * Optional Step: Logout, Reset Browser Session, etc. * Access the share via the old share url: almost empty page, but there is a dowload button which adds a "/download" to the URL. * Upon clicking, a download.zip is downloaded which contains EVERYTHING from the owncloud directory (of the user who shared the file) * No exception is thrown and no error is logged. This will add a check whether the share is a valid one and also adds unit tests to prevent further regressions in the future. Needs to be backported to ownCloud 8. Adding a proper clean-up of the orphaned shares is out-of-scope and would probably require some kind of FK or so. Fixes https://github.com/owncloud/core/issues/15097
101 lines
2.8 KiB
PHP
101 lines
2.8 KiB
PHP
<?php
|
|
/**
|
|
* @author Lukas Reschke
|
|
* @copyright 2014 Lukas Reschke lukas@owncloud.com
|
|
*
|
|
* This file is licensed under the Affero General Public License version 3 or
|
|
* later.
|
|
* See the COPYING-README file.
|
|
*/
|
|
|
|
namespace OCA\Files_Sharing;
|
|
|
|
use OC\AppFramework\Utility\SimpleContainer;
|
|
use OCA\Files_Sharing\Controllers\ExternalSharesController;
|
|
use OCA\Files_Sharing\Controllers\ShareController;
|
|
use OCA\Files_Sharing\Middleware\SharingCheckMiddleware;
|
|
use \OCP\AppFramework\App;
|
|
|
|
/**
|
|
* @package OCA\Files_Sharing
|
|
*/
|
|
class Application extends App {
|
|
|
|
|
|
/**
|
|
* @param array $urlParams
|
|
*/
|
|
public function __construct(array $urlParams=array()){
|
|
parent::__construct('files_sharing', $urlParams);
|
|
|
|
$container = $this->getContainer();
|
|
$server = $container->getServer();
|
|
|
|
/**
|
|
* Controllers
|
|
*/
|
|
$container->registerService('ShareController', function(SimpleContainer $c) use ($server) {
|
|
return new ShareController(
|
|
$c->query('AppName'),
|
|
$c->query('Request'),
|
|
$c->query('UserSession'),
|
|
$server->getAppConfig(),
|
|
$server->getConfig(),
|
|
$c->query('URLGenerator'),
|
|
$c->query('UserManager'),
|
|
$server->getLogger(),
|
|
$server->getActivityManager()
|
|
);
|
|
});
|
|
$container->registerService('ExternalSharesController', function(SimpleContainer $c) {
|
|
return new ExternalSharesController(
|
|
$c->query('AppName'),
|
|
$c->query('Request'),
|
|
$c->query('IsIncomingShareEnabled'),
|
|
$c->query('ExternalManager')
|
|
);
|
|
});
|
|
|
|
/**
|
|
* Core class wrappers
|
|
*/
|
|
$container->registerService('UserSession', function(SimpleContainer $c) use ($server) {
|
|
return $server->getUserSession();
|
|
});
|
|
$container->registerService('URLGenerator', function(SimpleContainer $c) use ($server){
|
|
return $server->getUrlGenerator();
|
|
});
|
|
$container->registerService('UserManager', function(SimpleContainer $c) use ($server){
|
|
return $server->getUserManager();
|
|
});
|
|
$container->registerService('IsIncomingShareEnabled', function(SimpleContainer $c) {
|
|
return Helper::isIncomingServer2serverShareEnabled();
|
|
});
|
|
$container->registerService('ExternalManager', function(SimpleContainer $c) use ($server){
|
|
$user = $server->getUserSession()->getUser();
|
|
$uid = $user ? $user->getUID() : null;
|
|
return new \OCA\Files_Sharing\External\Manager(
|
|
$server->getDatabaseConnection(),
|
|
\OC\Files\Filesystem::getMountManager(),
|
|
\OC\Files\Filesystem::getLoader(),
|
|
$server->getHTTPHelper(),
|
|
$uid
|
|
);
|
|
});
|
|
|
|
/**
|
|
* Middleware
|
|
*/
|
|
$container->registerService('SharingCheckMiddleware', function(SimpleContainer $c) use ($server){
|
|
return new SharingCheckMiddleware(
|
|
$c->query('AppName'),
|
|
$server->getConfig(),
|
|
$server->getAppManager()
|
|
);
|
|
});
|
|
|
|
// Execute middlewares
|
|
$container->registerMiddleware('SharingCheckMiddleware');
|
|
}
|
|
|
|
}
|