Cloud personnel
Find a file
Daniel Calviño Sánchez 1466586033 Fix ids of permission checkboxes for shares
The ids of permission checkboxes for shares were generated using the
"shareWith" field of the share. The "shareWith" field can contain spaces
(as spaces are allowed, for example, in user or circle names), so this
could cause the id attribute of the HTML element to contain spaces too,
which is forbidden by the HTML specification.

It is not just a "formal" issue, though; when the list was rendered, if
the id contained a space the selector to get the checkbox element was
wrong (as it ended being something like
"#canEdit-view1-name with spaces") and thus the initial state of the
checkbox was not properly set.

Besides that, "shareWith" can contain too single quotes, which would
even cause the jQuery selector to abort the search and leave the UI in
an invalid state.

Instead of adding more cases to the regular expression to escape special
characters and apply it too when the ids are created now the ids of
permission checkboxes for shares are based on the "shareId" field
instead of on "shareWith", as "shareId" is expected to always contain
compatible characters.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-04-18 15:25:23 +02:00
.github Move mention-bot notifications to code owners 2017-07-07 08:44:01 +02:00
.idea Add newline that was removed by 15be763d46 2014-12-10 09:38:32 +01:00
.tx Remove old perl script to update l10n files 2018-02-08 18:21:14 +01:00
3rdparty@d4e8f89af1 Silence phan 2018-04-06 13:46:32 +02:00
apps log more information about insufficient storage in dav plugin 2018-04-17 15:29:37 +02:00
build Merge pull request #9203 from nextcloud/declare-func-as-safe 2018-04-17 13:45:27 +02:00
config Provide an option to disable HTML emails 2018-04-16 19:00:05 +02:00
contribute Add Developer Certificate of Origin (DCO) 2016-09-22 09:08:21 +02:00
core Fix ids of permission checkboxes for shares 2018-04-18 15:25:23 +02:00
lib Merge pull request #9217 from nextcloud/show-link-trusted-domains 2018-04-17 21:21:37 +02:00
ocs Warn about the old OCP\API::register construct for OCS 2018-01-17 15:18:22 +01:00
ocs-provider Allow to call the files even when you are in another instance atm 2016-10-06 12:15:13 +02:00
resources Update CRL to include old quicknotes cert 2018-04-17 11:40:56 +02:00
settings Merge pull request #9218 from nextcloud/personal-settings 2018-04-18 10:14:25 +02:00
tests Show a link to the docs instead of a button on the untrusted domain page 2018-04-17 17:47:11 +02:00
themes Use customclient_* values by default and do not use them in custom themes anymore 2018-03-26 19:26:36 +02:00
.bowerrc ability to add bower resources 2014-11-03 20:54:40 +01:00
.codecov.yml Improve codecov config to recognize drone 2018-01-16 18:56:05 +01:00
.drone.yml Merge pull request #9145 from nextcloud/use-authorized-github-checks 2018-04-11 16:27:13 +02:00
.gitignore Fix some typos 2018-03-21 14:30:56 +01:00
.gitmodules targets 3rdparty submodule from Nc instead of oC 2016-06-28 18:39:51 +02:00
.htaccess Merge pull request #7419 from Abijeet/feature-7175 2018-03-06 21:53:37 +01:00
.jshintrc Reduce JSHint errors/warnings 2017-11-06 09:57:59 +01:00
.lgtm Get rid of LGTM self approvals 2016-06-27 23:18:01 +02:00
.mailmap Run updated license header updater 2017-11-07 13:47:42 +01:00
.scrutinizer.yml Exclude phan from scrutinizer 2017-07-19 10:28:11 +02:00
.tag Add .tag file to make tar balls tracable 2014-06-14 17:40:32 +02:00
.user.ini Make sure memory limit is > post size and upload filesize 2016-09-13 16:50:36 +02:00
AUTHORS Run updated license header updater 2017-11-07 13:47:42 +01:00
autotest-checkers.sh Add test to check if new files are added to the root of the repository 2017-07-12 11:52:42 +02:00
autotest-external.sh Set exit code to 1 if integration test is failing 2016-12-20 23:40:49 +01:00
autotest-hhvm.sh Combine autotest-hhvm.sh with autotest.sh 2015-05-04 16:37:23 +02:00
autotest-js.sh Fix sass compile tests 2017-03-20 14:12:45 +01:00
autotest.sh Use phpunit's directory feature 2018-02-20 17:40:09 +01:00
bower.json Sort dependencies in bower.json alphabetically 2018-02-05 01:57:40 +01:00
buildjsdocs.sh Added OC.Files.Client Webdav-based files client 2015-11-22 16:05:49 +01:00
CHANGELOG.md Add link to real changelog 2017-07-19 10:39:55 +02:00
CODE_OF_CONDUCT.md Create CODE_OF_CONDUCT.md 2018-01-10 09:32:58 +01:00
composer.json Install phan manually 2017-07-19 10:28:12 +02:00
console.php Nextcloud 13 is not compatible with newer than php 7.2 2017-12-12 10:55:09 +01:00
CONTRIBUTING.md Update link to Nextcloud 13 Developer Manual 2018-04-04 23:40:26 +09:00
COPYING Rename COPYING-AGPL to COPYING 2016-09-13 22:51:02 +02:00
COPYING-README Rename COPYING-AGPL to COPYING 2016-09-13 22:51:02 +02:00
cron.php Deprecated OCP interface to fetch background job type 2018-01-26 10:43:01 +01:00
index.html Try to prefer index.php over index.html in the same directory 2013-04-24 15:11:53 +02:00
index.php Nextcloud 13 is not compatible with newer than php 7.2 2017-12-12 10:55:09 +01:00
issue_template.md Note about enterprise users 2018-01-02 14:44:19 +01:00
occ Use a more universal shebang 2014-11-19 17:34:03 +01:00
public.php Nextcloud 13 is not compatible with newer than php 7.2 2017-12-12 10:55:09 +01:00
README.md Update README.md 2017-11-29 09:09:11 +01:00
remote.php Nextcloud 13 is not compatible with newer than php 7.2 2017-12-12 10:55:09 +01:00
robots.txt Add robot.txt 2013-01-28 16:39:53 -06:00
status.php Nextcloud 13 is not compatible with newer than php 7.2 2017-12-12 10:55:09 +01:00
version.php Add an uid_lower column to the oc_users table 2018-04-06 13:42:50 +02:00

Nextcloud Server

Scrutinizer Code Quality codecov CII Best Practices irc irc

A safe home for all your data.

Why is this so awesome?

  • 📁 Access your Data You can store your files, contacts, calendars and more on a server of your choosing.
  • 📦 Sync your Data You keep your files, contacts, calendars and more synchronized amongst your devices.
  • 🔄 Share your Data …by giving others access to the stuff you want them to see or to collaborate with.
  • 🚀 Expandable with dozens of Apps ...like Calendar, Contacts, Mail and all those you can discover in our App Store
  • 🔒 Security with our encryption mechanisms, HackerOne bounty program and two-factor authentication.

You want to learn more about how you can use Nextcloud to access, share and protect your files, calendars, contacts, communication & more at home and at your Enterprise? Learn about all our Features.

Get your Nextcloud

Enterprise? Public Sector or Education user? You may want to have a look into the Enterprise Support Subscription provided by the Nextcloud GmbH

Get in touch

…learn more about how to get support for Nextcloud here!

Contribution Guidelines

All contributions to this repository from June, 16 2016 on are considered to be licensed under the AGPLv3 or any later version.

Nextcloud doesn't require a CLA (Contributor License Agreement). The copyright belongs to all the individual contributors. Therefore we recommend that every contributor adds following line to the header of a file, if they changed it substantially:

@copyright Copyright (c) <year>, <your name> (<your email address>)

Please read the Code of Conduct. This document offers some guidance to ensure Nextcloud participants can cooperate effectively in a positive and inspiring atmosphere, and to explain how together we can strengthen and support each other.

Please review the guidelines for contributing to this repository.

More information how to contribute: https://nextcloud.com/contribute/

Running master checkouts

Third-party components are handled as git submodules which have to be initialized first. So aside from the regular git checkout invoking git submodule update --init or a similar command is needed, for details see Git documentation.

Several apps that are included by default in regular releases such as firstrunwizard or gallery are missing in master and have to be installed manually.

That aside Git checkouts can be handled the same as release archives.

Note they should never be used on production systems.