mirror of
https://github.com/nextcloud/server.git
synced 2026-05-28 04:32:30 -04:00
638b2c20c6
PR #58224 introduced a raster→SVG conversion path in ImageManager::getImage() that breaks display of custom theming images. The root cause is a three-part bug chain: 1. getImage() attempted to convert raster images (PNG/JPEG) to SVG format, which Imagick cannot do meaningfully and produces broken output. 2. getMimeType() returns 'application/octet-stream' for extensionless stored files, so the Content-Type response header was wrong. 3. Stale .svg cache files persisted after image replacement, causing subsequent requests to serve the wrong format. Fix by: - Restricting the Imagick conversion to SVG→PNG only (not raster→SVG) - Reading the stored MIME type from IAppConfig for extensionless files in ThemingController::getImage() - Deleting .svg cache files in ImageManager::delete() - Injecting IAppConfig into ImageManager and reading the cachebuster via IAppConfig::getAppValueInt() so the URL returned after upload always carries the freshly-incremented value (IConfig::getAppValue() can return a stale cached value within the same request) - Updating the FileInputField Vue component to use a reactive cacheKey ref that increments on every upload, so the thumbnail refreshes even when the MIME type of the new image is the same as the old one - Updating unit tests for ImageManager and ThemingController - Updating psalm baseline for stable32 Backport of #60198 AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| Controller | ||
| data | ||
| Migration | ||
| Service | ||
| Settings | ||
| Themes | ||
| CapabilitiesTest.php | ||
| IconBuilderTest.php | ||
| ImageManagerTest.php | ||
| ServicesTest.php | ||
| ThemingDefaultsTest.php | ||
| UtilTest.php | ||