request = $this->createMock(IRequest::class); $this->clientMapper = $this->createMock(ClientMapper::class); $this->secureRandom = $this->createMock(ISecureRandom::class); $this->accessTokenMapper = $this->createMock(AccessTokenMapper::class); $this->authTokenProvider = $this->createMock(IAuthTokenProvider::class); $this->userManager = $this->createMock(IUserManager::class); $this->crypto = $this->createMock(ICrypto::class); $this->logger = $this->createMock(LoggerInterface::class); $this->l = $this->createMock(IL10N::class); $this->l->method('t') ->willReturnArgument(0); $this->settingsController = new SettingsController( 'oauth2', $this->request, $this->clientMapper, $this->secureRandom, $this->accessTokenMapper, $this->l, $this->authTokenProvider, $this->userManager, $this->crypto, $this->logger, ); } public function testAddClient(): void { $this->secureRandom ->expects($this->exactly(2)) ->method('generate') ->with(64, 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789') ->willReturnOnConsecutiveCalls( 'MySecret', 'MyClientIdentifier'); $this->crypto ->expects($this->once()) ->method('calculateHMAC') ->willReturn('MyHashedSecret'); $client = new Client(); $client->setName('My Client Name'); $client->setRedirectUri('https://example.com/'); $client->setSecret(bin2hex('MyHashedSecret')); $client->setClientIdentifier('MyClientIdentifier'); $this->clientMapper ->expects($this->once()) ->method('insert') ->with($this->callback(function (Client $c) { return $c->getName() === 'My Client Name' && $c->getRedirectUri() === 'https://example.com/' && $c->getSecret() === bin2hex('MyHashedSecret') && $c->getClientIdentifier() === 'MyClientIdentifier'; }))->willReturnCallback(function (Client $c) { $c->setId(42); return $c; }); $result = $this->settingsController->addClient('My Client Name', 'https://example.com/'); $this->assertInstanceOf(JSONResponse::class, $result); $data = $result->getData(); $this->assertEquals([ 'id' => 42, 'name' => 'My Client Name', 'redirectUri' => 'https://example.com/', 'clientId' => 'MyClientIdentifier', 'clientSecret' => 'MySecret', ], $data); } public function testDeleteClient(): void { $userManager = Server::get(IUserManager::class); // count other users in the db before adding our own $count = 0; $function = function (IUser $user) use (&$count): void { if ($user->getLastLogin() > 0) { $count++; } }; $userManager->callForAllUsers($function); $user1 = $userManager->createUser('test101', 'test101'); $user1->updateLastLoginTimestamp(); $tokenProviderMock = $this->getMockBuilder(IAuthTokenProvider::class)->getMock(); // One getTokenByUser call per user; we return no matching tokens here // so invalidateTokenById is never invoked. $tokenProviderMock ->expects($this->exactly($count + 1)) ->method('getTokenByUser') ->willReturn([]); $tokenProviderMock ->expects($this->never()) ->method('invalidateTokenById'); $client = new Client(); $client->setId(123); $client->setName('My Client Name'); $client->setRedirectUri('https://example.com/'); $client->setSecret(bin2hex('MyHashedSecret')); $client->setClientIdentifier('MyClientIdentifier'); $this->clientMapper ->method('getByUid') ->with(123) ->willReturn($client); $this->accessTokenMapper ->expects($this->once()) ->method('deleteByClientId') ->with(123); $this->clientMapper ->expects($this->once()) ->method('delete') ->with($client); $settingsController = new SettingsController( 'oauth2', $this->request, $this->clientMapper, $this->secureRandom, $this->accessTokenMapper, $this->l, $tokenProviderMock, $userManager, $this->crypto, $this->logger, ); $result = $settingsController->deleteClient(123); $this->assertInstanceOf(JSONResponse::class, $result); $this->assertEquals([], $result->getData()); $user1->delete(); } public function testDeleteClientPreservesWipePendingToken(): void { $userManager = Server::get(IUserManager::class); $user = $userManager->createUser('test_wipe_preserve', 'test_wipe_preserve'); $user->updateLastLoginTimestamp(); $client = new Client(); $client->setId(456); $client->setName('My Client Name'); $client->setRedirectUri('https://example.com/'); $client->setSecret(bin2hex('MyHashedSecret')); $client->setClientIdentifier('MyClientIdentifier'); // Token marked for wipe with a matching client name: must NOT be invalidated. $wipeToken = $this->createMock(IToken::class); $wipeToken->method('getId')->willReturn(11); $wipeToken->method('getName')->willReturn('My Client Name'); // Regular token with matching name: must be invalidated. $regularToken = $this->createMock(IToken::class); $regularToken->method('getId')->willReturn(12); $regularToken->method('getName')->willReturn('My Client Name'); // Non-matching name: must be left alone. $otherToken = $this->createMock(IToken::class); $otherToken->method('getId')->willReturn(13); $otherToken->method('getName')->willReturn('Some Other Client'); $tokenProviderMock = $this->getMockBuilder(IAuthTokenProvider::class)->getMock(); $tokenProviderMock ->method('getTokenByUser') ->willReturnCallback(function (string $uid) use ($wipeToken, $regularToken, $otherToken) { return $uid === 'test_wipe_preserve' ? [$wipeToken, $regularToken, $otherToken] : []; }); // Wipe state is signalled via WipeTokenException from getTokenById. $tokenProviderMock ->method('getTokenById') ->willReturnCallback(function (int $id) use ($wipeToken, $regularToken) { if ($id === 11) { throw new WipeTokenException($wipeToken); } return $regularToken; }); $tokenProviderMock ->expects($this->once()) ->method('invalidateTokenById') ->with('test_wipe_preserve', 12); $this->clientMapper ->method('getByUid') ->with(456) ->willReturn($client); $this->accessTokenMapper ->expects($this->once()) ->method('deleteByClientId') ->with(456); $this->clientMapper ->expects($this->once()) ->method('delete') ->with($client); $logger = $this->createMock(LoggerInterface::class); $logger->expects($this->atLeastOnce()) ->method('info') ->with($this->stringContains('Preserving token'), $this->callback(function (array $context) { return ($context['tokenId'] ?? null) === 11 && ($context['uid'] ?? null) === 'test_wipe_preserve'; })); $settingsController = new SettingsController( 'oauth2', $this->request, $this->clientMapper, $this->secureRandom, $this->accessTokenMapper, $this->l, $tokenProviderMock, $userManager, $this->crypto, $logger, ); $result = $settingsController->deleteClient(456); $this->assertInstanceOf(JSONResponse::class, $result); $this->assertEquals([], $result->getData()); $user->delete(); } public function testInvalidRedirectUri(): void { $result = $this->settingsController->addClient('test', 'invalidurl'); $this->assertEquals(Http::STATUS_BAD_REQUEST, $result->getStatus()); $this->assertSame(['message' => 'Your redirect URL needs to be a full URL for example: https://yourdomain.com/path'], $result->getData()); } }