Commit graph

178 commits

Author SHA1 Message Date
Ferdinand Thiessen
985764152f
fix(files): also show file list headers on empty views
It is needed, e.g. for the note-to-recipient, that the headers
are also shown when there is no content (yet).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-17 19:41:41 +01:00
Louis Chemineau
db9db0beec test: Remove .only( calls
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-03-06 11:12:14 +00:00
Louis Chemineau
6cbffb0b53
fix(test): Escape quotes in runOccCommand argument
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-03-05 15:04:44 +01:00
Louis Chemineau
2d839d767a
chore(tests): Fix using save/restore state in cypress
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-03-05 13:45:23 +01:00
Louis
acf19f7880
Revert "Revert "[stable30] fix: Handle copy of folders containing live photos""
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-03-05 13:45:23 +01:00
Ferdinand Thiessen
a4e9644410
test: fix cypress files trashbin tests
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-05 10:37:46 +01:00
Ferdinand Thiessen
bd280f759b
fix(files_trashbin): disable bulk download for trashbin
The backend does not allow bulk download within the trashbin,
so we need to disable this also on the frontend.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-03 17:36:18 +01:00
skjnldsv
2b844498da fix(cypress): selection key event trigger
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-21 14:17:52 +01:00
skjnldsv
e5c55bf562 fix(files): handle failed node properly
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-21 14:07:13 +01:00
skjnldsv
e601503000 fix(cypress): opendetails tests
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-21 09:55:23 +00:00
skjnldsv
0394037b80 fix(cypress): action selector menu lookup
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-21 09:54:04 +01:00
skjnldsv
05f3f2dbb7 chore(files_external): add cypress tests for user credentials action
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-21 09:54:03 +01:00
skjnldsv
145d3fd1a7 fix(files): properly show file not found error
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

[skip ci]
2025-02-19 10:13:55 +01:00
Ferdinand Thiessen
03e15b9297
fix(files): Do not download files with openfile query flag
Instead of downloading files, if there is no other default action,
we should just open the details tab.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-13 16:00:03 +01:00
Ferdinand Thiessen
e046ce6858
fix(settings): Also sanitize fediverse and twitter handle in the frontend
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-07 12:42:23 +01:00
nfebe
23e70a574e test(files_sharing): Check that default expiration date is shown b4 create share
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-02-06 22:14:16 +01:00
Ferdinand Thiessen
b5a3fc58fd
test(files): Make scrolling tests independent from magic values
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-06 00:09:23 +01:00
Ferdinand Thiessen
5251b25f4e
fix(files): Correctly scroll selected file into view
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-06 00:08:47 +01:00
Ferdinand Thiessen
8d6139f17c
fix(files): Ensure favorites set in sidebar work
When marking a file as favorite from within the sidebar make sure it
really works, this fixes two issues:
1. The source needs to be the plain source not URL encoded, as otherwise
   the source of the node would be encoded twice (and show with encoding
   in the navigation)
2. The store should also listen for the update events as the sidebar has
   no access to the real node to update it, instead the store should -
   as long as we only have the legacy sidebar - update the node when
   added or removed as favorite.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-04 21:14:40 +01:00
nfebe
e3b9135f1e test(files_sharing): add e2e tests for public link sharing
This commit introduces end-to-end tests for various public link sharing scenarios in the `files_sharing` app. It validates the behavior under multiple configurations:

- Password and expiration date enforced
- Password enforced with a default expiration date
- Expiration date enforced with optional password
- Default password and expiration date without enforcement
- Password enforced, expiration date set but not enforced
- Both password and expiration date not enforced, but defaults set
- Password not enforced, expiration date enforced
- Password not enforced, default expiration date set
- Password and expiration date not enforced with no defaults

The tests ensure proper validation and functionality of the configurations, leveraging the `setupData` and `createShare` utilities.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-02-03 17:21:22 +01:00
nfebe
b1c5637a87 feat: Add setup-public-share.ts
This addition enhances the testing framework for public sharing by
improving the setup and management of share contexts.

Additionally, the update optimizes share permission adjustments and
improves state management, making public share setups more efficient and maintainable.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-02-03 17:19:36 +01:00
Ferdinand Thiessen
910495de1f
fix(files): File type filter UI sync with filter state
When changing the folder the filter will be re-mounted by the file list,
so we need to pass the current state of the filter to the filter UI.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 20:25:55 +01:00
Ferdinand Thiessen
ab39152951 fix(theming): Ensure to only send valid URLs to backend
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-27 17:58:56 +00:00
Richard Steinmetz
3efb46ca56
fix(files): sort not working after changing views
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-01-26 14:09:13 +01:00
Maksim Sukharev
21f0e61477 test(e2e): hide move dialog action if destination has no CREATE permission
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
(cherry picked from commit 868517f6d2)
2025-01-17 14:55:15 +01:00
Ferdinand Thiessen
d787ae9da5
Merge pull request #49940 from nextcloud/backport/49208/stable30
[stable30] fix: Redirect user to login if session is terminated
2025-01-16 23:44:04 +01:00
Ferdinand Thiessen
d0dbe21f4c
test(dashboard): Add regression test for loading unneeded data
Prevent a regression of https://github.com/nextcloud/server/issues/48403

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-16 11:40:02 +01:00
Ferdinand Thiessen
21805299dc
test: Add end-to-end test for share expiration date
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-16 09:07:59 +01:00
Ferdinand Thiessen
f5f3ae2c19 fix: Redirect user to login if session is terminated
If a session timed out or was closed in another tab,
then currently the user gets random error messages.
This intercepts 401 responses (should only happen if logged out, or the
users does something wrong).

If we get a 401, we make sure its because of the session,
by checking if the user can access the files app.
If that is also the case we forward the user to the login page
and set the redirect URL to the last used URL.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-09 09:48:44 +01:00
skjnldsv
0d5cda8aa4 fix(files): cancel renaming on enter if no file name changes
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-12-12 18:25:03 +01:00
Louis
cabedbf9c3
Revert "[stable30] fix: Handle copy of folders containing live photos" 2024-12-12 14:28:09 +01:00
Louis Chemineau
3b6920fa81
fix: Copying a live photo to a folder with a conflicting mov file
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-12-05 10:47:57 +01:00
Louis Chemineau
cd82e0a584
test: Copying a folder containing live photos
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-12-05 10:47:57 +01:00
skjnldsv
606241cf76 fix(files): open sidebar on sharing tab by default for files
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-09 11:42:08 +01:00
skjnldsv
f5f59a8414 chore(files): add selection cypress tests
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-07 23:13:57 +01:00
Ferdinand Thiessen
d4685cb036 fix(files): Ensure renaming state is correctly reset
Problem: Is a node is renamed and the new name is out of the current
visible list of nodes the component will be recycled, this means
the props will change, so when the `onRename` functions is about to reset
the state the `this.source` will point to a different node.

To fix this, but also to separate business logic from visual representation,
the logic is moved into the renaming store and the component is only
responsible for rendering.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-21 13:53:08 +02:00
Ferdinand Thiessen
7b78a64fa8
test(files): Add tests for path handling
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-17 17:54:13 +02:00
Ferdinand Thiessen
49d2d962b2 test: Add Cypress test for renaming loading state
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-01 11:48:05 +02:00
Ferdinand Thiessen
bc3d7a00b0 fix(files): Correctly check for already used names when creating new folder
Also add Cypress tests for the "new"-menu.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-29 15:33:26 +02:00
Ferdinand Thiessen
57bd5d06c1 fix: Access node owner by top level owner property
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-17 16:31:24 +00:00
Côme Chilliet
e7854a9935
chore(tests): Fix import in cypress test limit_to_same_group.cy.ts
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-12 16:09:42 +02:00
Côme Chilliet
244491adc1
chore(tests): Fix SPDX license header on new cypress test
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-12 15:21:38 +02:00
Côme Chilliet
e23325f047
fix: Remove shares only if there are no more common groups between users
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-12 15:20:21 +02:00
Louis Chemineau
b6e28bbeff
chore(tests): Test limiting sharing to same group
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-08-12 15:20:10 +02:00
Ferdinand Thiessen
a8d3046886
test: Added e2e tests for inline system tags file action
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-08 13:21:25 +02:00
Jérôme Herbinet
c221090c86 fix: unify bundle naming
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-08-06 11:14:07 +02:00
Ferdinand Thiessen
674805c994
fix(core): Migrate UserMenu / AccountMenu to NcListItem
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-06 09:20:48 +02:00
Ferdinand Thiessen
c8a5758ccd
test: Add test for recent view
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-01 14:17:48 +02:00
Ferdinand Thiessen
a39f13e94e
fix(files): Provide file actions from list entry to make it reactive
This fixes non reactive default action text of the name component.
Also use download action as default action so that only one place
is needed to define how to download a file.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-01 01:54:42 +02:00
Ferdinand Thiessen
5b8786d02a
test(files_sharing): Add test for "note to recipient" feature
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-31 15:05:15 +02:00