Commit graph

15024 commits

Author SHA1 Message Date
Josh
431c6d0609
fix(Mailer): Fix sendmail binary fallback
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-02-12 13:23:11 +01:00
Ferdinand Thiessen
96384cd950
fix(FediverseAction): Ensure valid fediverse links are generated
Harden also for existing values of the profile.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-07 12:41:49 +01:00
Ferdinand Thiessen
57fc8f1182
fix(AccountManager): Sanitize social media handles
Ensure to only accept valid X and fediverse handles.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-07 12:41:49 +01:00
Richard Steinmetz
2f4d646246 fix(oauth2): adjust db schemas when migrating from owncloud
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-02-05 21:18:45 +00:00
Robin Appelman
5d094feee0
fix: explicitly ignore nested mounts when transfering ownership
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-05 09:09:04 +01:00
Robin Appelman
6cf97e929b
fix: translate mount move error messages
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-05 09:09:03 +01:00
Robin Appelman
68829ad47c
fix: improve checks for moving shares/storages into other mounts
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-05 09:08:58 +01:00
Ferdinand Thiessen
72e5d6df75
fix(OC_Files): Fix error response when event was not set
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-31 19:17:22 +01:00
Ferdinand Thiessen
dd5ce9eaa4
fix(sharing): Move permission validation to share manager
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-31 18:21:26 +01:00
Nils Wenninghoff
b21070090b
fix(ConvertType): Read dbtype in createConnectionParams and remove safeguard
Signed-off-by: Nils Wenninghoff <nils@ungemein.cool>
2025-01-30 12:19:39 +01:00
Louis Chemineau
9e6cc5737f
fix: Exclude non accepted shares when computing access list
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-01-30 11:07:23 +01:00
Andy Scherzinger
93a0f036a9
Merge pull request #50527 from nextcloud/backport/50494/stable30
[stable30] fix(performance): use low resolution for blurhash
2025-01-29 22:02:07 +01:00
Richard Steinmetz
b081f3b7c4 fix(s3): treat empty sse_c_key as not set
Co-authored-by: Christian Becker <christian@dabecka.de>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-01-29 17:34:47 +00:00
Max
12983f8079 fix(performance): use low resolution for blurhash
Improve blurhash performance by using a low res image.
The results are hard to destinguish visualy.
It is a **blur** hash after all.

Signed-off-by: Max <max@nextcloud.com>
2025-01-29 10:44:00 +00:00
Kate
c1cd784c89
Merge pull request #50437 from nextcloud/fix/encoding-wrapper-scanner-stable30 2025-01-29 11:26:23 +01:00
Ferdinand Thiessen
a82a097e6a
fix(TemplateLayout): core is not an app but the server itself
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-29 08:37:33 +01:00
Ferdinand Thiessen
ef015a99d2
fix: Correctly return app id and app version for core styles and images
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-29 08:37:33 +01:00
Marcel Klehr
fb7f1631d0
Merge pull request #50418 from nextcloud/backport/50331/stable30
[stable30] fix(taskprocessing): More caching
2025-01-28 23:03:09 +01:00
Ferdinand Thiessen
67e0ef5b72
fix(files): Do not array access null value
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 20:51:42 +01:00
Marcel Klehr
4e10081e2a fix(TaskProcessing\Manager): Add missing cache->get()
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-01-28 10:10:18 +01:00
Marcel Klehr
c79179e22f fix(TaskProcessing): Cache providersById in getPreferredProviders
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

[skip ci]
2025-01-27 21:13:16 +01:00
Marcel Klehr
5b44411256 fix: copypasta
Co-authored-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-01-27 21:13:16 +01:00
Marcel Klehr
69bd525223 fix(taskprocessing): cache provider settings in distributed cache as well
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-01-27 21:13:16 +01:00
Marcel Klehr
0a91ca4c51 fix(TaskProcessing\Manager): Cache the result of parsing JSON
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-01-27 21:13:16 +01:00
Marcel Klehr
7733a036cb fix(taskprocessing): Cache result of getAvailableTaskTypes between requests
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-01-27 21:13:16 +01:00
Louis Chemineau
474d93625b fix: Metadata field search
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-01-27 18:57:00 +01:00
Dario Mehlich
654034638e fix(preview): Filter for folders in cleanup old preview job
Fixes #35936.
When running `OC\Preview\BackgroundCleanupJob`, the main iteration loop
in `run()` expects a folder, however, `getOldPreviewLocations()`
currently does not filter by mimetype and therefore can yield a
non-folder entry which causes an Exception when constructing the Folder
impl.
Filtering for `httpd/unix-directory`, as `getNewPreviewLocations()`
already does, fixes this issue.

Signed-off-by: Dario Mehlich <d.mehlich@gmail.com>
2025-01-27 15:09:36 +00:00
Joas Schilling
241c9f348d fix(log): Fix log level handling
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-01-27 10:22:20 +00:00
Ferdinand Thiessen
9658c051de fix: Ensure label is always a string
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-26 19:59:25 +00:00
Marcel Klehr
5f55acb2eb fix(TaskProcessing): Catch JSON encode errors in Manager#setTaskResult
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-01-24 23:53:48 +01:00
Kostiantyn Miakshyn
bc7ce1c84a fix: Trim tags on adding or editing
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
2025-01-23 00:10:10 +00:00
Robert Riemann
758fe6dc9d fix: add sse_c_key from S3 object storage properties config to list of sensitive values
Signed-off-by: Robert Riemann <robert@riemann.cc>
2025-01-22 09:09:24 -05:00
Kate
1c99b367be
Merge pull request #49991 from nextcloud/backport/49887/stable30 2025-01-20 17:28:02 +01:00
Robin Appelman
a2bcf725a6
chore: psalm fixes
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-01-20 15:31:05 +01:00
Git'Fellow
1efa72d91a fix(TemplateManager): Remove warning message
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-01-20 13:41:38 +00:00
Robin Appelman
2f9b54ab38
fix: don't skip scanner users filesystem if they have a mountpoint at /<user>/files/
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-01-20 14:27:24 +01:00
Kostiantyn Miakshyn
77e8a55405 fix: Apply enforce theme config for anonymous users as well
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
2025-01-18 21:00:33 +02:00
provokateurin
cb81f6c11c fix(Http): Only allow valid HTTP status code values via template
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-08 10:14:12 +00:00
Pauli Järvinen
c57495a429 fix(preview): Do not try to parse M3U files as MP3
By default, the MP3 audio files get the mimetype `audio/mpeg` and the M3U and
M3U8 playlist files get the mimetype `audio/mpegurl`. PreviewManager had such
a problem that it registered the MP3 preview provider with a regular
expression which matched also the M3U files. This caused an error message to
be logged on the info (1) level for each M3U file every time a folder with
such files was viewed: "Error while getting cover from mp3 file:
File /path/to/some/playlist.m3u is not mpeg/audio!".

Signed-off-by: Pauli Järvinen <pauli.jarvinen@gmail.com>
2025-01-07 19:07:19 +00:00
Joas Schilling
b9493cc12d fix(logger): Prevent infinite recursion with log.condition => matches
When we need to check the log condition for a user matches,
there is a risk that something on the way checks the log level
and would result in an infinite loop.
So we simply check if it's a nested call and use the default
warning level in that case.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-01-03 11:12:48 +00:00
Git'Fellow
c2b05000c7 fix(shares): Remove noisy text from emails
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-12-30 18:36:55 +00:00
Git'Fellow
999f5dee00
Merge pull request #49878 from nextcloud/backport/49746/stable30
[stable30] fix(share): Don't print twice the same text on emails
2024-12-30 19:35:20 +01:00
Côme Chilliet
28c885dbf2
fix: Use getRelativePath method to check if node is inside folder
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:44:08 +01:00
Côme Chilliet
e30cd2f03f
fix: Fix promotion of reshares from subsubfolders
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:44:02 +01:00
Côme Chilliet
ec85a49cad
chore: Add comment to make code clearer
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:43:44 +01:00
Côme Chilliet
04b6eef246
chore: Turn method description into phpdoc
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2024-12-19 14:43:37 +01:00
Côme Chilliet
c7dbe7e71c
fix(shares): Promote reshares into direct shares when share is deleted
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:43:21 +01:00
Côme Chilliet
16decdede7
fix: Tidy up code for reshare deletion
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:41:50 +01:00
Luka Trovic
024f98a8a1
fix: delete re-shares when deleting the parent share
Note: Removed part about fix command from original PR

Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
(cherry picked from commit 42181c2f49)
2024-12-19 14:39:44 +01:00
skjnldsv
b356cba2a6 fix: make sure we have a valid scheme when testing ocm urls
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-12-17 15:23:59 +01:00