Commit graph

11071 commits

Author SHA1 Message Date
John Molakvoæ
91af4e2a15
Merge pull request #27107 from nextcloud/backport/27043/stable21 2021-07-01 11:39:47 +02:00
Christoph Wurst
5dd3b5067c Unshift crash reports when they are loaded, to break the recusion
If, for whatever reason, during the loading of a crash reporter a new
log entry is generated, then the lazy loading mechanism will be invoked
*again* while it's already executed. This doesn't result in an endless
recursion, but means that the crash reporters will be built and
registered many times. This then means any further log entry will be
logged x times instead of once.

Unshift makes sure to take the class off the registration list right
away, so another invokation of the same method won't try to do the same
job.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-06-25 06:37:07 +00:00
korelstar
7b8d4b2d37 fix error when using CORS with no auth credentials 2021-06-23 20:57:11 +02:00
Lukas Reschke
72309a158a Remove throwing annotation
This class was just introduced in Nc 21.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-06-22 13:53:28 +00:00
Lukas Reschke
ba12eb7aba Use execute instead of executeStatement
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-06-22 13:53:28 +00:00
Morris Jobke
e757a5ecfd Properly cleanup entries of WebAuthn on user deletion
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-06-22 13:53:27 +00:00
Julius Härtl
420d395947
Merge pull request #27415 from nextcloud/backport/26494/stable21 2021-06-14 09:48:41 +02:00
Julius Härtl
6e190b1a55
Merge pull request #27303 from nextcloud/backport/27062/stable21
[stable21] properly use limit and offset for search in Jail wrapper
2021-06-09 08:07:49 +02:00
Richard de Boer
9f3824b884 Check whether output buffering is active before turning it off
Before we just turned it off and @suppressed the error if ob was not active.
In PHP 8 this error is no longer suppressed, so try to not cause it at all.

Signed-off-by: Richard de Boer <git@tubul.net>
2021-06-07 21:33:53 +00:00
Richard de Boer
7e9d459fea Fix functions taking optional parameters before required ones
PHP 8 shows deprecation warnings about this, see #25806
Removes the "default" values, as they actually are required parameters anyway.

Signed-off-by: Richard de Boer <git@tubul.net>
2021-06-07 21:33:52 +00:00
Morris Jobke
4136993f44
Merge pull request #27336 from nextcloud/backport/27329/stable21
[stable21] Propagate throttling on OCS response
2021-06-07 10:39:52 +02:00
John Molakvoæ
390bd12c8a
Merge pull request #27333 from nextcloud/backport/27328/stable21
[stable21] emit UserLoggedInEvent on apache auth
2021-06-06 11:00:24 +02:00
Robin Appelman
287edf0e61
Set umask before operations that create local files
this solves issues where "other php stuff" is messing with the umask

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-06-04 15:43:16 +02:00
Joas Schilling
c89fbcde11
Merge pull request #27347 from nextcloud/backport/27053/stable21
[stable21] Don't throw when comments is disabled
2021-06-04 11:01:31 +02:00
Joas Schilling
5593ec985e Don't throw when comments is disabled
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-02 13:42:49 +00:00
Lukas Reschke
6a6bcdc558 Propagate throttling on OCS response
The BaseResponse converter did not take over any throttling state from the DataResponse.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-06-01 19:42:31 +00:00
Richard Steinmetz
5c868c735d Don't allow executing cli if cache backend is unavailable
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2021-06-01 16:07:07 +00:00
Arthur Schiwon
2e57360a0d emit UserLoggedInEvent on apache auth
- post_login OC_Hook is barely used or listened to

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-01 15:41:04 +00:00
Robin Appelman
a21eb8d6d2 properly use limit and offset for search in Jail wrapper
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-05-31 12:28:12 +00:00
Morris Jobke
a1877062ac Use noreply@ as email address for share emails
Fixes #26683

Before it used the instance name, which a) doesn't make sense to randomly guess email addresses and b) could contain characters that are not allowed in email addresses like spaces.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-05-28 11:42:16 +00:00
Robin Appelman
5bb0370994 improve type handling of Avatar::generateAvatarFromSv
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-05-26 17:11:42 +00:00
Robin Appelman
3775b862a9 fix return value of getStorageInfo when 'quota_include_external_storage' is enabled
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-05-25 19:59:14 +00:00
Florent
ede67149ea Avoid reading ~/.aws/config when using S3 provider
When using S3 storage, we sometimes have open_basedir errors due to aws-sdk-php trying to read ~/.aws/config which is out of open_basedir restrictions.
Christoph Wurst already added csm=false config in #21406 but it wasn't enough, we also need to set use_arn_region=false, added in this commit.

Signed-off-by: Florent <florent@coppint.com>
2021-05-25 08:59:03 +00:00
Julius Härtl
80cda3b174 Fix log error when creating files from an empty template
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-05-19 07:03:27 +00:00
Joas Schilling
3d9abee6f0
Don't break OCC if an app is breaking in it's Application class
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-06 14:46:11 +02:00
Roeland Jago Douma
f4135573d0 Do not try to contact lookup server if not needed
In some cases (for example you never send data to the lookup server)
there is no need for this job to even try.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-29 09:07:38 +02:00
Julius Härtl
e2fffcda44 Fail when creating new files with an empty path
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-28 10:06:03 +00:00
Joas Schilling
ab595274c0 Do not allow to overwrite some variables
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 13:40:14 +00:00
Joas Schilling
6a8d6beb57 Fix ratelimit template
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 13:40:12 +00:00
Roeland Jago Douma
4082318616
Merge pull request #26760 from nextcloud/backport/26259/stable21
[stable21] Validate the website field input to be a valid URL
2021-04-26 20:42:06 +02:00
Roeland Jago Douma
e075f80f41
Merge pull request #26759 from nextcloud/backport/26747/stable21
[stable21] Fix installer deprecation warnings for PHP 8
2021-04-26 20:41:49 +02:00
Joas Schilling
d1756dde20 Log deprecation only as debug
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-26 15:12:50 +00:00
Joas Schilling
6ed9bb36ac Respect the error level when logging
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-26 15:12:50 +00:00
Joas Schilling
2c1218826d Validate the website field input to be a valid URL
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-26 11:58:56 +00:00
acsfer
63fa7d9354 PHP 8+ deprecates openssl_free_key 2021-04-26 10:46:44 +00:00
acsfer
c12be83a0b Only use libxml_disable_entity_loader on PHP<8 2021-04-26 10:46:44 +00:00
Maxence Lange
35204381bb private cannot be final
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2021-04-26 07:06:08 +00:00
Roeland Jago Douma
97e5fe43df Explicitly check hex2bin input
For #23197

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-22 11:31:39 +00:00
Roeland Jago Douma
f915efc859
Merge pull request #26639 from nextcloud/backport/26551/stable21
[stable21] ensure redis returns bool for hasKey
2021-04-20 10:33:18 +02:00
Arthur Schiwon
92e1606c18
ensure redis returns bool for hasKey
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-19 23:40:47 +02:00
Vincent Petry
fe0f1c792c
Fix empty password check for mail shares
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-19 15:44:26 +02:00
Lukas Reschke
ad91f39c46 Limit size of properties to 2048 characters
It is unreasonable to expect that one of these fields would be longer
than 2048 characters. Whilst some have definitely lower limits (such as
for phone numbers or domain names), a upper bound as sanity check makes
sense.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-12 16:37:04 +00:00
Lukas Reschke
b5838c5248 Increase subnet matcher
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-12 10:36:25 +00:00
Lukas Reschke
d66e86c56c
Merge pull request #26400 from nextcloud/backport/26061/stable21
[stable21] Log and continue when failing to update encryption keys during for individual files
2021-04-06 13:43:34 +02:00
John Molakvoæ
b59cf16325
Merge pull request #26406 from nextcloud/backport/26396/stable21 2021-04-02 16:59:51 +02:00
Julius Härtl
dc8e819915 Properly handle creating the template directory in a subfolder (fixes #25787)
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-01 13:31:55 +00:00
Julius Härtl
89a19a338e Get the parent directory before creating a file from a template
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-01 13:31:55 +00:00
Robin Appelman
40507ca543
make ILDAPProviderFactory usable when there is no ldap setup
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-04-01 13:08:23 +02:00
Vincent Petry
6ac708c99a Fix phpcs issues in encryption update
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-01 07:56:41 +00:00
Julius Härtl
d6bad03a5c Log and continue when failing to update encryption keys during for individual files
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-01 07:56:41 +00:00