upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-21 22:27:31 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 16
68477 commits 871 branches 1195 tags 8.3 GiB
Commit graph

1968 commits

Author SHA1 Message Date
Arthur Schiwon
5596af2b96
docs(dav): remove outdated comment 
The method was added actually to PHP API in 28 and the mentioned check
is not in place anymore.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-06 21:57:08 +02:00
Joas Schilling
abc8ff38cb
fix: Cleanup unused imports and some type deprecations 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-07-06 10:37:40 +02:00
Joas Schilling
eb09053897
feat(admin_audit): Migrate to non-deprecated IEventDispatcher 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-07-04 12:36:30 +02:00
Johannes Merkel
eda3824d91 enh(sab): Add profileUrl to SAB 
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
 2023-07-03 17:55:18 +02:00
Christoph Wurst
f43c24b0b1
Merge pull request #31790 from nextcloud/fix-events-with-old-lastoccurence 
Fix creating events with old (< unix time) lastoccurence
 2023-06-29 09:42:55 +02:00
Julius Härtl
eddb64f8c3
Merge pull request #37969 from nextcloud/poc/noid/systemtags-perf-tag-endpoint 2023-06-28 07:53:35 +02:00
Arthur Schiwon
d9487103c9
fix: cannot apply limit+offset on multi-tag-search 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-27 23:06:39 +02:00
Thomas Citharel
1e390e1982 style(caldav): improve getDenormalizedData method 
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2023-06-27 11:16:47 +00:00
Thomas Citharel
3886b00a33 Fix creating events with old (< unix time) lastoccurence 
Closes #20804

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2023-06-27 11:16:47 +00:00
Christoph Wurst
92c18b252c
fix(dav): Catch SAB sync errors during upgrade 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-06-26 10:52:07 +02:00
Johannes
199b9788e6
Merge pull request #38856 from nextcloud/fix/contacts/3404/put-location-in-proper-place 
fix(sab): put location in proper address field
 2023-06-22 11:51:33 +02:00
Joas Schilling
e9d8dbf53c
Merge pull request #38747 from nextcloud/perf/early-exit-mkcol 
perf: skip request without write permission
 2023-06-22 09:02:55 +02:00
Arthur Schiwon
00b396a674
refactor: save unnecessary method_exists 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-21 20:35:41 +02:00
Arthur Schiwon
a0b683477f
fix: use array_unitersect against objects 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-21 20:28:02 +02:00
Arthur Schiwon
27f6f86d75
fix: obey offset and limit for results from favs and circles 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-21 20:28:01 +02:00
Arthur Schiwon
a0f9556f7c
fix: cominbation of small fixes 
- possible null return
- parameter name mismatch in implementation
- incomplete unit test

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-21 20:28:01 +02:00
Arthur Schiwon
49db546f78
fix: include invisible tags for admins 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-21 20:28:01 +02:00
Arthur Schiwon
29f59a54b4
fix: search with more than one search tags 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-21 20:28:00 +02:00
Arthur Schiwon
30028bb9ac
fix: no search when LazyFolder was provided 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-21 18:19:09 +02:00
Arthur Schiwon
ddb65be58f
chore: cleanup unused code 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-21 18:19:09 +02:00
Arthur Schiwon
be50bd1b0f
fix: ensure searchBySystemTag() is available 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-21 18:19:08 +02:00
Arthur Schiwon
783e32a64d
fix: favorites view and universal search against tags 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-21 18:19:08 +02:00
Arthur Schiwon
58f7fd2370
use efficient tag retrieval on DAV report request 
- uses DAV search approach against valid files joined by systemtag selector
- reduced table join for tag/systemtag search
- supports pagination
- no changes to the output formats or similar

Example request body:

<?xml version="1.0"?>
<oc:filter-files xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns" xmlns:nc="http://nextcloud.org/ns" xmlns:ocs="http://open-collaboration-services.org/ns">
  <d:prop>
    <d:getcontentlength/>
    <d:getcontenttype/>
    <d:getetag/>
    <d:getlastmodified/>
    <d:resourcetype/>
    <nc:face-detections/>
    <nc:file-metadata-size/>
    <nc:has-preview/>
    <nc:realpath/>
    <oc:favorite/>
    <oc:fileid/>
    <oc:permissions/>
    <nc:nbItems/>
  </d:prop>
  <oc:filter-rules>
    <oc:systemtag>32</oc:systemtag>
  </oc:filter-rules>
  <d:limit>
    <d:nresults>50</d:nresults>
    <nc:firstresult>0</nc:firstresult>
  </d:limit>
</oc:filter-files>

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-06-21 18:19:08 +02:00
Simon L
56c16b306f
Merge pull request #38639 from charno/bugfix/36644-pruneOutdatedSyncTokens-deletes-all-entries 
Bugfix/36644 pruneOutdatedSyncTokens deletes all entries
 2023-06-20 16:36:28 +02:00
Johannes Merkel
3cb8968808 fix(sab): put location in proper address field 
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
 2023-06-20 16:18:09 +02:00
Carl Schwan
9725d00329
Cleanup comments code 
- Fix various psalm issues
- Add as much typing as possible while preserving stable API

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2023-06-20 10:55:20 +02:00
Daniel Kesselberg
debd03f30d perf: skip request without write permission 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2023-06-19 13:42:13 +00:00
Christoph Wurst
62c41967e8
fix(carddav): Make SystemAddressBook::__construct $groupManager argument nullable 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-06-12 18:44:25 +02:00
Christof Arnosti
73fb2997f4 Issue #36644: Fix pruneOutdatedSyncTokens for CalDAV 
pruneOutdatedSyncTokens accidentally deletes all entries of the calendarchanges table
instead of leaving $limit elements in the table

Signed-off-by: Christof Arnosti <charno@charno.ch>
 2023-06-12 08:35:35 +00:00
Christoph Wurst
a213650b71
fix(caldav): Cast calendar objects id to int when building index 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-06-06 09:45:39 +02:00
Christoph Wurst
6f3f84e955
fix(caldav): Close DB cursor in reminder index background job 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-06-05 18:47:24 +02:00
Christoph Wurst
b7e7d80173
fix(caldav): Ignore invalid events for reminder generation 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-05-31 09:49:04 +02:00
Joas Schilling
ef93bb926c
fix(dav): Fix avatar size in system address book 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-05-26 10:03:58 +02:00
Arthur Schiwon
cd5bd11771
Merge pull request #38448 from nextcloud/fix/carddav/no-sab-guest-users 
fix(carddav): Don't show system address book cards to guests
 2023-05-25 17:26:46 +02:00
Christoph Wurst
9780472a02
Merge pull request #38454 from nextcloud/fix/capitalization-other-tel 
fix(carddav): Make system contact phone number RFC compliant
 2023-05-25 15:56:08 +02:00
Christoph Wurst
e524631ce3
fix(carddav): Don't show system address book cards to guests 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-05-25 12:26:26 +02:00
greta
50b61c8b7b fix(carddav): Make system contact phone number RFC compliant 
Signed-off-by: greta <gretadoci@gmail.com>
 2023-05-25 11:10:25 +02:00
Christoph Wurst
5cfbd4c535
fix(carddav): Check enumeration settings for all SAB methods 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-05-25 09:11:26 +02:00
Johannes
7ec1ceb79a
Merge pull request #38413 from nextcloud/fix/38412/save-avatar-SAB 
fix(SAB): Save avatar to SAB
 2023-05-23 15:55:26 +02:00
Johannes Merkel
5983ef001d
fix(SAB): Save avatar to SAB 
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
 2023-05-23 11:15:34 +02:00
Anna Larch
3c93ce9c25
fix(carddav): Check if SERVER variables are set before accessing them 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2023-05-23 10:58:29 +02:00
Thomas Citharel
13a3ebd4cc
feat(CardDAV): Add Sabre\DAV\IMoveTarget support to OCA\DAV\CardDAV\AddressBook 
This allows to just UPDATE the card row instead of deleting it and reinsert it. It's very similar to https://github.com/nextcloud/server/pull/30120 for calendars.

As we need the addressbookid exposed, this introduces OCA\DAV\CardDAV\Card that extends Sabre's.

I chose specifically NOT to auto-inject LoggerInterface in Addressbook like in #30120 because the chain of DI is huge just for ONE simple call and it would break an existing dirty call (OCA\Contacts calling OCA\DAV) of ContactsManager in Contacts: https://github.com/nextcloud/contacts/pull/1722 (in SocialApiService), but this is debatable.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2023-05-16 11:38:57 +02:00
Simon L
25dd264965
Merge pull request #37965 from nextcloud/fix/transactional-system-addressbook-sync 
fix(dav): Run system address book create-if-not-exists in transaction
 2023-05-16 11:33:09 +02:00
Christoph Wurst
5d038a2dc1
fix(carddav): Mark system address book as read-only 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-05-15 10:27:53 +02:00
Christoph Wurst
2cc672d26b
fix(dav): Run system address book create-if-not-exists in transaction 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-05-12 14:15:02 +02:00
Christoph Wurst
1381c4c157
feat(users): Store and load a user's manager 
Co-Authored-By: hamza221 <hamzamahjoubi221@gmail.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-05-12 13:56:48 +02:00
Anna Larch
5c2eb732f1 fix(carddav): expose system address book 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2023-05-11 18:59:30 +02:00
Arthur Schiwon
b6c034ac57
Merge pull request #37961 from nextcloud/poc/noid/systemtags-perf 
SystemTags endpoint to return tags used by a user with meta data
 2023-05-11 10:16:03 +02:00
Arthur Schiwon
2d41f0c064
Merge pull request #38067 from nextcloud/fix/noid/sortTags 
fix: sort tags by name
 2023-05-11 09:54:15 +02:00
Arthur Schiwon
e20e18f45f
fix: use interface instead of implementation as type hint 
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-05-10 19:06:29 +02:00