Commit graph

195 commits

Author SHA1 Message Date
Christopher Ng
e225b8d77d
Fix inability to re-enter share password after invalid input
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-01-19 10:15:28 +01:00
Vincent Petry
2246c894ad Improve password generation for link shares
Use web crypto when generating password for link shares
whenever the password policy app is disabled.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-01-17 00:22:59 +00:00
Max
be2121c64b
fix: remove other shares from ui when deleted
Remove the share entry in question
when unsharing a folder
from within the `others with access` section
of a file within that folder.

Using the code from the ShareList view here as well.
Just copying the code here as this is a bugfix
that will need to be backported.

Signed-off-by: Max <max@nextcloud.com>
2022-12-22 18:25:39 +01:00
Vincent Petry
5fb827d062 Remove copy in file actions when not allowed
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-26 18:04:06 +00:00
Julius Härtl
bdaa8843b4
Fix label for allow download share permission
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-08-03 13:24:40 +02:00
Carl Schwan
aafaa39515
Multiple fixes
- Fix tests
- Use non deprecated event stuff
- Add a bit of type hinting to the new stuff
- More safe handling of instanceOfStorage (share might not be the first
  wrapper)
- Fix resharing

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-03 13:24:38 +02:00
Carl Schwan
146dda4266
Enforcing permission during resharing
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-03 13:24:20 +02:00
Julius Härtl
ef6e4fc52d
Fix adding to empty attributes and duplicate request
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-08-03 13:24:20 +02:00
Vincent Petry
189b7b1624
Add share attrs + download permission support in frontend
Added download permission checkbox in frontend
Added share attributes parsing and setting in frontend.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-03 13:24:19 +02:00
Carl Schwan
7bbf44e040 Fix loading groupfolder info when share api is disabled
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-06 17:15:07 +02:00
Louis Chemineau
8a2b70fe67 Fix share permissions rendering
The `SHARE` permissions falls into the `default` case in the switch case, causing the rendering to look like ` , Upload, Read`.

This PR changes the return value of the `default` case and adds a `filter` to remove those values.

Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-06-09 15:06:56 +02:00
Cyrille Bollu
e35cbd2a6b Various improvements related to the recent implementation of temporary passwords
for mail shares:

1- Changes style of "forgot password?" and "Back" button
2- Adds information about share password's expiration time in the emails sent.
3- Shows password expiration time in the Share menu
4- Fixes an issue when the message "Password expires..." would be shown for non email share types (which don't have temporary passswords)
5- At share's creation, password should only be sent when it's a permanent one

See also https://github.com/nextcloud/server/issues/31952

Signed-off-by: Cyrille Bollu <cyrpub@bollu.be>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-06-08 13:22:10 +00:00
Cyrille Bollu
c6a5c07041 Adds a "Request password" button to the public share authentication page for shares
of type TYPE_EMAIL, when the "video verification" checkbox isn't checked. Users accessing
non-anonymous public shares (TYPE_EMAIL shares) can now request a temporary password themselves.

- Creates a migration step for the files_sharing app to add the 'password_expiration_time'
  attribute to the oc_shares table.
- Makes share temporary passwords' expiration time configurable via a system value.
- Adds a system config value to allow permanent share passwords

-Fixes a typo in a comment in apps/files_sharing/src/components/SharingEntryLink.vue

See https://github.com/nextcloud/server/issues/31005

Signed-off-by: Cyrille Bollu <cyrpub@bollu.be>
2022-04-11 21:58:24 +02:00
Louis Chemineau
3d33c8107e Fix regression for edit perm on file share
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-02-21 10:47:20 +01:00
Louis Chemineau
da435b1e67 Support CRUD share permissions
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-02-15 11:54:17 +01:00
Louis Chemineau
be968a8841 Use @nextcloud/sharing in files and files_sharing
Signed-off-by: Louis Chemineau <louis@chmn.me>

Update tests

Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-26 17:58:43 +01:00
Louis Chemineau
e101882b92
Auto fix warnings
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-21 13:13:52 +01:00
Louis Chemineau
14e57bf70a Replace license information to SPDX expression
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 17:26:40 +01:00
Louis Chemineau
d92cbf5149 Typing corrections
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 17:12:55 +01:00
Louis Chemineau
9ed12e8946
Bump p-queue
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-08 10:15:48 +01:00
John Molakvoæ (skjnldsv)
dd7bf0f902
Fix dynamic loading
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2022-01-08 10:14:53 +01:00
John Molakvoæ (skjnldsv)
74b9803108
Eslint fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2022-01-08 10:14:05 +01:00
Louis Chemineau
adfb9010d4
Migrate to webpack v5
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-08 10:12:47 +01:00
Carl Schwan
9c4cf7367a Fix share owner not being displayed in sharing tab
This only concerns subfolder and files inside a shared folder and is
used as fallback when the OCS api returns a empty result, because it
only works on the shared folder and not the content inside of it.
This unify the tab with the folder list.

This offers a less descriptive share information but making the
OCS api returns all the details even for the subfolder would very
probably be bad for performance (since we would need to fetch the shares
for all the parent folders until we found one or are in the root folder).

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2021-12-14 21:59:58 +00:00
Jonas Rittershofer
e006491b85
Fix ShareLink Upload UI for Folders
Do not show the Upload-Option if it is not allowed to check.

Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
2021-12-14 01:02:04 +01:00
John Molakvoæ
3a4179d816
Fix first day locale
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2021-12-09 09:07:32 +01:00
John Molakvoæ
2239047927
Properly format sharing datepicker locale
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2021-12-09 08:49:17 +01:00
Joas Schilling
18dc15fb71 Fix missing translations of share folder selection
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2021-10-04 19:11:19 +00:00
John Molakvoæ
164b0064ed
Add new ExternalShareActions API
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2021-09-16 15:20:50 +02:00
Hinrich Mahler
961f8958c0
Let users choose a share_folder 2021-09-06 16:39:11 +02:00
Vincent Petry
c1563215e6
Disable default actions in pending file list
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-07-27 12:19:25 +02:00
Vincent Petry
f3f2faa815
Pending remote group share fixes
Only remove reject share for remote group shares
Also fix share indicator to appear for remote group shares as well.
Fix pending remote share icon to be the one of a share.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-07-27 12:19:25 +02:00
Vincent Petry
46b8cf4f64
Remove "Reject share" for pending remote shares
In the list of pending shares, the option for rejecting the share has
been removed.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-07-27 12:19:24 +02:00
Vincent Petry
53aafff972
Extend pending shares list to include remote shares
And adjust the accept/decline actions to use the right endpoint for
remote shares.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-07-27 12:19:18 +02:00
John Molakvoæ (skjnldsv)
b2b35c2b34
Bump p-queue
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-07-26 18:46:37 +02:00
dependabot[bot]
6e5191b702 Bump @nextcloud/router from 1.2.0 to 2.0.0
Bumps [@nextcloud/router](https://github.com/nextcloud/nextcloud-router) from 1.2.0 to 2.0.0.
- [Release notes](https://github.com/nextcloud/nextcloud-router/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-router/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-router/compare/v1.2.0...v2.0.0)

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-07-23 15:56:28 +02:00
John Molakvoæ (skjnldsv)
7ca81f360f
Fix eslint and update bundles
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-07-22 13:21:25 +02:00
Julien Veyssier
c035541ba4 show breadcrumb detail view in breadcrumb menu
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-07-13 12:51:41 +00:00
Julius Härtl
9467a93866
Only allow removing existing shares that would not be allowed due to reshare restrictions
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-06-09 10:36:43 +02:00
John Molakvoæ (skjnldsv)
aef00ddeaf Replace proposal-class-private-properties by regular properties
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-06-02 15:10:01 +00:00
John Molakvoæ (skjnldsv)
f1f8fa1e99
Move remnants of ocs api requests to v2 endpoint
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-05-26 08:25:00 +02:00
Roeland Jago Douma
68dadc01af Consider read permission in sharing tab
When updating a share we should make sure to use all the old permissions
(and only change what we actually changed). So the READ permission in
this case should also be fetched instead of always granted.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-19 15:10:51 +02:00
Vincent Petry
af61486aea
Separate settings for remote share expiration
Added separate settings for default and enforced expiration date for
remote shares.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:06:09 +02:00
Vincent Petry
8680bafc5c
Implement expiration date for federated shares
Add expiration date field in UI.
Save expiration date when creating or updating federated share.
Read expiration date from DB in federated share provider.
Applies to both federated user and group shares.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:02:00 +02:00
John Molakvoæ (skjnldsv)
4b9991a4f2 Fix undefined error on add-share
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-04-13 06:21:48 +00:00
John Molakvoæ (skjnldsv)
3e624dc399
Bump js licenses
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-31 12:17:18 +02:00
John Molakvoæ (skjnldsv)
a100186e5e
Sharing link & mail parity
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:50:45 +01:00
John Molakvoæ (skjnldsv)
5e519fe17a
Clear the input after adding a new share
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:41:33 +01:00
John Molakvoæ (skjnldsv)
c47e79fc67
Handle enforced password for mail shares in the WebUI
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:40:43 +01:00
John Molakvoæ (skjnldsv)
c8e0809d43
Extract GeneratePassword function to its own file
This is needed to be able to use the function from other components.

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:40:41 +01:00