Commit graph

1929 commits

Author SHA1 Message Date
Johannes Merkel
97d3ef565b
fix(CalDAV): set acls for DeletedCalendarObjectsCollection
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
2024-01-18 08:40:30 +01:00
Richard Steinmetz
de3d39048f
fix(dav): allow multiple organizers if possible
This is very hacky! However, we want to allow saving events with multiple
organizers. Those events are not RFC compliant, but sometimes imported from major
external calendar services (e.g. Google). If the current user is not an organizer of
the event we ignore the exception as no scheduling messages will be sent anyway.

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-01-02 11:56:44 +01:00
Christoph Wurst
837c597ce0 fix(dav): Avoid date diffing if PHP is buggy
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-11-24 10:53:57 +00:00
Julius Härtl
f6facb233b fix: Validate that we have a proper distributed cache configured
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-11-10 08:42:07 +00:00
Richard Steinmetz
ab0a39deaf
fix(dav): expand recurrences when searching
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2023-09-26 16:03:42 +02:00
Daniel Kesselberg
3a55fb948f fix(caldav): add webroot to objectid for activities
A calendar uri includes the webroot: example.com/cloud/remote.php/dav/calendars/alice/personal/
The calendar app uses base64(calendar uri) as identifier for calendar objects.

Without this patch the links from activity app to calendar app don't work for installations in a subdirectory.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-09-18 14:09:53 +02:00
Anna Larch
22a7e3796f fix(CalDAV): check birthday calendar owner
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-09-06 17:21:20 +00:00
Daniel
72a3295c05
Merge pull request #39861 from nextcloud/caldav-share-preload-26 2023-09-06 12:37:41 +02:00
Robin Appelman
4369022f18 cache calendar objects from calendarQuery
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-08-14 16:19:41 +02:00
Robin Appelman
64c74716ca preload shares for calendars when listing calendars
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-08-14 14:52:06 +02:00
Daniel Kesselberg
e876408c16 fix: close cursor after reading the invitation
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-08-11 16:12:33 +00:00
Jamie McClelland
1bc8feb332 ensure outerquery ->where() function doesn't clobber earier ->andWhere()
Signed-off-by: Jamie McClelland <jm@mayfirst.org>
2023-08-10 07:52:04 +00:00
Jamie McClelland
4f898b9b36 optimize calendar search query
see https://github.com/nextcloud/calendar/issues/4758

Signed-off-by: Jamie McClelland <jm@mayfirst.org>
2023-08-10 07:52:04 +00:00
Max
e9c9fb4bd3 fix(dav): use quota of destination in s3 chunk upload
Resolves: #39228.
Check the free space on the destination.

Before it was checking the free space on `$storage`
which is the upload storage of the user who triggered the upload.
This led to user quota being applied
even when uploading to a share with unlimited space.

Signed-off-by: Max <max@nextcloud.com>
2023-08-02 12:10:57 +00:00
Matthieu Gallien
4850828839 when reading an empty file getting EOF is not an error
will allow uploading empty files via bulk upload

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-07-24 13:29:33 +02:00
Daniel Kesselberg
f537c7b5c6 fix: check that object store backend supports multi part uploads
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-07-23 16:06:55 +02:00
Thomas Citharel
226027abf7 style(caldav): improve getDenormalizedData method
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2023-07-12 19:57:23 +02:00
Thomas Citharel
ceca4cd018 Fix creating events with old (< unix time) lastoccurence
Closes #20804

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2023-07-12 19:57:23 +02:00
Arthur Schiwon
23c2fdc296
Merge pull request #38920 from nextcloud/backport/38639/stable26
[stable26] pruneOutdatedSyncTokens deletes all entries
2023-07-12 00:58:47 +02:00
Richard Steinmetz
491eda93cc fix(dav): close cursor when fetching max id
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2023-07-11 07:58:46 +02:00
Robin Appelman
f8eceb40d4 preload custom properties when propfinding folders
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-07-10 20:24:32 +00:00
Julius Härtl
c7a8c3b427
Merge pull request #39232 from nextcloud/backport/39202/stable26 2023-07-10 18:08:23 +02:00
Arthur Schiwon
f4f6a95b02
Merge pull request #38972 from nextcloud/backport/38747/stable26
[stable26] perf: skip request without write permission
2023-07-10 17:57:55 +02:00
Joas Schilling
ddff2e692d
fix(dav): Abort requests with 429 instead of waiting
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-10 06:32:01 +02:00
Arthur Schiwon
fc9fd0d7f2
refactor: adjust to unexposed searchBySystemTag
- in this backport we have to drop the breaking addition in
  \OCP\Files\Folder
- this requires adjustments in check for the existance of the method but
  also in testing
- another change in \OCP\SystemTag\ISystemTagManager can be applied as
  this interface is not implemented elsewhere

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-07-07 16:58:07 +02:00
Arthur Schiwon
db1306b955 fix: cannot apply limit+offset on multi-tag-search
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-07-07 14:54:57 +00:00
Arthur Schiwon
dfbedda0a2 refactor: save unnecessary method_exists
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-07-07 14:54:57 +00:00
Arthur Schiwon
22c417d70b fix: use array_unitersect against objects
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-07-07 14:54:57 +00:00
Arthur Schiwon
eeb76461da fix: obey offset and limit for results from favs and circles
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-07-07 14:54:57 +00:00
Arthur Schiwon
749efc1ba1 fix: cominbation of small fixes
- possible null return
- parameter name mismatch in implementation
- incomplete unit test

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-07-07 14:54:56 +00:00
Arthur Schiwon
0b4db60d3b fix: include invisible tags for admins
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-07-07 14:54:56 +00:00
Arthur Schiwon
bb165d3d05 fix: search with more than one search tags
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-07-07 14:54:56 +00:00
Arthur Schiwon
3ed878a368 fix: no search when LazyFolder was provided
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-07-07 14:54:56 +00:00
Arthur Schiwon
b0ec34fc22 chore: cleanup unused code
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-07-07 14:54:56 +00:00
Arthur Schiwon
6d249b56bd fix: ensure searchBySystemTag() is available
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-07-07 14:54:56 +00:00
Arthur Schiwon
48c92ade85 fix: favorites view and universal search against tags
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-07-07 14:54:56 +00:00
Arthur Schiwon
b172df69d6 use efficient tag retrieval on DAV report request
- uses DAV search approach against valid files joined by systemtag selector
- reduced table join for tag/systemtag search
- supports pagination
- no changes to the output formats or similar

Example request body:

<?xml version="1.0"?>
<oc:filter-files xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns" xmlns:nc="http://nextcloud.org/ns" xmlns:ocs="http://open-collaboration-services.org/ns">
  <d:prop>
    <d:getcontentlength/>
    <d:getcontenttype/>
    <d:getetag/>
    <d:getlastmodified/>
    <d:resourcetype/>
    <nc:face-detections/>
    <nc:file-metadata-size/>
    <nc:has-preview/>
    <nc:realpath/>
    <oc:favorite/>
    <oc:fileid/>
    <oc:permissions/>
    <nc:nbItems/>
  </d:prop>
  <oc:filter-rules>
    <oc:systemtag>32</oc:systemtag>
  </oc:filter-rules>
  <d:limit>
    <d:nresults>50</d:nresults>
    <nc:firstresult>0</nc:firstresult>
  </d:limit>
</oc:filter-files>

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-07-07 14:54:55 +00:00
Christof Arnosti
46ceb0d5c1 Issue #36644: Fix pruneOutdatedSyncTokens for CalDAV
pruneOutdatedSyncTokens accidentally deletes all entries of the calendarchanges table
instead of leaving $limit elements in the table

Signed-off-by: Christof Arnosti <charno@charno.ch>
2023-07-04 10:34:39 +02:00
Daniel Kesselberg
f0f4c46545 perf: skip request without write permission
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-07-04 10:32:15 +02:00
Arthur Schiwon
eb99de007d
Merge pull request #38574 from nextcloud/backport/38301/stable26
[stable26] fix(caldav): Ignore invalid events for reminder generation
2023-06-13 11:40:38 +02:00
Christoph Wurst
9ba98151ce fix(caldav): Cast calendar objects id to int when building index
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-06 18:43:13 +00:00
Christoph Wurst
aa5ae7ccf5 fix(caldav): Close DB cursor in reminder index background job
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-06 07:41:35 +00:00
Christoph Wurst
c662ccf81a
fix(caldav): Ignore invalid events for reminder generation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-01 20:41:51 +02:00
Andy Scherzinger
4bd2f33cfe
Merge pull request #38307 from nextcloud/backport/37961/stable26
[stable26] SystemTags endpoint to return tags used by a user with meta data
2023-05-17 18:15:02 +02:00
Arthur Schiwon
83e0b31b62
Merge pull request #38167 from nextcloud/backport/38100/stable26
[stable26] Fix error on delete in ChunkingV2Plugin
2023-05-17 15:54:52 +02:00
Arthur Schiwon
c24bd06825
Merge pull request #37785 from nextcloud/backport/36217/stable26
[stable26] Handle reminders where calendar name is null
2023-05-17 13:41:44 +02:00
Christoph Wurst
fed6aa0329
Merge pull request #38248 from nextcloud/fix/read-only-system-addres-book-acls-stable26
[stable26] fix(carddav): Mark system address book as read-only
2023-05-17 13:13:40 +02:00
Arthur Schiwon
f2b5a079db
refactor: remove SystemTag logic from Folder into QuerySearchHelper
- adds OC\SystemTag\SystemTagsInFilesDetector where the search logic is
  moved to

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-05-16 12:47:09 +02:00
Arthur Schiwon
f50ce8b3bd
chore: polish SystemTagsInUseCollection
- DI SystemTagManager
- add some comments and doc
- catch NoUserException
- add return type hints

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-05-16 12:47:01 +02:00
Arthur Schiwon
b1c8fc38a2
fix: improve naming of new systemtags endpoint to systemtags-assigned
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-05-16 12:46:55 +02:00