Commit graph

25088 commits

Author SHA1 Message Date
provokateurin
4f27d82471
fix(RichObjectStrings): Make exception messages for invalid parameters more useful for debugging
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-17 06:46:12 +01:00
Nextcloud bot
2a83070836
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-16 00:23:48 +00:00
Nextcloud bot
7d54ff5398
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-15 00:23:39 +00:00
Nextcloud bot
4f4be6b0ea
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-14 00:23:26 +00:00
Nextcloud bot
3bcecbdaec
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-13 00:23:10 +00:00
Nextcloud bot
aebc0806fc
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-12 00:23:27 +00:00
Ferdinand Thiessen
324582729a
fix(lookup-server): disable lookup server for non-global scale setups
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 21:54:06 +01:00
Ferdinand Thiessen
aa7300b53d
fix(lookup-server): do not query data by default
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 21:39:33 +01:00
Nextcloud bot
c4a17a6bc8
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-11 00:23:08 +00:00
Joas Schilling
a7cee21ec1 fix(base.php): Correct order for booting \OC\Server
A recent change had broken authentication with an older
FastCGI Apache2 module, because the IRequest object got
initialised before the fix from self::handleAuthHeaders()
copied the authentication headers into the correct $_SERVER
variables.
Since this part is completely independent from any Nextcloud
code it is now done as a first thing within the init() call.

Additionally similar issues could happen when another class
would boot too early and read other global PHP settings like
ini values and default timezone, so those are now also moved
to the beginning.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-03-10 11:34:31 +00:00
Nextcloud bot
e24146d000
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-09 00:23:20 +00:00
Nextcloud bot
f68bda0353
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-08 00:22:25 +00:00
skjnldsv
f00d596b8c fix(systemtags): prevent tag edition if restricted
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

[skip ci]
2025-03-06 15:11:51 +00:00
Nextcloud bot
a157b65d22
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-06 08:26:24 +00:00
Nextcloud bot
0721bea606
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-06 00:23:39 +00:00
Louis Chemineau
fb41438db1 fix(login): Properly target public page with attribute
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-03-05 17:02:26 +00:00
Andy Scherzinger
5c0babe27b
Merge pull request #51251 from nextcloud/backport/50989/stable31
[stable31] fix: Use case insensitive check when validating login name
2025-03-05 17:47:50 +01:00
Marcel Müller
44e89610ed fix: No IFactory in constructor
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2025-03-05 11:34:02 +00:00
Joas Schilling
93f039fb96 fix(files): Don't do session related work in the constructor of the View
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-03-05 11:34:02 +00:00
Cleopatra Enjeck M.
0535716391 fix: use mb_strtolower to convert login name
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
2025-03-05 06:20:07 +00:00
Cleopatra Enjeck M.
90f83ac234 fix: Improve string comparison
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
2025-03-05 06:20:07 +00:00
Cleopatra Enjeck M.
449676be7c fix: Use case insensitive check when validating login name
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
2025-03-05 06:20:07 +00:00
Nextcloud bot
ea24143154
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-05 00:22:51 +00:00
Robin Appelman
0ae944db2c feat: log query for dbal exceptions
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-03-04 15:33:54 +00:00
Andy Scherzinger
eb250fae02
Merge pull request #51197 from nextcloud/fix/51022/simpler-request-pre-upgrade
[stable31] fix(userconfig): simpler db request pre-upgrade
2025-03-04 13:11:20 +01:00
Kate
b0566ad780
Merge pull request #51203 from nextcloud/backport/51194/stable31
[stable31] refactor(TempManager): Simplify and unify implementations and remove legacy behavior
2025-03-04 10:16:24 +01:00
provokateurin
e8b7ddd14e
fix(Share20\Manager): Propagate user and group deletion to remote share providers
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-04 07:57:00 +01:00
provokateurin
64ed0c05dd
fix(Share20): Convert broken hooks to IEventListener
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-04 07:56:59 +01:00
Nextcloud bot
d3530a1859
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-04 00:23:37 +00:00
Maxence Lange
1fac9cfa14 fix(userconfig): simpler db request before 31 upgrade
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-03-03 14:46:41 -01:00
provokateurin
b42d26b42f refactor(TempManager): Simplify and unify implementations and remove legacy behavior
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-03 15:25:00 +00:00
Louis
4e7a3c1f9e
Merge pull request #51090 from nextcloud/backport/51051/stable31
[stable31] feat: Close sessions created for login flow v2
2025-03-03 12:28:48 +01:00
Louis Chemineau
2f71b7e197
fix(login): Support subfolder install for ephemeral sessions
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-03-03 11:00:29 +01:00
Louis Chemineau
ab01b76a19
fix(login): Also check legacy annotation for ephemeral sessions
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-03-03 11:00:29 +01:00
Nextcloud bot
c184c3d32a
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-03 00:23:01 +00:00
Joas Schilling
92bbcada49
Merge pull request #51173 from DaleBCooper/fix-a+-rating
Fix A+ rating when checking with Nextcloud Security Scan.
2025-03-02 11:03:42 +01:00
Nextcloud bot
043f0e6040
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-02 00:22:53 +00:00
DaleBCooper
ed15fdf0a3 Fix A+ rating when checking with Nextcloud Security Scan.
Due to commit 33d7019 session.cookie_secure=true is not set when accessing /status.php.
This results in a degration from A+ to A rating due to missing  __Host prefix for nc_sameSiteCookielax and nc_sameSiteCookiestrict cookies.
2025-03-01 23:57:51 +01:00
Nextcloud bot
fe2cf50496
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-01 00:45:14 +00:00
Nextcloud bot
52163b4905
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-28 00:23:28 +00:00
Joas Schilling
25268f2fdf
Merge pull request #51058 from nextcloud/backport/51049/stable31
[stable31] fix(l10n): Improve english source strings
2025-02-27 16:51:47 +01:00
Louis Chemineau
e840ee72b2 feat: Close sessions created for login flow v2
Sessions created during the login flow v2 should be short lived to not leave an unexpected opened session in the browser.

This commit add a property to the session object to track its origin, and will close it as soon as possible, i.e., on the first non public page request.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-02-27 07:59:49 +00:00
Nextcloud bot
6e52b55555
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-27 00:22:29 +00:00
Louis Chemineau
fe56b3ccc2 fix: Report duplicated extra files in integrity check
The `array_diff` is not comparing the array keys. This means that an extra key with an expected hash will not be reported. Using `array_diff_assoc` will report such files.

For example, copying `status.php` to `status 2.php`, will only be reported with the new version.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-02-26 13:26:38 +00:00
Joas Schilling
1a60bca362 fix(l10n): Improve english source strings
- No leading/trailing whitespace
- Use asci single quote

Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-02-26 13:08:49 +00:00
Andy Scherzinger
3b49ee1c6b
Merge pull request #51034 from nextcloud/backport/48795/stable31
[stable31] feat: support migrating an instance to sharding
2025-02-26 11:05:50 +01:00
Nextcloud bot
4201daaa40
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-26 00:21:55 +00:00
Robin Appelman
ea678c0280 feat: support migrating an instance to sharding
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-25 21:43:54 +00:00
Andy Scherzinger
55b8a6ba13
Merge pull request #50941 from nextcloud/backport/50053/stable31
[stable31] fix: Change UserAgent to *cloud
2025-02-25 18:37:15 +01:00
Louis Chemineau
8a2437927d fix: Initialize lastConnectionCheck after first connection
We are checking whether the DB connection is alive once every 30 seconds. But when we are lacking the last check time, we are skipping the check and reconnect logic. This is causing the reconnect logic to never fire in those cases.

It seems to me that "those cases", are actually always the case, as upon initialization, we are not using the proper connection name to store the time.

In the `connect()` logic, when `$this->_conn` is null, `$this->getConnectionName()` is returning `replica`, so `$this->lastConnectionCheck` will be equal to `['replica' => time()];`

60711ea4cf/lib/private/DB/Connection.php (L215-L221)

60711ea4cf/lib/private/DB/Connection.php (L891-L893)

2b6d7bf65f/doctrine/dbal/src/Connections/PrimaryReadReplicaConnection.php (L136-L139)

Then, if the connection name ends up as being 'primary', the reconnect logic is skipped:

60711ea4cf/lib/private/DB/Connection.php (L874-L880)

Follow-up of https://github.com/nextcloud/server/pull/41819

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-02-25 11:07:34 +00:00
Nextcloud bot
3276012191
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-24 20:39:17 +00:00
Ferdinand Thiessen
06ddb7aff6 refactor: convert sanitize account properties repair step to background job
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-24 15:23:20 +00:00
Ferdinand Thiessen
29e5e8a31b fix: Optimize repair step performance
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-24 15:23:20 +00:00
Ferdinand Thiessen
e9c4c59998 fix: validate account properties as a repair step
Replace `ValidatePhoneNumber` from Nextcloud 21 with a new repair step,
`ValidateAccountProperties` which validates and sanitizes all account
properties.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-24 15:23:20 +00:00
Nextcloud bot
a1f748040a
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-24 00:22:04 +00:00
Nextcloud bot
328d1c24bd
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-23 00:22:08 +00:00
Nextcloud bot
543a01ab89
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-22 00:22:03 +00:00
Johannes Endres
76d4138736 fix: Change UserAgent to *cloud
Co-authored-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Johannes Endres <je@johannes-endres.de>
2025-02-21 09:30:10 +00:00
Benjamin Gaussorgues
4f8eacd3a2 chore(filecache): remove index fs_id_storage_size
Index is outdated by PR 50781

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2025-02-20 08:09:31 +00:00
Nextcloud bot
2afb2156ef
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-20 00:22:18 +00:00
Côme Chilliet
a9ad23e3d8 fix: Also remove digits at the start and underscore on both ends of appid
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2025-02-19 18:39:20 +01:00
Côme Chilliet
adf5b72939 fix: Only keep allowed characters in appid, and flag the method as escaping
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-19 18:39:20 +01:00
Andy Scherzinger
08e3e213d3
Merge pull request #50797 from nextcloud/backport/50781/stable31
[stable31] perf(files): faster query to fetch incomplete directories
2025-02-19 18:38:21 +01:00
Joas Schilling
4b1b16430d fix(cron): Keep job class limitation when searching for the next job
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-02-19 09:28:34 +00:00
Nextcloud bot
4a4cfa00f1
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-19 00:21:52 +00:00
skjnldsv
0823f924c0 fix(files): properly forward open params from short urls
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-18 12:42:23 +00:00
Nextcloud bot
1255a482dd
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-18 00:22:06 +00:00
Git'Fellow
361a6757b1 fix(repair): PHP8.3 deprecation warning
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-02-15 11:10:17 +00:00
Nextcloud bot
d989fd8b5c
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-15 00:22:02 +00:00
Nextcloud bot
ea6bb3755f
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-14 00:22:13 +00:00
Benjamin Gaussorgues
d056e4dc74 perf(files): faster query to fetch incomplete directories
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2025-02-13 14:24:44 +00:00
Nextcloud bot
c7c773b522
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-13 00:21:47 +00:00
Nextcloud bot
1162b63816
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-12 00:22:34 +00:00
Robin Appelman
5eac86afec fix: don't use cached root info from shared cache if the watcher has detected an update
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-11 20:35:46 +01:00
Robin Appelman
e813f3d605 fix: make locked exception path relative to the view
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-11 16:29:43 +00:00
Nextcloud bot
9bfd71df02
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-10 00:21:52 +00:00
John Molakvoæ
1946fdf80d fix: psalm and OCP @since declarations
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2025-02-09 21:09:12 +01:00
skjnldsv
63d9a11575 fix: make sure we process mime extensions as string
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-09 21:09:12 +01:00
Nextcloud bot
8144ab6cc7
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-09 00:21:52 +00:00
Nextcloud bot
b6887083a9
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-08 00:21:50 +00:00
Luka Trovic
57971afad5 feat(admin_audit): write admin audit log for AnyLoginFailedEvent
Signed-off-by: Luka Trovic <luka@nextcloud.com>
2025-02-06 18:27:10 +00:00
Ferdinand Thiessen
e550ad7bbe
fix(FediverseAction): Ensure valid fediverse links are generated
Harden also for existing values of the profile.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-06 15:46:15 +01:00
Ferdinand Thiessen
ac1a448765
fix(AccountManager): Sanitize social media handles
Ensure to only accept valid X and fediverse handles.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-06 15:46:15 +01:00
John Molakvoæ
806e5ac30f
Merge pull request #50675 from nextcloud/backport/50193/stable31
[stable31] fix(oauth2): adjust db schemas when migrating from owncloud
2025-02-06 10:23:29 +01:00
Marcel Klehr
75585be67f fix(TaskProcessing\Manager): Always use distributed cache and use PHP serialize
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-02-06 07:52:04 +00:00
Marcel Klehr
f9450f2d20 fix: lib/private/TaskProcessing/Manager.php
Co-authored-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-02-06 07:52:04 +00:00
Marcel Klehr
ec3660a3c2 fix(TaskProcessing\Manager): Always use distributed cache and use PHP serialize
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-02-06 07:52:04 +00:00
Nextcloud bot
6d850e9e5c
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-06 00:22:02 +00:00
Richard Steinmetz
2c51ff1e3b fix(oauth2): adjust db schemas when migrating from owncloud
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-02-05 21:17:28 +00:00
Nextcloud bot
1688edc222
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-05 00:21:57 +00:00
Nextcloud bot
b4067478aa
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-04 00:21:26 +00:00
Nextcloud bot
aaad1e588b
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-03 00:39:31 +00:00
Nextcloud bot
aca3bca62b
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-01 00:21:56 +00:00
Andy Scherzinger
23cb06dfc1
Merge pull request #50565 from nextcloud/backport/50530/stable31
[stable31] fix(ConvertType): Read dbtype in createConnectionParams and remove safeguard
2025-01-31 16:52:12 +01:00
Nextcloud bot
d0da4db975
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-01-31 00:22:27 +00:00
Nils Wenninghoff
8a6d9ffdc1 fix(ConvertType): Read dbtype in createConnectionParams and remove safeguard
Signed-off-by: Nils Wenninghoff <nils@ungemein.cool>
2025-01-30 10:50:16 +00:00
Louis Chemineau
a56cff70e1 fix: Exclude non accepted shares when computing access list
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-01-30 09:18:41 +00:00
Andy Scherzinger
e8844cacec
Merge pull request #50528 from nextcloud/backport/50494/stable31
[stable31] fix(performance): use low resolution for blurhash
2025-01-29 21:07:52 +01:00
Richard Steinmetz
936ef804cd fix(s3): treat empty sse_c_key as not set
Co-authored-by: Christian Becker <christian@dabecka.de>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-01-29 17:35:52 +00:00
Max
1b34f6ad65 fix(performance): use low resolution for blurhash
Improve blurhash performance by using a low res image.
The results are hard to destinguish visualy.
It is a **blur** hash after all.

Signed-off-by: Max <max@nextcloud.com>
2025-01-29 10:44:15 +00:00
Andy Scherzinger
c99c135520
Merge pull request #50508 from nextcloud/backport/50436/stable31
[stable31] fix: Harden files scanner for invalid null access
2025-01-28 23:52:39 +01:00
Ferdinand Thiessen
26c93519f2 fix: Harden files scanner for invalid null access
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 19:49:03 +00:00
Ferdinand Thiessen
0f298e1db1 fix(sharing): Move permission validation to share manager
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 17:26:28 +00:00
Andy Scherzinger
e7ab2c1598
Merge pull request #50485 from nextcloud/backport/49645/stable31
[stable31] fix(config): drop value details
2025-01-28 10:21:41 +01:00
Nextcloud bot
325e5ee9ac
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-01-28 00:22:21 +00:00
Maxence Lange
578b4ba0ee fix(config): drop value details
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-01-27 17:55:29 +00:00
Andy Scherzinger
bae32be74d
Merge pull request #50468 from nextcloud/backport/50234/stable31
[stable31] fix(ratelimit): Allow to bypass rate-limit from bruteforce allowlist
2025-01-27 18:14:06 +01:00
Dario Mehlich
72a43a17f5 fix(preview): Filter for folders in cleanup old preview job
Fixes #35936.
When running `OC\Preview\BackgroundCleanupJob`, the main iteration loop
in `run()` expects a folder, however, `getOldPreviewLocations()`
currently does not filter by mimetype and therefore can yield a
non-folder entry which causes an Exception when constructing the Folder
impl.
Filtering for `httpd/unix-directory`, as `getNewPreviewLocations()`
already does, fixes this issue.

Signed-off-by: Dario Mehlich <d.mehlich@gmail.com>
2025-01-27 15:11:26 +00:00
Joas Schilling
77fddb8f23 fix(ratelimit): Allow to bypass rate-limit from bruteforce allowlist
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-01-27 13:21:36 +00:00
Joas Schilling
e78cec5d7b fix(log): Fix log level handling
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-01-27 10:23:28 +00:00
Nextcloud bot
d06a26d58b
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-01-27 00:21:51 +00:00
Ferdinand Thiessen
57949b2e22 fix: Ensure label is always a string
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-26 20:00:33 +00:00
Nextcloud bot
b380f25af4
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-01-26 00:22:40 +00:00
Marcel Klehr
35052624b9 fix(TaskProcessing): Cache providersById in getPreferredProviders
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-01-25 13:08:19 +01:00
Marcel Klehr
6e59f9a693 fix: copypasta
Co-authored-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-01-25 13:08:19 +01:00
Marcel Klehr
215f6c6418 fix(taskprocessing): cache provider settings in distributed cache as well
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-01-25 13:08:19 +01:00
Marcel Klehr
8c81f9e0fa fix(TaskProcessing\Manager): Cache the result of parsing JSON
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-01-25 13:08:19 +01:00
Marcel Klehr
e2bef275ec fix(taskprocessing): Cache result of getAvailableTaskTypes between requests
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-01-25 13:08:19 +01:00
Louis Chemineau
5b2af8b4c0 fix: Metadata field search
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-01-25 09:44:50 +00:00
Andy Scherzinger
bb2980e738
Merge pull request #50401 from nextcloud/backport/50368/stable 31 8
[stable31] fix: Properly read updater channel before returning version channel as a fallback
2025-01-25 08:48:32 +01:00
Nextcloud bot
aaeb93782e
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-01-25 00:42:51 +00:00
Julius Knorr
f2ae9bcb11 fix: Properly read updater channel before returning version channel as a fallback
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2025-01-25 01:16:58 +01:00
Marcel Klehr
44aa380ce4 fix(TaskProcessing): Catch JSON encode errors in Manager#setTaskResult
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-01-24 22:15:11 +01:00
Ferdinand Thiessen
99e76d7a99 fix(TemplateLayout): core is not an app but the server itself
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-24 18:12:18 +00:00
Ferdinand Thiessen
ae3e26024e fix: Correctly return app id and app version for core styles and images
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-24 18:12:18 +00:00
provokateurin
9fafcb267c Revert "fix(Share20\Manager): Ensure node is still accessible when checking share"
This reverts commit c2ca99e2f6.

Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-24 09:47:35 +00:00
Nextcloud bot
d99caa2083
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-01-24 00:21:18 +00:00
Anna Larch
3a9713de2c fix: remove typing and return type
Signed-off-by: Anna Larch <anna@nextcloud.com>
2025-01-23 19:28:30 +00:00
Nextcloud bot
36ef0f1add
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-01-23 13:39:42 +00:00
Nextcloud bot
be557caec0
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-01-23 00:21:47 +00:00
Benjamin Gaussorgues
b4e3eff078 feat(systemtags): add setting to block non admin to create system tags
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2025-01-22 20:07:24 +01:00
Ferdinand Thiessen
cddcbd1476
Merge pull request #50083 from nextcloud/bugfix/trim-tags
fix: Trim tags on adding or editing
2025-01-22 18:11:42 +01:00
Nextcloud bot
35b0baa929
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-01-22 00:21:42 +00:00
Ferdinand Thiessen
83a9ed4c44
Merge pull request #50255 from nextcloud/fix/password-validation
fix(sharing): Set correct password context for share password validation
2025-01-21 16:26:05 +01:00
Nextcloud bot
56c45652ba
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-01-21 00:21:03 +00:00
Kostiantyn Miakshyn
faa7cb74b1 fix: Trim tags on adding or editing
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
2025-01-20 20:12:27 +02:00
Ferdinand Thiessen
fb8802a783 fix(sharing): Set correct password context for share password validation
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-20 18:16:24 +01:00
Git'Fellow
8fe9e8c6ab
Merge pull request #50271 from nextcloud/removeWarningRegression
fix(TemplateManager): Remove warning message
2025-01-20 14:39:19 +01:00
Ferdinand Thiessen
27ac8e0f78
Merge pull request #50214 from nextcloud/feat/show-time-diff-user
feat(contacts): Show time difference for users in different timezones
2025-01-20 14:39:00 +01:00
Git'Fellow
dcde6d8d74
fix(TemplateManager): Remove warning message
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-01-20 13:05:28 +01:00
Nextcloud bot
63cd1c120f
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-01-20 00:21:01 +00:00
John Molakvoæ
483e9e8b03
Merge pull request #50240 from nextcloud/fix/conversion-extension 2025-01-19 00:26:27 +01:00
Sebastian Krupinski
307f983431
Merge pull request #49443 from nextcloud/feat/issue-994-two-factor-api
feat: Two Factor API
2025-01-18 19:03:16 +00:00
John Molakvoæ
e5dceaf287
fix: php lint extra tab fix
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2025-01-17 21:37:39 +01:00
skjnldsv
abd3cb60fc fix(files): more conversion tests and translate error messages
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-01-17 18:22:58 +01:00
Nextcloud bot
326120a7f7
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-01-17 00:21:27 +00:00
Elizabeth Danzberger
14976390ff
chore: remove unnecessary method
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2025-01-16 15:25:15 -05:00
Elizabeth Danzberger
f9adb006b0
fix: prevent missing target file extension
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2025-01-16 15:23:38 -05:00
John Molakvoæ
35db02c4f9
Merge pull request #50208 from nextcloud/feat/conversion-adjusting
fix(files): conversion api simplification and conflict check
2025-01-16 19:31:14 +01:00
skjnldsv
7cbcbdc051 fix(files): conversion api simplification and conflict check
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-01-16 18:35:40 +01:00