upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-15 22:11:17 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 25
85506 commits 882 branches 1195 tags 7.2 GiB
Commit graph

73 commits

Author SHA1 Message Date
Carl Schwan
a430702caa
refactor(psalm): Enable psalm for comments unit tests 
This is the first step to enable psalm for our test suite to find issues
also there.

At the moment, this already found some completely broken and unused
method in TestCase and prepare the way for making ICommentsManager work
with snowflake ids by using string instead of int for the ids
consistently.

Signed-off-by: Carl Schwan <carlschwan@kde.org>
 2026-01-07 13:21:33 +01:00
Carl Schwan
3c9b937e28
refactor(comment): Port away from deprecated event comment constant 
Create new events to replace deprecated CommentsEvent constant and use
them when creating CommentsEvents.

On the listener side, we can't yet use these events as deck still send
the old events.

Also fixes some issues reported by psalm level 3 on the comment app.

Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
 2025-12-04 17:38:53 +01:00
Carl Schwan
d73537dd60
Merge pull request #54664 from nextcloud/carl/port-away-execute-lib 
Port away from IQueryBuilder::execute in lib/ and tests/ and fix invalid usage of UniqueConstraintViolationException
 2025-09-02 14:38:11 +02:00
Carl Schwan
c21b8169ff refactor(querybuilder): Port away from qb::execute() in lib/ 
Replace by either executeStatement or executeQuery

Signed-off-by: Carl Schwan <carl.schwan@nextclound.com>
 2025-09-02 11:55:56 +02:00
Joas Schilling
102c778228
fix(comments): Fix missing return type on new method 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-08-28 08:58:52 +02:00
Carl Schwan
94e2af0302 perf(comments): Also cache the comments count 
Since we now have an easy way to fetch the comments count.

Signed-off-by: Carl Schwan <carl.schwan@nextclound.com>
 2025-08-21 11:30:56 +02:00
Carl Schwan
fa5548a1f3 perf(comments): Add a way to get comments for multiple objects at the same time 
Signed-off-by: Carl Schwan <carl.schwan@nextclound.com>
 2025-08-21 11:18:57 +02:00
Joas Schilling
088d6843b7
fix(comments): Adjust interface with implementation 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-07-10 22:03:21 +02:00
Ferdinand Thiessen
5981b7eb51
chore: apply new CSFixer rules 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

# Conflicts:
#	apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
 2025-07-01 16:26:50 +02:00
Joas Schilling
b61a8cfeba
fix(comments): Document supported types and provide psalm typing 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-10-17 14:27:42 +02:00
provokateurin
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-19 14:21:20 +02:00
Daniel Kesselberg
af6de04e9e
style: update codestyle for coding-standard 1.2.3 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2024-08-25 19:34:58 +02:00
Julius Härtl
9713dd3fa9
chore: Move comments event handler to use proper event dispatcher 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2024-06-26 18:13:07 +02:00
Andy Scherzinger
dae7c159f7
chore: Add SPDX header 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2024-05-24 13:11:22 +02:00
Côme Chilliet
ec5133b739 fix: Apply new coding standard to all files 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-02 14:16:21 +02:00
Robin Appelman
eb5832b8fa refactor: depricate getNumberOfUnreadCommentsForFolder and redo it's implementation based on getNumberOfUnreadCommentsForObjects 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-03-07 19:19:07 +01:00
Joas Schilling
42be7a5d74
fix(OCP): Add since tag for all constants 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-02-14 20:50:08 +01:00
Joas Schilling
6056928dc6
feat(comments): Add a meta data column for comments 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-12-14 14:32:00 +01:00
Joas Schilling
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1 
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-11-23 10:36:13 +01:00
Joas Schilling
c3bc575d99
fix(comments): Emit CommentsEntityEvent as typed event 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-07-18 16:19:01 +02:00
Carl Schwan
77355a8a79
Improve typing in ICommentsManager 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2023-06-20 10:55:26 +02:00
Carl Schwan
9725d00329
Cleanup comments code 
- Fix various psalm issues
- Add as much typing as possible while preserving stable API

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2023-06-20 10:55:20 +02:00
Côme Chilliet
f5c361cf44
composer run cs:fix 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-20 11:45:08 +01:00
blizzz
c98e44507d
Merge pull request #32865 from nextcloud/bugfix/remove-unecessary-row 
Remove unecessary row and make compatible with db schema
 2022-07-08 23:11:10 +02:00
Joas Schilling
198224bf7a
Allow to expire comments of multiple objects with one call 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-07-01 15:59:29 +02:00
Vitor Mattos
c59b0c2ff7
Add comments expire date 
https://github.com/nextcloud/spreed/pull/7327

Signed-off-by: Vitor Mattos <vitor@php.rio>
 2022-06-15 11:58:29 -03:00
Vitor Mattos
b9def2f073
Set as optional argument 
Signed-off-by: Vitor Mattos <vitor@php.rio>
 2022-06-13 16:12:35 -03:00
Vitor Mattos
45cdb36d5c
Remove unecessary row and make compatible with db schema 
Signed-off-by: Vitor Mattos <vitor@php.rio>
 2022-06-13 13:35:34 -03:00
Vitor Mattos
8ec7c5c8ae
Update ICommentsManager with reaction methods 
Fix psalm errors
Reorder methods and remove return null
Use best pattern on docblock

Goals: update https://github.com/ChristophWurst/nextcloud_composer/ with reaction methods.
The script
https://github.com/ChristophWurst/nextcloud_composer/blob/master/build.sh
only get lib/public classes

Signed-off-by: Vitor Mattos <vitor@php.rio>
 2022-02-03 12:52:18 -03:00
Joas Schilling
e8c66d0f89
Merge pull request #30794 from nextcloud/techdebt/noid/allow-to-get-comments-with-verb 
Allow to get comments with a given set of verbs
 2022-01-28 16:41:42 +01:00
Joas Schilling
d2833a6552
Fix typo in deprecated 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-01-21 14:34:45 +01:00
Joas Schilling
1ceba64863
Allow to get comments with a given set of verbs 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-01-21 13:42:04 +01:00
Vitor Mattos
9efbc9c1d5
Add comments reactions 
Signed-off-by: Vitor Mattos <vitor@php.rio>
 2022-01-21 08:37:04 -03:00
Joas Schilling
2166cfde9e
Allow to count comments with multiple verbs 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-11-26 12:29:44 +01:00
John Molakvoæ (skjnldsv)
215aef3cbd
Update php licenses 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-06-04 22:02:41 +02:00
Christoph Wurst
4fc0b2c639
Deprecate all remaining event constants 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-02-09 13:53:41 +01:00
Christoph Wurst
d89a75be0b
Update all license headers for Nextcloud 21 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-12-16 18:48:22 +01:00
Joas Schilling
ede7510854
Add a function to get the unread count for multiple objects in one go 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-04 11:01:21 +01:00
Joas Schilling
da3d384426
Fix missing since 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-10-22 12:02:48 +02:00
Joas Schilling
2dd50b4adc
Fix return type 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-10-21 11:02:05 +02:00
Joas Schilling
4b8fec49e7
Add return description 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-10-21 10:05:51 +02:00
Joas Schilling
d462439a63
Get the last comment date for a list of actors (to allow sorting mention suggestions e.g.) 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-10-21 09:18:51 +02:00
Joas Schilling
89651c5233
Allow to search on multiple objects with one query 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-10-21 09:16:42 +02:00
Joas Schilling
326640462b
Add methods to get the number of comments and last comment since a date 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-10-21 09:15:38 +02:00
Joas Schilling
2cc35cc65d
Include an option to also include the lastKnownCommentId object 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-10-21 09:08:48 +02:00
John Molakvoæ (skjnldsv)
3e1916080a
Add ICommentsManager::load method 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2020-10-20 14:39:28 +02:00
Christoph Wurst
d9015a8c94
Format code to a single space around binary operators 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-10-05 20:25:24 +02:00
Julius Härtl
45a474071e
Remove @package annotations from public namespace 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-08-26 16:59:40 +02:00
Christoph Wurst
cb057829f7
Update license headers for 19 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-29 11:57:22 +02:00
Christoph Wurst
28f8eb5dba
Add visibility to all constants 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 16:54:27 +02:00