upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-10 09:13:19 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 54
76734 commits 1040 branches 1221 tags 8.3 GiB
Commit graph

1614 commits

Author SHA1 Message Date
John Molakvoæ
2308294a68 chore: improve hash_file php usage in Local Storage 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
 2024-09-16 17:08:10 +00:00
Louis Chemineau
7c99850958 fix(files): Ensure that the hash method does not return null 
To match beececf660/lib/private/Files/View.php (L1050)

- Fix https://github.com/nextcloud/server/issues/44110

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-09-16 17:08:10 +00:00
Andy Scherzinger
fa355386f7
Merge pull request #47796 from nextcloud/backport/47756/stable30 
[stable30] fix(files): Check if target path is a descendant of the shared folder
 2024-09-15 21:25:30 +02:00
provokateurin
69b01a265c fix(S3ConfigTrait): Allow proxy field to take false 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-15 17:19:40 +00:00
provokateurin
eb3c1a2bee fix(Storage\Local): Do not call getSourcePath() on SplFileInfo 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-15 14:53:34 +00:00
provokateurin
886561761a fix(files): Adjust Cache::searchQuery() parameter name to match interface 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-13 17:02:33 +00:00
Andy Scherzinger
0fc355be58
Merge pull request #47874 from nextcloud/backport/47853/stable30 
[stable30] fix: make swift connect exception message more informative
 2024-09-10 20:58:06 +02:00
Robin Appelman
7206e5e086 fix: make swift connect exception message more informative 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-09-10 14:47:23 +00:00
Julius Knorr
a137eebb82 fix: Only write once to template instead of create/copy 
Signed-off-by: Julius Knorr <jus@bitgrid.net>
 2024-09-10 08:07:26 +00:00
Git'Fellow
2bb8c023c2 fix(files): Check if the target path is a descendant of the shared folder path 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: fix tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: add tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: tests
 2024-09-06 02:00:43 +00:00
Robin Appelman
05f79f23cd fix: write object to the correct urn when moving from another storage to object store 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-09-04 23:17:04 +02:00
provokateurin
b9aaa9f2e0 fix(files): Create non-existent parents of mountpoints 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-04 18:04:13 +00:00
Julius Härtl
2e312e47f4
fix: Do not fail to get internal path on NonExistingFile/NonExistingFolder 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2024-09-03 00:40:03 +02:00
Ferdinand Thiessen
6ea52ed218 fix: Adjust filename validation messages 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-08-30 14:48:23 +02:00
Ferdinand Thiessen
bcd26323c1
fix: Also validate parent path in verifyPath 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-08-28 20:24:03 +02:00
Ferdinand Thiessen
ef3bd03849
fix: Allow read-only filename validation to allow reading files 
Needed to read files with the "Windows compatibility" feature.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-08-28 20:23:54 +02:00
Ferdinand Thiessen
183fcef39b
fix: Renaming does not need update but delete permissions 
Renaming is basically copy + delete (a move), so no need to update permissions.
Especially if the node is in a invalid directory the node should be moveable but not editable.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-08-28 20:23:50 +02:00
Louis Chemineau
e5a8f996bd chore: Apply php:cs recommendations 
Signed-off-by: Louis Chemineau <louis@chmn.me>

[skip ci]
 2024-08-28 14:54:14 +02:00
Robin Appelman
693ee5ea0f fix: hint storage id in more places 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-08-28 14:54:14 +02:00
Robin Appelman
82d7eaf80a feat: implement distributing partitioned queries over multiple shards 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-08-28 14:54:14 +02:00
Ferdinand Thiessen
1e49c83556 fix: FilenameValidator::isForbidden should only check forbidden files 
And not forbidden basenames as this is used for different purposes.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-08-22 08:51:58 +02:00
Robin Appelman
fff198657f fix: use mountpoint from storage to find the encryption keys 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-08-20 14:24:43 +00:00
Robin Appelman
ece54cf956 feat: store the mountpoint of storages in the mount options 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-08-20 14:24:43 +00:00
Andy Scherzinger
609fa7d5db
Merge pull request #47044 from nextcloud/fix/accept-several-mounts-in-encryption 
fix(encryption): Fix mountpoint check to accept if several are found
 2024-08-07 20:58:19 +02:00
Côme Chilliet
277c2cf5d1
fix(encryption): Fix mountpoint check to accept if several are found 
There is no strong requirement to have only one mount for a given
 storage id. Also the error in this case would be misleading.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-08-05 17:34:25 +02:00
Robin Appelman
eb4fb994cf
fix: ensure array returned from getMountsForFileId is continious 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-08-02 17:22:33 +02:00
Christopher Ng
572361f498 fix(files): Fix incorrect keys by reindexing 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2024-08-01 09:14:44 -07:00
Ferdinand Thiessen
21f558b12b
Merge pull request #46379 from nextcloud/fix/folder-search-owner 
fix: `OCP\Files\Node\Folder::search` was not setting the owner
 2024-07-30 13:04:15 +02:00
withbest
dd08f93202 chore: fix some comments 
Signed-off-by: withbest <seekseat@outlook.com>
 2024-07-29 14:43:27 +08:00
Dennis Verspuij
181aecad4c fix: Release directory iterator and thereby its potential directory lock prior to deleting a directory, to avoid e.g. "Text file busy" error with VirtualBox shared folder storage 
Signed-off-by: Dennis Verspuij <6680484+dennisverspuij@users.noreply.github.com>
 2024-07-27 16:37:16 +02:00
Andy Scherzinger
4f2a29adf9
Merge pull request #46672 from nextcloud/fix/preview-invalid-id 
Avoid using partial file info as valid one
 2024-07-25 19:37:30 +02:00
Elizabeth Danzberger
efe03ee690
feat: Add support for filling fields to backend components 
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
 2024-07-25 11:11:40 +02:00
Elizabeth Danzberger
05ed5aa230
fix: Emit new BeforeGetTemplates event 
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
 2024-07-25 11:11:38 +02:00
Julius Härtl
2b0bc8b310 fix: Do not return partial file info if we have a cache entry 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2024-07-22 22:32:34 +02:00
Ferdinand Thiessen
12796c3ae7
fix: FileInfo from View should have the correct name of a mountpoint 
If a mountpoint is returned from a `View` the name must match the view scoped name
and not the global name.
For example group folders have a name like `1` or `2` (the ID),
but the name of the FileInfo returned fro mthe View should be the mount point name,
like `First groupfolder` or similar.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-07-22 22:01:12 +02:00
Ferdinand Thiessen
9716b0d735 refactor: Migrate some legacy and core functions to IFilenameValidator 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-07-19 19:41:46 +02:00
Robin Appelman
c5b687271b
fix: make batch propagator work with sharding restrictions 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-07-17 19:16:07 +02:00
Robin Appelman
0931492ff0
fix: make usermountcache compatible with sharding 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-07-17 19:16:05 +02:00
Robin Appelman
ad88fd07e3
fix: make joining on tags in search queries work with sharding 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-07-17 15:46:39 +02:00
Robin Appelman
80f8c7949e
fix: always set storage id in Cache::get 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-07-17 15:46:31 +02:00
Robin Appelman
5ff7bde3fb
fix: add set storage id for more cache queries 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-07-17 15:46:21 +02:00
Ferdinand Thiessen
69341e4306
refactor: Migrate filename validation logic from Storage to FilenameValidator 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-07-16 12:49:09 +02:00
Ferdinand Thiessen
bdbeabafa7
feat: Add forbidden_filename_basenames config option 
This allows to configure forbidden filenames (the full filename like `.htaccess`)
and also forbidden basenames like `com0` where `com0`, `com0.txt` and `com0.tar.gz` will match.
We need this as only using basenames was too restrictive and will cause problems on some systems when updating.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-07-15 19:39:18 +02:00
Robin Appelman
c82d382a20 feat: add base class for extending the query builder 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-07-12 17:01:39 +02:00
Ferdinand Thiessen
cf935e33ae
fix: OCP\Files\Node\Folder::search was not setting the owner 
The owner was not set on the file info causing e.g. webdav searches to never return the known owner.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-07-11 15:46:44 +02:00
Ferdinand Thiessen
46f1efac41
feat: Add IFilenameValidator to have one consistent place for filename validation 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-07-09 15:04:34 +02:00
Git'Fellow
c84e76a749 fix(s3): Don't wait indefinitely for S3 to return 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: lint

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: use AwsException

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Throw on connection failure

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Wrap all in try catch block

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: use RequestTimeout error message

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

log: use OCP Server class

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Handle connect timeout only

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Handle errors more generically

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2024-07-05 16:24:32 +02:00
Robin Appelman
ffced73a71 fix: also use optimized getFirstNodeyIdInPath for Folder::getFirstNodeById 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-06-20 18:51:27 +02:00
Ferdinand Thiessen
ae1f5cc56d
fix(S3): Adjust usage of guzzle promise 
`Promise\promise_for` was deprecated and is now removed and replaced with the static API (`Create::promiseFor`).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-06-16 15:54:44 +02:00
Robin Appelman
3a60e40a81
Merge pull request #45172 from nextcloud/test-scanner-no-transactions 
feat: add option to disable scanner transactions
 2024-06-13 14:01:34 +02:00