upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-07-15 21:03:00 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 55
56279 commits 1035 branches 1229 tags 8.1 GiB
Commit graph

2803 commits

Author SHA1 Message Date
Roeland Jago Douma
1e111b2ad2
Fix DataResponse typehints 
We use this already in several places where we just pass strings or
numbers.
This all works because we just convert it to a json response in the end.
So better to have the typehints reflect this.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-11-19 20:34:42 +01:00
Roeland Jago Douma
66013f906d
Merge pull request #24189 from nextcloud/enh/csp/frame-ancestors 
Set frame-ancestors to none if none are filled
 2020-11-18 11:29:28 +01:00
Roeland Jago Douma
9163790b7c
Set frame-ancestors to none if none are filled 
frame-ancestors doesn't fall back to default-src. So when we apply a
very restricted CSP we should make sure to set it to 'none' and not
leave it empty.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-11-18 10:13:36 +01:00
Roeland Jago Douma
72a9c35be3
Remove some IRouter methods 
This is not the end. IRouter needs to burn.
But it is a start.

🎵 we didn't start the fire 🎵

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-11-17 14:08:20 +01:00
Joas Schilling
a8cb8e21c1
Add types to function builder 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-16 19:46:24 +01:00
Joas Schilling
d5df033ede
Create primary keys on all tables and add a command to create the afterwards 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-10 15:36:27 +01:00
Joas Schilling
d9e471771a
Update parameters 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-07 14:06:03 +01:00
Joas Schilling
ede7510854
Add a function to get the unread count for multiple objects in one go 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-04 11:01:21 +01:00
Morris Jobke
dc479aae2d
Improve CertificateManager to not be user context dependent 
* removes the ability for users to import their own certificates (for external storage)
* reliably returns the same certificate bundles system wide (and not depending on the user context and available sessions)

The user specific certificates were broken in some cases anyways, as they are only loaded if the specific user is logged in and thus causing unexpected behavior for background jobs and other non-user triggered code paths.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-11-03 00:13:01 +01:00
Roeland Jago Douma
fa6a790859
Remove deprecated OCSResponse 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-11-01 14:12:27 +01:00
Roeland Jago Douma
fe46149560
Psalm fixes 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-10-30 19:27:53 +01:00
Morris Jobke
1654826e83
Merge pull request #23742 from nextcloud/enhancement/eventdispatcher-typed-listener-callable 
Type the event dispatcher listener callables with Psalm
 2020-10-30 09:54:48 +01:00
Morris Jobke
7ed11b6dfa
Merge pull request #23765 from nextcloud/techdebt/noid/sudadmin-events-into-typed-events 
Add typed events for adding and removing a subadmin
 2020-10-29 11:18:01 +01:00
Morris Jobke
5fab33ddc5
Merge pull request #23770 from nextcloud/techdebt/noid/remove-deprecated-isection 
Remove ISection in favor of IIconSection
 2020-10-29 09:00:57 +01:00
Morris Jobke
b9de133e16
Merge pull request #23771 from nextcloud/techdebt/noid/remove-deprecated-inotifystorage-listen 
Remove deprecated INotifyStorage::listen
 2020-10-29 08:58:15 +01:00
Morris Jobke
b8ed997238
Remove ISection in favor of IIconSection 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-10-28 23:05:00 +01:00
Morris Jobke
32e4a61cac
Remove deprecated INotifyStorage::listen 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-10-28 23:02:25 +01:00
Morris Jobke
8218ae4274
Deprecate OCP\Util::connectHook and emitHook 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-10-28 22:30:24 +01:00
Morris Jobke
e4f53ff91b
Add typed events for adding and removing a subadmin 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-10-28 21:55:08 +01:00
Christoph Wurst
b5f75ccdd8
Merge pull request #23746 from nextcloud/enhancement/iusermanager-callforseenusers-typed-closure 
Type the \OCP\IUserManager::callForSeenUsers closure with Psalm
 2020-10-28 20:05:53 +01:00
Christoph Wurst
7e72866811
Type the \OCP\IUserManager::callForSeenUsers closure with Psalm 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-10-28 19:21:00 +01:00
blizzz
6b2cf46125
Merge pull request #23752 from nextcloud/fix/noid/wfe-ux-errors 
inform the user when flow config data exceeds thresholds
 2020-10-28 16:05:35 +01:00
Arthur Schiwon
1eb86e46fd
inform the user when flow config data exceeds thresholds 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-10-28 14:07:14 +01:00
Morris Jobke
ad3063a77b
Merge pull request #23744 from nextcloud/enhancement/appframework-initialstate-typed-closure 
Type the \OCP\AppFramework\Services\IInitialState::provideLazyInitial…
 2020-10-28 14:03:34 +01:00
Christoph Wurst
e8e13c845c
Type the \OCP\AppFramework\Services\IInitialState::provideLazyInitialState closure with Psalm 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-10-28 09:04:15 +01:00
Christoph Wurst
a2206b8cfb
Type the \OCP\IUserManager::callForAllUsers closure with Psalm 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-10-28 08:58:38 +01:00
Christoph Wurst
469ba175ce
Type the event dispatcher listener callables with Psalm 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-10-28 08:54:24 +01:00
Roeland Jago Douma
eadce7fadd
Merge pull request #23601 from nextcloud/techdebt/noid/comments-manager-improvements 
Comments manager improvements/extensions needed by Talk
 2020-10-27 19:57:55 +01:00
Roeland Jago Douma
7949854837
Merge pull request #23712 from nextcloud/enh/noid/add-size-to-file-obj-definition 
Add optional size field for the file obj
 2020-10-27 19:51:31 +01:00
Christoph Wurst
a79ed0653b
Deprecate \OCP\EventDispatcher\IEventDispatcher::dispatch 
As discussed in
https://help.nextcloud.com/t/deprecation-of-ieventdispatcher-dispatch/95381

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-10-27 15:43:07 +01:00
Vincent Petry
f7fd8d520d
Add optional size field for the file obj 
Add optional size field for the file rich object definition.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2020-10-27 11:48:41 +01:00
Joas Schilling
da3d384426
Fix missing since 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-10-22 12:02:48 +02:00
Joas Schilling
2dd50b4adc
Fix return type 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-10-21 11:02:05 +02:00
Joas Schilling
4b8fec49e7
Add return description 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-10-21 10:05:51 +02:00
Joas Schilling
d462439a63
Get the last comment date for a list of actors (to allow sorting mention suggestions e.g.) 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-10-21 09:18:51 +02:00
Joas Schilling
89651c5233
Allow to search on multiple objects with one query 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-10-21 09:16:42 +02:00
Joas Schilling
326640462b
Add methods to get the number of comments and last comment since a date 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-10-21 09:15:38 +02:00
Joas Schilling
2cc35cc65d
Include an option to also include the lastKnownCommentId object 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-10-21 09:08:48 +02:00
John Molakvoæ (skjnldsv)
3e1916080a
Add ICommentsManager::load method 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2020-10-20 14:39:28 +02:00
Christoph Wurst
e646d7d5a9
Add psalm types for the event dispatcher 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-10-15 16:23:26 +02:00
Christoph Wurst
65fb50f9fb
Add psalm types for the migration schema closure 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-10-15 10:58:51 +02:00
Christoph Wurst
f9f20b63f4
Annotate IContainer so Psalm knows what resove and query return 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-10-14 12:29:26 +02:00
Morris Jobke
a70f283734
Merge pull request #23409 from nextcloud/fix/cache-entry-array-access 
The file cache entry is array accessible
 2020-10-13 17:54:21 +02:00
Christoph Wurst
b2de9a6f9e
The encryption decrypt position can be int or string 
The public API said string, internally we treated it as int. In reality
both are used. Let's reflect that in the documented argument type.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-10-13 10:51:22 +02:00
Christoph Wurst
0da89c0fa1
The file cache entry is array accessible 
… so let's make this part of our API. We use it as array already.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-10-13 10:47:00 +02:00
Christoph Wurst
ccfe6a9fa5
Add Psalm type for the bootstrap registration context 
This can potentially catch a few bugs with wrong class strings.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-10-12 15:16:16 +02:00
Christoph Wurst
a1b351036c
Add template typing to the QBMapper 
The QBMapper is kind of a generic type, though this concept does not
exist in php. Hence you have a lot of type coercion in subtypes (mappers
in the individual apps) because you suddenly don't expect an Entity[]
but your specific type.

Luckily Psalm lets us type those. Then in the subclass you can
psalm-implement the mapper with a concrete type and psalm will do all
the magic to ensure types are used correctly.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-10-12 11:10:08 +02:00
Morris Jobke
26a38c4e8a
Job::run() does not return anything 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-10-08 16:52:02 +02:00
Morris Jobke
c1fd22b025
Merge pull request #23144 from nextcloud/enh/noid/update-param-for-psalm 
Less psalm warnings
 2020-10-06 22:07:58 +02:00
Christoph Wurst
d9015a8c94
Format code to a single space around binary operators 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-10-05 20:25:24 +02:00