Commit graph

738 commits

Author SHA1 Message Date
Robin Appelman
5c0fe93498
move teardown logic to SetupManager
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-04 16:29:50 +01:00
Robin Appelman
15ff65c12f
start moving filesystem setup logic to it's own place
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-04 16:29:47 +01:00
Robin Appelman
8b22a463e9
Merge pull request #31266 from nextcloud/root-setup-mountprovider
move root mount setup to mountproviders
2022-03-04 13:44:05 +00:00
Julius Härtl
eede608c0e
Add event logging to app loading
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-02-28 11:24:41 +01:00
Robin Appelman
8b7c8447a0
move root mount setup to mountproviders
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-24 17:21:42 +01:00
Robin Appelman
de260001f1
handle setupFS with null user
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-09 16:01:36 +01:00
Robin Appelman
b799fd40e9
dont mark fs as setup when no user is active
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-09 16:01:31 +01:00
Robin Appelman
1ab58eff0f
pass user object during fs init
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-09 16:01:24 +01:00
Robin Appelman
0217949715
only setup part of the filesystem for appdata requests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-09 16:01:21 +01:00
Claus-Justus Heine
a355410b88
Use the unjailed-path in OC_Helper::getStorageInfo() for files located in SharedStorage.
The current implementation already switches the storage-backend to
$storage->getSourceStorage(). However, it then calls
$rootInfo->getInternalPath() which returns the internal path relative to
the storage where the share is mounted. This is wrong, we need also to
unjail the path. Compare, e.g., with
OCA\Files_Sharing\SharedStorage::file_get/put_contents() for the
"logic".

Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
2022-02-03 10:05:49 +01:00
John Molakvoæ
73e3d06781
Merge pull request #30855 from nextcloud/psalm/theming 2022-01-27 20:04:02 +01:00
Louis Chemineau
04c9de7312 Add deprecation notice to script & addScript func
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-27 11:04:30 +01:00
Carl Schwan
e3a12b3482
Fix psalm issues in theming app
After this change, we are down to only one psalm warning for this app
and related to the Application.php. This also make composer
psam:update-baseline not silently ignore new errors.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-26 14:26:58 +01:00
Carl Schwan
89d109a4d9
Merge pull request #30508 from nextcloud/fix/psaml-bin
Fix psalm not running
2022-01-13 09:51:04 +01:00
Carl Schwan
6312c0df69
Check style update
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-13 00:19:07 +01:00
Joas Schilling
c47406ad3c
Merge pull request #30291 from nextcloud/image-memory-limit
Prevent loading images that would require too much memory.
2022-01-11 13:35:56 +01:00
Joachim Bauch
d3d65e5c88
Prevent loading images that would require too much memory.
For most image formats, the header specifies the width/height.
PHP allocates an image object from that size, even if the actual
image data is much smaller. This image object size is not limited
by the limit configured in PHP.

The memory limit can be configured through "config.php" setting
"preview_max_memory" and defaults to 128 MBytes which should be
enough for most images without filling up all memory.

Signed-off-by: Joachim Bauch <bauch@struktur.de>
2022-01-11 11:44:38 +01:00
Louis Chemineau
d3661c7d38
Deprecate script function
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-08 10:15:48 +01:00
John Molakvoæ (skjnldsv)
806a176a57
Move backgroundjob script after main core scripts
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2022-01-08 10:14:53 +01:00
John Molakvoæ (skjnldsv)
87d0904b6f
Split common vendor chunk
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2022-01-08 10:14:50 +01:00
John Molakvoæ (skjnldsv)
b664aad7ab
Move bundles to /dist
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2022-01-08 10:11:58 +01:00
Valdnet
5cb51916de
l10n: Add a text string to translation
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-12-20 08:52:12 +01:00
Valdnet
bd1264ef7f
l10n: Add <code>
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-12-15 17:50:18 +01:00
Valdnet
4f99385311
l10n: Add <code>
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-12-15 17:47:41 +01:00
Valdnet
ebc3169105
l10n: Separate words and add dots
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-12-15 17:37:00 +01:00
Côme Chilliet
8504f0a59e
Avoid assignment in if clause
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-06 14:26:27 +01:00
Côme Chilliet
ab3a1d5706
Fix typing problems in OC_Image
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-06 14:26:26 +01:00
Côme Chilliet
d537226368
Avoid calling image* methods on boolean
This avoids fatal errors on PHP>=8, and warnings on older versions.
Log should also be clearer.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-06 14:26:09 +01:00
John Molakvoæ
e296417ca2
Merge pull request #29527 from nextcloud/rakekniven-patch-1 2021-12-04 12:08:16 +01:00
John Molakvoæ (skjnldsv)
71a3528510
Allow scripts prioritization based on other apps
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-12-02 20:00:46 +01:00
John Molakvoæ (skjnldsv)
aaad09220d
Remove files_iedavclient
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2021-11-30 14:47:45 +01:00
John Molakvoæ
c624c7eb5d
Merge pull request #29966 from nextcloud/feat/remove-isIE 2021-11-30 14:04:05 +01:00
John Molakvoæ (skjnldsv)
a325141545
Remove isIE and associated legacy scripts
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-11-30 13:03:08 +01:00
MichaIng
0d749b7e9a Remove iconv from dependencies and tests
which is not used anymore since: https://github.com/nextcloud/server/pull/29470

Signed-off-by: MichaIng <micha@dietpi.com>
2021-11-30 02:33:12 +01:00
Vincent Petry
1efdd6ccae
Merge pull request #29632 from nextcloud/fix/26118/imagecreatetruecolor-error
fix imagecreatetruecolor() error
2021-11-19 17:24:50 +01:00
Naoto Kobayashi
6fc8694324 OC_Util::isNonUTF8Locale: fix lint error
Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
2021-11-16 21:05:43 +09:00
Naoto Kobayashi
c42c972ab0 OC_Util::isSetLocaleWorking: fix typo
Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
2021-11-16 00:46:21 +09:00
Naoto Kobayashi
e9b414fbe3 OC_Util: Add fallbacks to check if current locale is UTF8
Using escapeshellcmd to get current locale causes error
if the function is disabled.

Add fallbacks to prevent the error.

Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
2021-11-16 00:40:52 +09:00
Naoto Kobayashi
d2eb5aaa6d Check whether setlocale works only after setlocale
Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
2021-11-14 09:18:59 +09:00
Naoto Kobayashi
455bff5c17 Fix missing setlocale with php 8
When php version = 8, basename('§') does not bug even if LC_ALL is non-UTF-8 locale.
This cause OC_Util::isSetLocaleWorking() to skip setlocale("C.UTF-8").

Fix it by using escapeshellcmd instead of basename.

Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
2021-11-14 09:18:59 +09:00
szaimen
3ac316b77f fix imagecreatetruecolor() error
Signed-off-by: szaimen <szaimen@e.mail.de>
2021-11-10 15:50:15 +01:00
rakekniven
b7d0babcb8
Added dot at end of sentence.
The full message in the UI is composed by a few strings. Therefore the single parts needs an dot at the end.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2021-11-02 22:11:31 +01:00
Côme Chilliet
3631789651
Fix resource usages in OC_Image
This makes sure using resource or GdImage (PHP>=8) behaves the same.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-10-28 17:48:43 +02:00
Joas Schilling
06611e4780
Revert "Fix "never catch" catches in OC_App" 2021-10-25 08:41:56 +02:00
zorn-v
9cb0b8c713 Fix "never catch" catches in OC_App
Need to check another legacy. Need to explicitly add to use or do not forget add slash `\`
2021-10-22 09:29:03 +00:00
Julius Härtl
581862b51b
Merge pull request #29187 from nextcloud/fix/noid/passwordless-app-password-generation 2021-10-13 16:11:22 +02:00
Julien Veyssier
0d2c2ab629
allow null password in UserLoggedInEvent
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2021-10-13 12:37:34 +02:00
Julien Veyssier
de5fea4a00
fix login_credentials->password in session when loging in with apache
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2021-10-13 12:24:32 +02:00
Joas Schilling
4cae2cc06c
Merge pull request #29004 from nextcloud/bugfix/noid/fix-translated-app-details
Fix translated app details
2021-10-13 11:37:22 +02:00
Bjoern Schiessle
664bd5802f add 'supported'-label to all supported apps, also if they are not downloaded yet
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2021-10-06 22:17:50 +02:00