Commit graph

248 commits

Author SHA1 Message Date
Côme Chilliet
7017b3e675
Fix CheckSetupControllerTest following overwrite.cli.url migration
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-16 09:29:12 +01:00
Côme Chilliet
0483064f07 Migrate overwrite.cli.url setup check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-16 09:05:40 +01:00
Côme Chilliet
80d58f0162
Merge pull request #41312 from nextcloud/feat/migrate-code-integrity-check 2024-01-16 09:04:24 +01:00
Côme Chilliet
c998680348
Fix tests in CheckSetupControllerTest
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-15 11:50:48 +01:00
Côme Chilliet
f06b8da249
Migrate code integrity to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-15 11:50:38 +01:00
Côme Chilliet
d1aac16a72
Fix AppDirsWithDifferentOwnerTest
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-15 10:32:26 +01:00
Côme Chilliet
d1f2add10c Migrate PHP imagick module check to new SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 11:28:59 +01:00
Côme Chilliet
d2dbe1c50c
Migrate tests for AppDirsWithDifferentOwner setup check
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-09 09:52:13 +01:00
Côme Chilliet
3d4c4f19b4
Migrate app dir owner check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-08 17:37:14 +01:00
Côme Chilliet
989b5ffbab
Remove unused properties from CheckSetupControllerTest
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-08 15:09:09 +01:00
Côme Chilliet
3f13a1a47e
Migrate opcache check to new SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-08 15:09:09 +01:00
Côme Chilliet
95ea46c99c Merge SQlite warning to existing SupportedDatabase setup check
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-12-07 15:45:27 +01:00
Côme Chilliet
51758117a7
Migrate database pending bigint conversions check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-28 14:07:47 +01:00
Côme Chilliet
6b0d295307 fix(tests) Fix CheckSetupControllerTest
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-27 15:23:52 +01:00
Côme Chilliet
1b547c7db8 Migrate missing primary key database check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-27 15:23:52 +01:00
Côme Chilliet
ad88c04f2d Migrate missing index database check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-27 15:23:52 +01:00
Côme Chilliet
2cb1c0f2dc Migrate missing column database check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-27 15:23:52 +01:00
Joas Schilling
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-23 10:36:13 +01:00
Côme Chilliet
281cbbfa97
Fix tests for apps/settings new section
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-21 17:51:34 +01:00
Louis Chemineau
7984b80a76
Fix sharing settings unit tests
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-11-21 17:32:36 +01:00
Côme Chilliet
ad372869bc
Fix tests for setupchecks
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-20 18:03:15 +01:00
Côme Chilliet
0ebd44abb6 Migrate tests of forwarded for headers check
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-20 11:36:42 +01:00
Côme Chilliet
0107c7ea24 Migrate Forwarded For Headers check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-20 11:36:42 +01:00
Côme Chilliet
fe8b5d47ae
Migrate Bruteforce Throttle check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-13 16:26:59 +01:00
Côme Chilliet
7495236034
Migrate memory_limit check to new SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-13 15:55:46 +01:00
Côme Chilliet
00d3856b92
Revert "Migrate code integrity to SetupCheck API"
This reverts commit aa2d315d95d37b48752d0e92d0ce79913be1d4f1.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:04 +01:00
Côme Chilliet
0fd5ed9854
Migrate 32bit check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:03 +01:00
Côme Chilliet
ac3da13b38
Migrate Freetype check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:03 +01:00
Côme Chilliet
086d3ceecc
Migrate code integrity to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:03 +01:00
Côme Chilliet
147b29fca2
Migrate Randomness secure check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:03 +01:00
Côme Chilliet
ddd13a90d8
Migrate memcache check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:02 +01:00
Côme Chilliet
6911dc30e6
Migrated both file locking checks to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:03 +01:00
Côme Chilliet
f9770b8ef2
Remove duplicate fileinfo PHP module check
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:03 +01:00
Côme Chilliet
3c75075eba
Migrate database transaction level check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:03 +01:00
Côme Chilliet
5957a2bf6b
Migrate email test to new SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:02 +01:00
Côme Chilliet
506f3961ec
Remove duplicated ReadOnlyConfig setup check
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:02 +01:00
Côme Chilliet
dec52f6979
Migrate getenv test to new SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:02 +01:00
Côme Chilliet
d551a0d886
Adapt CheckSetupControllerTest to the migration to a setup check
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-24 15:36:09 +02:00
Côme Chilliet
0c346849f3
Migrate missing PHP modules check to new API and improve it
Test all modules listed as required in our documentation

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-19 15:58:45 +02:00
Côme Chilliet
6bc3e008c7
Fix tests for setup checks
Had to remove tests for migrated checks, we should add tests for each
 SetupCheck class later on.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-19 11:44:02 +02:00
Valdnet
be6c889414 Correct typos and add quotation marks
Corrects typos and unifies spelling for "occ" commands.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2023-10-11 01:51:39 +02:00
Côme Chilliet
0a9371f99f
Migrate applications away from deprecated ILogger
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-21 11:57:21 +02:00
Anna Larch
7f11ee8c4a fix(CardDAV): only run upgrade sync if 1000 users or less
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-08-26 17:21:50 +02:00
Joas Schilling
bed3ffb312
feat(admin): Show an error when the admin is throttled
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-21 16:40:24 +02:00
Joas Schilling
ab70bbd3ff
fix(db)!: Remove private legacy event because we can not keep it
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-24 14:51:35 +02:00
Julius Härtl
925bcebcb6
feat: Add public event for missing indices
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-07-14 13:11:22 +02:00
Daniel Kesselberg
5a23b429dd
feat: remove check for OpenSSL 1.0.1d and 1.0.2b
OpenSSL 1.0.1d: 2013-02-05
OpenSSL 1.0.2b: 2015-06-11

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-06-04 18:44:47 +02:00
Simon L
e2ab9bf4af address review and fix tests
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-04-18 11:33:53 +02:00
Simon L
80645a591a add an admin check for db file locking
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-04-17 12:51:33 +02:00
jld3103
d9f8522003
Fix types for reading and writing config values
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-04-05 09:08:56 +02:00
julia.kirschenheuter
0cfbe54a5a Create headings for settings pages
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-03-07 17:51:19 +01:00
Côme Chilliet
dde5c46a3e
Migrate to Symfony Mailer
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-02 10:30:06 +01:00
Joas Schilling
348454cb91
Merge pull request #35876 from bennet0496/patch-mail-header
Adding option to set Auto-Submitted email header
2023-01-04 09:34:14 +01:00
Bennet Becker
5a1cc8de9b
update usages of AutoSubmittedValue to AutoSubmitted::VALUE_
Signed-off-by: Bennet Becker <dev@bennet.cc>
2023-01-03 15:28:43 +01:00
Côme Chilliet
b843d09810
Fix typing errors in settings tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-02 15:13:00 +01:00
Bennet Becker
eec1ebb848
Updating unit test for NewUserMailHelper, to test for autosumbitted
header

Signed-off-by: Bennet Becker <bbecker@pks.mpg.de>
2022-12-23 19:27:09 +01:00
Vincent Petry
f9ea078e27
Add unit test for case insensitive email saving
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-12-16 17:47:42 +01:00
Carl Schwan
f244406ebd Update composer autoloader
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-11-22 13:35:17 +01:00
Carl Schwan
e35bcc9381 Fix tests
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-11-22 10:06:19 +01:00
Côme Chilliet
68363f6944
Fix some more problems with tests under PHP 8.2
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-15 16:02:24 +01:00
Côme Chilliet
72f4b34ad5
Fix tests depending on a trailing whitespace
Many editors remove trailing whitespaces, so avoid depending on them for
 tests success.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-15 10:31:58 +01:00
Côme Chilliet
c79a6b3f62
Fix errors from PHP 8.2 testing
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-14 17:08:21 +01:00
Christopher Ng
98bc98ac98 Add profile config migration
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-09-01 15:27:37 +00:00
Simon L
9dbcf0560f
Merge pull request #33200 from nextcloud/enh/noid/64bit
add a setup check for 64 bit
2022-07-13 20:19:40 +02:00
Carl Schwan
4e0574e184 Port encryption admin settings to vue
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-13 14:58:55 +02:00
szaimen
cf9b1082ed add a setup check for 64 bit
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-07-13 09:33:33 +00:00
Louis Chemineau
347ca20f4e Rename setting name to reduce its length
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-06-27 11:04:17 +02:00
Côme Chilliet
c0c54b20d9
Remove deprecated at() matcher from settings tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-06-07 10:05:18 +02:00
Pytal
e647b9fa49
Merge pull request #32443 from nextcloud/port/background-job-admin 2022-05-20 09:58:13 -07:00
Carl Schwan
e8e0f97c9a Port BackgroundJob admin settings to vue
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-20 15:00:54 +02:00
Carl Schwan
9d5a542a4e Improve two factor admin settings
- Port more of it to vue
- Use new nextcloud vue components for the setting section
- Add a bit of spacing between the elements

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-20 13:27:55 +02:00
Louis Chemineau
80fa3c7319 Add setting to ignore email during search
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-05-03 17:50:29 +02:00
Vincent Petry
78c8e57896
Fix migrators according to exceptions
Fixed syntax errors.
Removed if condition for copyToFolder since it's void now.
Change signature of setMigratorVersions to also be void.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-04-13 16:52:40 +02:00
Louis Chemineau
37f1c8640e Add settings to ignore second display name in search
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-04-12 17:27:59 +02:00
Vincent Petry
4626bfbc83
Merge pull request #31927 from nextcloud/feat/dont_match_userid_tests
Tweak tests to include shareapi_restrict_user_enumeration_full_match_userid
2022-04-12 09:43:02 +02:00
Pytal
209a2a6a4b
Merge pull request #31866 from nextcloud/test-avatar-migration 2022-04-11 10:45:40 -07:00
Côme Chilliet
eed6330b92 Adapt AccountMigratorTest to id change
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-04-11 13:59:27 +00:00
Louis Chemineau
a1ff0f368d Tweak tests to include shareapi_restrict_user_enumeration_full_match_userid
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-04-11 12:51:19 +02:00
Christopher Ng
8e7372df44 Add comment explaining avatar basename
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-04-08 18:03:33 +00:00
Christopher Ng
6e62c3ddc5 Remove unnecessary array_diff
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-04-08 18:02:49 +00:00
Christopher Ng
32fc848fcf Test avatar migration
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-04-07 00:44:06 +00:00
Christopher Ng
3fb420115d Improve strictness of account file regex
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-04-07 00:24:48 +00:00
Pytal
9644b7e505
Merge pull request #31852 from nextcloud/test-account-migrator 2022-04-06 11:42:08 -07:00
Christopher Ng
8aa9ea7402 Test migration of account information
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-04-06 02:11:13 +00:00
Carl Schwan
a29251e02d Allow to disable password policy enforcement for selected groups
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Co-authored-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-04-05 17:04:17 +00:00
Christopher Ng
108abd77ed Add profile default setting for admin
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-03-18 02:55:12 +00:00
Christopher Ng
1fc0b4320c Add global profile toggle config
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-03-18 02:55:12 +00:00
szaimen
351357047a fix drone tests on master
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-03-11 20:45:26 +01:00
szaimen
3c8f8bc70a fix tests
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-03-07 18:07:45 +01:00
MichaIng
5ac91f1cb8 Add Nextcloud docs link to OPcache recommends
A link to the Nextcloud documentation is currently only shown when the OPcache module is not loaded at all. This commit moves the link to the generic text above the individual recommendations list.

Additionally remove the obsolete phpOpcacheDocumentation entry from test data arrays, which is not passed anymore by the backend.

Signed-off-by: MichaIng <micha@dietpi.com>
2022-03-03 23:00:07 +00:00
Arthur Schiwon
b28aa52b28
Setup warning for invalid LDAP user or group UUIDs.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-02-10 10:15:01 +01:00
szaimen
fa1ee8f0c7 fix tests
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-02-03 20:41:12 +01:00
Carl Schwan
7619dceff4
Fix tests with email templates
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-18 20:56:50 +01:00
MichaIng
82c1beaacb Enhance and complement OPcache setup checks
The current OPcache recommendations match the PHP defaults, but the values are much higher than required to run Nextcloud, even with a high number of installed apps. On the other hand, when other applications use the same OPcache instance, the recommended values might not be sufficient. Accurate recommendations need to take into account actual OPcache usage.

With this commit, recommendations are shown to raise the config value if more than 90% of max cache size or number of keys is used.

The checks whether the module is loaded and whether the OPcache is properly configured have been merged into a single function. This allowed to reduce the overhead of OPcache configuration checks when the module is not loaded.

A check has been added whether Nextcloud is permitted to use the OPcache API. Without this, inconsistencies during core or app upgrades may cause errors and OPcache usage cannot be determined for the new usage based checks.

OPcache usage based checks are skipped when Nextcloud is not permitted to use the API.

Signed-off-by: MichaIng <micha@dietpi.com>
2021-12-19 23:38:21 +01:00
Côme Chilliet
dc8b79c4d2
Fix OCA\Settings\Tests\Settings\Admin\SharingTest
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-16 09:43:30 +01:00
Joas Schilling
c6ae53096c
More test fixing
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-01 22:17:19 +01:00
Joas Schilling
e8f7a08e52
ArgumentCountError: Too few arguments to function OCA\Settings\Controller\CheckSetupController::__construct()
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-09 15:13:24 +01:00
Joas Schilling
24935666e8
PHPUnit\Framework\MockObject\DuplicateMethodException: Cannot stub or mock using a method list that contains duplicates:
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-09 15:13:24 +01:00
Joas Schilling
19d070850b
Make sure trusted_proxies is an array
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-09 15:13:24 +01:00
Julien Veyssier
facb50ebcc
fix appstoreenabled check in Fetcher so it's coherent with AppSettingsController
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2021-10-18 12:39:43 +02:00