Carl Schwan
aafaa39515
Multiple fixes
...
- Fix tests
- Use non deprecated event stuff
- Add a bit of type hinting to the new stuff
- More safe handling of instanceOfStorage (share might not be the first
wrapper)
- Fix resharing
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-03 13:24:38 +02:00
Vincent Petry
e959b57c31
Inherit hide download from share attributes
...
When resharing by link, if the download permission was removed through
share attributes, convert it to the hide download flag.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-03 13:24:20 +02:00
Vincent Petry
cc7564758b
Fix view-only code after code review comments
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-03 13:24:20 +02:00
Vincent Petry
9e59a6a731
Attempt to fix sqlite json issue
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-03 13:24:19 +02:00
Vincent Petry
cf3d92015b
Fix share attribute related tests + code style
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-03 13:24:19 +02:00
Vincent Petry
f1ab964819
Add share attributes + prevent download permission
...
Makes it possible to store download permission
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-03 13:24:13 +02:00
Julien Veyssier
933bd27ea9
don't reduce file public link permissions if public upload is not enabled
...
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2022-08-02 14:56:59 +00:00
Louis Chemineau
82fea7d000
Rename setting name to reduce its length
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-06-28 09:55:45 +00:00
Louis Chemineau
11bd644251
Use email settings in DAV search
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-05-12 15:05:10 +02:00
Louis Chemineau
55fda0b769
Use share setting in DAV search
...
shareapi_restrict_user_enumeration_full_match_ignore_second_display_name was introduced to ignore second display name during search from the share panel. But this setting was not respected by search from the calendar application. This fix it.
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-05-12 15:05:05 +02:00
Vincent Petry
82f1344d33
Adjust settings for mail link password
...
Rename the settings and invert the meaning.
Increase default interval to one hour.
Changed the interval to be a number of seconds, to align with other
setting styles.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-04-14 14:13:47 +02:00
Vincent Petry
2c2b238008
Default to permanent link passwords
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-04-13 16:11:15 +02:00
Vincent Petry
f5c8fa4f11
Properly reset pw expiration
...
When requesting a new password for share by mail link, now we correctly
reset the expiration date.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-04-13 15:46:30 +02:00
Vincent Petry
483741ff36
Merge pull request #31220 from nextcloud/enhancement/31005/temporary-passwords
...
Temporary passwords for public non-anonymous protected shares (ie: files shared with an email recipient).
2022-04-12 09:46:31 +02:00
Cyrille Bollu
c6a5c07041
Adds a "Request password" button to the public share authentication page for shares
...
of type TYPE_EMAIL, when the "video verification" checkbox isn't checked. Users accessing
non-anonymous public shares (TYPE_EMAIL shares) can now request a temporary password themselves.
- Creates a migration step for the files_sharing app to add the 'password_expiration_time'
attribute to the oc_shares table.
- Makes share temporary passwords' expiration time configurable via a system value.
- Adds a system config value to allow permanent share passwords
-Fixes a typo in a comment in apps/files_sharing/src/components/SharingEntryLink.vue
See https://github.com/nextcloud/server/issues/31005
Signed-off-by: Cyrille Bollu <cyrpub@bollu.be>
2022-04-11 21:58:24 +02:00
Vincent Petry
0b8582f315
Merge pull request #31610 from nextcloud/shares-in-folder-mounts
...
fix shared mount roots not being returned from `getSharesInFolder`
2022-04-11 10:44:47 +02:00
Vincent Petry
b8b4d247b4
Merge pull request #31194 from nextcloud/feat/allow-to-exclude-groups-from-password-enforcement
...
Allow to disable password policy enforcement for selected groups
2022-04-06 10:13:23 +02:00
Carl Schwan
a29251e02d
Allow to disable password policy enforcement for selected groups
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Co-authored-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-04-05 17:04:17 +00:00
Robin Appelman
e83ad8cfad
fix shared mount roots not being returned from getSharesInFolder
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-31 17:25:56 +02:00
Côme Chilliet
6be7aa112f
Migrate from ILogger to LoggerInterface in lib/private
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-24 16:21:25 +01:00
Carl Schwan
6312c0df69
Check style update
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-13 00:19:07 +01:00
Julius Härtl
5116bf146f
Allow to pass note when creating a share and send it with directly in the share mail when set
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-12-03 10:17:02 +01:00
Côme Chilliet
ee7ef77808
Fix warning about passing null to substr_count
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:29:00 +01:00
Joas Schilling
fa036b2001
Move common logic to share manager
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-09 10:10:53 +01:00
JanBartels
9068fd4a21
Patch for master-branch
2021-10-18 21:41:01 +02:00
John Molakvoæ
b585cf1ea1
Merge pull request #26688 from nextcloud/enh/better-share-exceptiondebug
2021-10-13 11:40:59 +02:00
Hinrich Mahler
961f8958c0
Let users choose a share_folder
2021-09-06 16:39:11 +02:00
John Molakvoæ (skjnldsv)
18f8fabd5a
Add proper message to created share not found
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-08-18 12:47:11 +00:00
szaimen
4570bb4f65
Admin Audit - Sharing: createShare - report the full path
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2021-07-22 14:20:05 +00:00
Gary Kim
b78f3a57d1
Migrate HintException to OCP
...
Signed-off-by: Gary Kim <gary@garykim.dev>
2021-06-30 15:28:02 -04:00
Louis Chemineau
be42a13235
Fix share activity dispatch
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2021-06-16 10:11:54 +02:00
John Molakvoæ (skjnldsv)
215aef3cbd
Update php licenses
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +02:00
Morris Jobke
dc9bdd4f39
Use noreply@ as email address for share emails
...
Fixes #26683
Before it used the instance name, which a) doesn't make sense to randomly guess email addresses and b) could contain characters that are not allowed in email addresses like spaces.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-05-28 11:13:24 +02:00
Morris Jobke
f1dbabd910
Merge pull request #26727 from nextcloud/group-exclude-link-share
...
Add option to exclude groups from creating link shares
2021-05-21 15:35:39 +02:00
szaimen
35d978c2fc
Rename External storages to External storage
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2021-05-20 12:13:04 +02:00
Valdnet
e7648c2fdd
l10n: Unify spelling
...
Spelling unification in Nextcloud applications.
2021-05-20 09:26:38 +02:00
Valdnet
11dc65869d
l10n: Unify spelling
...
Spelling unification in Nextcloud applications.
2021-05-20 09:26:37 +02:00
Robin Appelman
0e6321957d
allow excluding groups from creating link shares
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-05-12 16:11:31 +02:00
Joas Schilling
2b8e47dcac
Correclty use plural for share exception
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:43:40 +02:00
Vincent Petry
af61486aea
Separate settings for remote share expiration
...
Added separate settings for default and enforced expiration date for
remote shares.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:06:09 +02:00
Vincent Petry
8680bafc5c
Implement expiration date for federated shares
...
Add expiration date field in UI.
Save expiration date when creating or updating federated share.
Read expiration date from DB in federated share provider.
Applies to both federated user and group shares.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:02:00 +02:00
Arthur Schiwon
be3ae9a44b
gracefully handle deleteFromSelf when share is already gone
...
- handling race conditions
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-30 12:59:40 +02:00
Morris Jobke
1eb084cfd3
Merge pull request #25498 from Worteks/feat-federatedfilesharing-logging
...
feat(federatedfilesharing): log errors, as suggested by @maxbes
2021-03-22 21:21:53 +01:00
John Molakvoæ (skjnldsv)
15767643f2
Fix sharebymail tests
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:50:47 +01:00
Daniel Calviño Sánchez
f99876997a
Remove duplicated query for email shares
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-22 06:50:47 +01:00
John Molakvoæ (skjnldsv)
a100186e5e
Sharing link & mail parity
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:50:45 +01:00
Roeland Jago Douma
1286848731
Merge pull request #23718 from nextcloud/already-shared-error-message
...
expand 'path is already shared' error message
2021-03-19 13:39:22 +01:00
Vincent Petry
a9e3d2a10f
Update user share must use correct expiration validation
...
Updating a user or group share now uses the correct method for the
validation of the expiration date. Instead of using the one from links
it uses the one for internal shares.
To avoid future confusion, the method "validateExpirationDate" has been
renamed to "validateExpirationDateLink".
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-18 17:12:28 +01:00
Vincent Petry
e559afb8d4
Merge pull request #25136 from nextcloud/cachejail-search-filter
...
do cachejail search filtering in sql
2021-03-15 17:45:30 +01:00
Robin Appelman
a550649708
expand 'path is already shared' error message
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-15 15:55:08 +01:00