Add config option shareapi_bundle_reshare_with_edit to include reshare
permission in "Allow editing" bundle. Default is true to maintain
backward compatibility.
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Remove PERMISSION_SHARE from bundled permissions for ALL and ALL_FILE.
Update quick share selector to consistently strip share permission
when comparing, ensuring backwards compatibility with existing shares.
Signed-off-by: nfebe <fenn25.fn@gmail.com>
When `showFederatedSharesToTrustedServersAsInternal` is enabled, the
trusted server filter was incorrectly applied to both internal and
external sharing sections. This prevented users from sharing with
federated users on non-trusted servers via the external share UI.
The filter now only applies to the internal section, allowing
non-trusted federated shares to appear in the external section.
Fixes: https://github.com/nextcloud/server/issues/56622
Signed-off-by: nfebe <fenn25.fn@gmail.com>
This API was deprecated in Nextcloud 23.
It was replaced with `OCA.Sharing.ExternalShareAction` which now have a proper API
by using `registerSidebarAction` from `@nextcloud/sharing` instead.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
When `show_federated_shares_to_trusted_servers_as_internal` is enabled
but `show_federated_shares_as_internal` is not, filter federated share
suggestions to only include trusted servers. Previously, searching for
an email address would suggest non-trusted federated servers.
Resolved: #54511
Signed-off-by: nfebe <fenn25.fn@gmail.com>
This fixes apps providing vue components, which is invalid and does not
always work - and never work with Vue 3.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
`newPassword` is the unsaved password, while `share.password` is the
current saved password.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
1. Use correct color
2. Do not mix legacy icon classes with MDI icons this will show two
icons...
3. Use proper aria label and put status into the title
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
This removes:
- “enable” for settings
- “settings” for settings sections
- “all” when there is no obvious subset of items
- “show” and “open” for navigation actions
- “changes” for applying/discarding
- “to clipboard” when copying
- Explaining things that cannot happen
- Explaining things twice, right below each other
- Unnecessary technical jargon
- Text that sounds like marketing copy and serves no other purpose
Signed-off-by: kramo <git@kramo.page>
- if this is a GS instance
- or was configured by administrator
Then show the share as internal (remote and remote group shares).
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
- resolves: https://github.com/nextcloud/server/issues/52497
Ensure that when global scale is enabled the federated users are shown
just like internal users.
Meaning no server part but instead use the email address like with internal.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
We need to save the previous state - here the password - so that if the
update fails we can revert the shown state.
This happens e.g. if you have the password policy app and try to add an
unsecure password.
To reproduce (with password policy):
1. Create new link share
2. enable password protection
3. use insecure password like `1234`
4. save share
Now you see that the update failed, but the password protection is still
enabled. This happened because `password` and `newPassword` were
misused. `password` was already set when `newPassword` was not saved so
we could not know to what we need to reset when the update failed.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
The title is already escaped by vue so special characters would result
in incorrect strings.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
- Fix autoloading for new `ConfigLexicon`
- Ensure that sharing input in sharing tab respect `show-federated-shares-as-internal`:
This is important, because when federated shares are shown as internal the users should add them from the internal shares section
Signed-off-by: nfebe <fenn25.fn@gmail.com>
If the time picker component is emitting a Date object already, then there is redundant call of `new Date(new Date())` and
therefore introduces subtle bugs, for example on chrome users could not enter expiration date with keyboard.
- Use @update:model-value instead of @change/@input for more reliable date updates
- Ensure null and invalid dates are handled correctly in onExpirationChange
- Validate date input before updating defaultExpirationDateEnabled
Resolves : https://github.com/nextcloud/server/issues/51875
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Since `ShareEntryLink` component is used to both create and display/list the share links,
we should only set default expiration date on `share.expireDate` when we know is a new share.
Otherwise, we overidding data from the backend.
Signed-off-by: nfebe <fenn25.fn@gmail.com>
