upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-08 18:46:28 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 9
67463 commits 874 branches 1195 tags 6.6 GiB
Commit graph

1298 commits

Author SHA1 Message Date
Arthur Schiwon
997efe44ff
Merge pull request #37943 from nextcloud/fix/fix-getcontent-return-type 
Fix file_get_content signatures to make it clear it can return false
 2023-05-03 10:34:51 +02:00
Simon L
4dfadcabb9
Merge pull request #38014 from nextcloud/norm-logic 
Normalize logical operators
 2023-05-02 16:27:58 +02:00
Git'Fellow
951c5b973e
Normalize logical operators 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2023-05-02 10:10:02 +02:00
Robin Appelman
f5e2b0b22f
allow storing multiple mounts for the same rootid in the mount cache 
currently `[$userId, $rootId]` is used as the unique key for storing mounts in the mount cache,
however there are cases where the same rootid is mounted in multiple places for a user which currently leads to not all of those mounts being added to the cache.

Previously this didn't matter as the mount cache was only used to list users with access to a specific file, so a user having access to the file multiple times didn' change anything.

With 24 the mount cache is used for more cases and multiple mounts for the same id becomes relevant.
While I think there isn't a real negative effect atm besides missing the optimized path we should ensure that the mounts are properly listed

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-28 15:08:08 +02:00
Côme Chilliet
546d94c3ec
Fix file_get_content signatures to make it clear it can return false 
In File::getContent, which must return a string, throw an Exception
 instead of returning false.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-27 09:56:05 +02:00
Robin Appelman
d60172567f
Merge pull request #37818 from nextcloud/dav-ext-storage-log 
debug log requests made by dav external storage/shares
 2023-04-25 14:12:57 +02:00
Carl Schwan
b1ec7ff51f
Add missing taint analysis docblock comments, and improve escaping in some methods 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-24 17:17:53 +02:00
Robin Appelman
05dc96f60d
debug log requests made by dav external storage/shares 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-24 17:13:20 +02:00
Robin Appelman
4953296b9e
Merge pull request #36857 from nextcloud/scan-repair-unencrypted-size 
fix unencrypted_size for folders when scanning the filesystem with encryption enabled
 2023-04-24 15:24:50 +02:00
Robin Appelman
0ac7230b7f
Merge pull request #37820 from nextcloud/parent-storage-mtime-ignore-error 
ignore errors while trying to update parent storage_mtime
 2023-04-21 19:11:27 +02:00
Robin Appelman
4cc5885615
Merge pull request #37062 from nextcloud/free-space 
Check free space only if source exists and is dir
 2023-04-21 13:55:42 +02:00
Robin Appelman
4b52dafbf9
ignore errors while trying to update parent storage_mtime 
in the worst case this should only cause an extra rescan later

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-20 17:16:03 +02:00
Côme Chilliet
b294edad80
Merge branch 'master' into enh/type-iconfig-getter-calls 
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
 2023-04-20 16:52:38 +02:00
Simon L
855e7a2efb
Merge pull request #36774 from nextcloud/bugfix/noid/sabre-nodes 
fix: always use proper path on node api when calling the view
 2023-04-18 04:11:44 +02:00
Simon L
45a0fe490c
Merge pull request #37534 from Rsplwe/master 
Adjust the value of the "max-parts" parameter of the object storage 'ListPart' interface to 1000
 2023-04-18 00:16:38 +02:00
Julius Härtl
160bd75d0a fix: Use proper path when creating node instances 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-04-17 23:46:52 +02:00
Simon L
85c9e75f33
Merge pull request #32314 from nextcloud/object-mkdir-logging 
additional logging when mkdir fails for object storage
 2023-04-17 23:42:08 +02:00
Thomas Citharel
036cd47bf4 Put Mimeloader insertion and read in the same transaction 
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2023-04-17 13:32:02 +00:00
Julius Härtl
eecd4601ac
Merge pull request #37429 from nextcloud/object-store-rmdir 
improve objectstore rmdir handling
 2023-04-13 18:45:12 +02:00
Arthur Schiwon
ec1acb92c7
Merge pull request #37617 from nextcloud/notify-self-test-error 
handle not being able to write file for notify self-test
 2023-04-11 19:43:41 +02:00
Vincent Petry
9f05eff3ef
Merge pull request #34607 from nextcloud/encryption-size-not-found 
fix encryption wrapper filesize for non existing files
 2023-04-06 18:04:44 +02:00
Robin Appelman
570b64aafc
handle not being able to write file for notify self-test 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-06 11:52:22 +02:00
Robin Appelman
03e965a513
Merge pull request #22943 from nextcloud/scanner-no-access-handling 
improve handling of files we can't access in the scanner
 2023-04-05 21:36:21 +02:00
Robin Appelman
c6be96d04f
additional logging when mkdir fails for object storage 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-05 14:52:19 +02:00
Robin Appelman
b1f352c614
improve handling of files we can't access in the scanner 
instead of erroring, remove the items from the cache.

this situation can be triggered if a user has access to a file but looses it afterwards

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-05 14:44:55 +02:00
Robin Appelman
54f61352f0
better error messages if the users home is not writable during scanning 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-05 13:21:30 +02:00
Côme Chilliet
426c0341ff
Use typed version of IConfig::getSystemValue as much as possible 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-05 12:50:08 +02:00
Côme Chilliet
8f550398c4
Merge pull request #36836 from nextcloud/fix/view-type-cleanup 
Tidy up typing in OC\Files\View
 2023-04-05 10:14:55 +02:00
Côme Chilliet
6633b4ced6
Remove unecessary fully qualified namespaces from phpdoc 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-05 09:13:39 +02:00
Robin Appelman
5267a74027
fix type hints 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-04 17:05:45 +02:00
Robin Appelman
8c9197d65e
fix unencrypted folder size when no children with unencrypted size set are left 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-04 16:48:11 +02:00
Robin Appelman
649bed5154
fix unencrypted_size for files when scanning 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-04 16:48:11 +02:00
Robin Appelman
63fb33538c
fix unencrypted_size for folders when scanning the filesystem with encryption enabled 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-04 16:48:10 +02:00
Robin Appelman
15a6920b07
fix encryption wrapper filesize for non existing files 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-04 16:21:17 +02:00
Robin Appelman
d63fa2d991
improve objectstore rmdir handling 
remove folder entries as they are cleared instead of in one go afterwards

otherwise they stick around if some of the child entries can't be removed

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-03 18:28:29 +02:00
Robin Appelman
5024f295dc
Merge pull request #36097 from nextcloud/path-prefix-optimize 
extend path-prefix optimizer to remove all cases of path_hash= when encountering a path prefix filter
 2023-04-03 16:39:49 +02:00
Rsplwe
5c6f35832c
Update lib/private/Files/ObjectStore/S3.php 
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Rsplwe <i@rsplwe.com>
 2023-04-03 21:59:59 +08:00
Côme Chilliet
5ad045619c
View needs to return an instance of OC\Files\FileInfo explicitely 
Applications are calling methods from the class which are not from the
 public interface, and which cannot be added easily to public interface
 because Node interface extends FileInfo.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:35 +02:00
Côme Chilliet
0b3dad895f
More type cleanup in View and FileInfo 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:35 +02:00
Côme Chilliet
ea05544213
Fix return type of methods returning false on error 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:34 +02:00
Côme Chilliet
f974281ac9
Improve typing for fopen/toTmpFile 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:34 +02:00
Côme Chilliet
4393b96542
Remove unused method getLocalFolder 
It’s not used and not in any OCP interface/class.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:34 +02:00
Côme Chilliet
966a3e6963
Tidy up typing in OC\Files\View 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:33 +02:00
jld3103
dcf6ebebab
Fix inherited parameter names 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-04-03 08:29:33 +02:00
Robin Appelman
c9e4e30523 clear encrypted flag when moving away from encrypted storage 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-01 15:36:37 +00:00
Rsplwe
d85e623916
s3: get remaining truncation part 
Signed-off-by: Rsplwe <i@rsplwe.com>
 2023-04-01 22:56:15 +08:00
Rsplwe
ccac296821
Adjust the value of 'maxparts' to 1000 
Signed-off-by: Rsplwe <i@rsplwe.com>
 2023-04-01 21:20:52 +08:00
Côme Chilliet
8104d9f5d8
Remove useless coalescing operator on non-null return value 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-01 14:20:26 +02:00
Côme Chilliet
da618c457a
Fix quota typing for 32bits after forward port from 25 
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
 2023-04-01 14:20:25 +02:00
Côme Chilliet
3f84d41226
Silence a warning from psalm with explanation 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-01 14:20:25 +02:00