Commit graph

98 commits

Author SHA1 Message Date
Ferdinand Thiessen
f075051f4a
test: remove testing internal of libraries and test only app code
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-02-10 14:50:41 +01:00
nfebe
b0bf531c19 test(files): Update scrolling tests for new visible buffer behavior
Adjust test assertions to match the new behavior where scrolling is
skipped for files already in the visible buffer. Tests now verify file
existence rather than full visibility for files within the buffer.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2026-02-06 13:04:42 +01:00
Ferdinand Thiessen
aac91a8df9
refactor(files): adjust for files library interfaces
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-02-06 11:46:46 +01:00
Ferdinand Thiessen
904b946611
fix(files): improve handling of copy-move action
1. only show 1 loading toast instead of N for N files in batch
   operation.
2. Reuse more code to reduce duplicated logic.
3. Show the conflict picker once for all files instead of opening a new
   conflict picker for every file to copy / move.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-02-05 23:26:50 +01:00
Ferdinand Thiessen
ed7fb12b3f
test: adjust Cypress tests for refactored files app UI
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-01-22 16:31:48 +01:00
Ferdinand Thiessen
d3813798bf
chore: update @nextcloud/files to v4.0.0-rc.0
- update library
- adjust sidebar tab handling

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-01-16 22:22:57 +01:00
Ferdinand Thiessen
b63aca792f
test: move integration testing of hotkeys to Cypress
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-01-16 18:06:15 +01:00
Ferdinand Thiessen
fd96a32dda
test: adjust cypress tests
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-01-05 02:23:30 +01:00
Ferdinand Thiessen
f9a137ea87
refactor(files): migrate favorite sidebar action to new Sidebar API
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-01-05 02:23:15 +01:00
Ferdinand Thiessen
4a9cdeb01f
refactor!(files): migrate sidebar API to use Node API
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-01-05 02:23:15 +01:00
Ferdinand Thiessen
58fd2d3df8
test(cypress): adjust for breaking changes of @nextcloud/paths
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-12-22 03:04:35 +01:00
Ferdinand Thiessen
82237a8bc9
refactor(files): migrate to new NcForm* components for app settings
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-11-14 13:09:06 +01:00
Ferdinand Thiessen
cfe886a96e
chore: replace cypress-delete-downloads-folder with simple implementation
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-10-22 12:39:59 +02:00
Ferdinand Thiessen
1082dee5a4
chore: migrate Cypress to @nextcloud/e2e-test-server
- chore: use vite preprocessor for Cypress

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-10-22 11:57:17 +02:00
Ferdinand Thiessen
81718a035a
test: adjust cypress tests for changes filter behavior
In https://github.com/nextcloud/server/issues/53038 we changed the
behavior: The filename filter is reset when changing the directory.
So we need to also adjust the Cypress tests.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-10-21 19:38:20 +02:00
Ferdinand Thiessen
3cf210a9a5
chore: ensure no .only is commited in test files
`.only` is only to be used for development, but must not be committed.
Instead failing tests which should be kept for later should be skipped
(`.skip`).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-10-15 16:00:01 +02:00
Ferdinand Thiessen
b3762488e8
test: adjust FilePicker tests to new dialogs version
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-10-15 14:25:10 +02:00
Ferdinand Thiessen
91f3b6b4ee
chore: adjust code to new codestyle
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-10-02 13:19:42 +02:00
skjnldsv
3bdff6b3f5 fix(files): filter non batch actions in header
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-08-22 18:16:09 +00:00
rakekniven
17b4deb800
fix: Update tests
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2025-08-12 15:48:22 +02:00
Ferdinand Thiessen
88be308b06
test(cypress): split helpers for files actions to make tests less flaky
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-08-05 23:49:46 +02:00
skjnldsv
8f3019cf86 fix(files): VirtualList rendering for scrolling calculations
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-07-08 09:23:37 +02:00
Ferdinand Thiessen
3978e056cf
feat(files): search locally in the background while filtering by name
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-07-07 10:52:21 +02:00
Ferdinand Thiessen
275c4404d4
feat(files): allow to configure default view
This allows to configure which view should be the default ("start view")
in the files app, currently either "all files" or "personal files".
But it might be extended to the new home view in the future.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-07-04 18:03:10 +02:00
Ferdinand Thiessen
69275cbda5
feat(files): add "search everywhere" button within the filters row
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-07-04 14:47:21 +02:00
Ferdinand Thiessen
c2d5b4eaf2
test: add e2e tests for files search
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-07-01 19:47:25 +02:00
Ferdinand Thiessen
3796c96e47
fix(files): add plural form for selected nodes
Reported at Transifex:
> This string needs pluralization feature, because in some languages translation of "selected" differs between singular and plural.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-06-18 18:16:16 +02:00
skjnldsv
5974649724 fix(files): highlight previous folder on history up
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-06-03 15:38:25 +00:00
Ferdinand Thiessen
7536b7ef63
test: adjust cypress tests to be less flaky
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-06-01 18:07:23 +02:00
Ferdinand Thiessen
88829b3abf
test: add e2e tests for multiple-files download
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-05 16:03:08 +02:00
skjnldsv
3b85743cf9 fix(cypress): rename select all clear
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-04-24 23:25:23 +02:00
Côme Chilliet
7f132f72ed
fix(tests): Files are sorted by Name by default, no need to click it
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-25 13:06:14 +01:00
Ferdinand Thiessen
35d4e562eb
fix(files): Ensure actions never overflow filename
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-24 11:41:37 +01:00
Ferdinand Thiessen
3dc38fa99f
test(cypress): wait for button to be visible
Instead of just expecting the button in the DOM.
This causes flaky tests with files-renaming.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-19 16:21:22 +01:00
Ferdinand Thiessen
45cfaa1b3b
test: make cypress run in secure context and add WebAuthn tests
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-19 11:57:14 +01:00
Ferdinand Thiessen
9a71e1b8c2
fix(files): also show file list headers on empty views
It is needed, e.g. for the note-to-recipient, that the headers
are also shown when there is no content (yet).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-05 11:15:16 +01:00
Ferdinand Thiessen
0ed7e403e1
test(e2e): adjust trashbin tests to be less flaky
1. Move general files delete action (thats not trashbin app!) to files
   tests.
2. Delete files (move to trashbin) before loading the page so previews
   are not generated so they cannot lock the file.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-03 17:16:57 +01:00
Ferdinand Thiessen
8b36b915fe
fix(files_trashbin): disable bulk download for trashbin
The backend does not allow bulk download within the trashbin,
so we need to disable this also on the frontend.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-28 18:13:24 +01:00
skjnldsv
07cfc843f0 fix(cypress): wait for toast to appear
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-28 16:14:31 +01:00
Ferdinand Thiessen
e712104e58
feat(files): allow to ignore warning to change file type
* Missing pieces of https://github.com/nextcloud/server/issues/46528
  * Add checkbox to not show this dialog again
  * Add user config as suggested by designers in files settings to
    reenable or diable this behavior.
  * Fix behavior of dialog: It says "keep .ext" but it does not keep the
    extension but cancels the operation. From the button label the user
    expects that the operation is continued but with the old extension.
  * Added more test coverage by adding component tests.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-25 02:16:56 +01:00
skjnldsv
11a5330214 fix(cypress): action selector menu lookup
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-20 20:58:52 +01:00
skjnldsv
df005a53f0 chore(files_external): add cypress tests for user credentials action
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-20 20:58:52 +01:00
skjnldsv
99579f0bbc fix(files): do not show extension warning for folders renaming
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-19 15:35:50 +01:00
skjnldsv
4f795e144c fix(files): properly show file not found error
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-18 10:53:23 +01:00
skjnldsv
73e4a13a1c
chore(files): add actions cypress tests
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-07 10:07:00 +01:00
Ferdinand Thiessen
dbc5c10bc4
fix(files): Do not download files with openfile query flag
Instead of downloading files, if there is no other default action,
we should just open the details tab.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-06 02:17:25 +01:00
Ferdinand Thiessen
5530cdd3fd
test(files): Make scrolling tests independent from magic values
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-05 18:40:00 +01:00
Ferdinand Thiessen
d9996b92dc
fix(files): Correctly scroll selected file into view
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-05 18:40:00 +01:00
Christopher Ng
235671de0b chore(cypress): Finish comment
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-02-04 12:22:16 +01:00
Christopher Ng
a447b21805 fix(files): Fix casing
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-02-04 12:22:16 +01:00