Commit graph

203 commits

Author SHA1 Message Date
nfebe
56b79f13d7 fix(unified_search): Reset result limit for new search requests
Before now the result limit is never reset until the page is refreshed.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-05-16 10:28:50 +00:00
nfebe
4c90a9860a fix(unified_search): Maintain non-provider filters when loading more results
Maintain existing non-provider filters (like date and person filters) while
loading more results for a specific provider.

This now works as the provider data passed to the `newResults` array after search
is built dynamically and not manually, the result of a manual build was that the
`provider.filters` properpy which is used in the `find` method was being left out
in the providers pushed into the results array.

Fixes #52081

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-05-16 10:28:50 +00:00
Ferdinand Thiessen
12622a9d2c
fix(unified-search): do not overlap search with button
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-02 13:22:52 +02:00
nfebe
a508699f48 fix(login): Improve CSRF error message for better user understanding
This commit changes the CSRF error message displayed in the login form to
provide more specific information to the user. Instead of the generic less helpful error.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-03-25 16:35:39 +01:00
Ferdinand Thiessen
72d48de6eb fix(login): only show error state on login box if user interacted
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-17 11:00:43 +00:00
nfebe
ab9dbe048e fix(unified-search): filteredProviders now inherits all provider props
The main providers come from both the backend and client side plugins such as `in-folder` search.
The main providers may carry callbacks functions and other information that should be passed to the `filteredProviders`.
This is important because the current code does not make a distinction between `filteredProviders` and `providers`
rightly so, becuase they are the same thing!

Without the mentioned distinction above, sooner or later, we try to access a property on the `filteredProviders` which we
did not transfer with the manual property copy.

----

This fix prevents in-folder search from searching everywhere when "load more results" is clicked; Essentially ignoring the in-folder
search filter.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-02-03 16:04:50 +00:00
nfebe
3324b10307 fix: Use searchFrom property for client side plugins
The client-side plugin `in-folder` uses the `files` provider, this makes it

overlap with the main files provider itself.

This change follows eecda06f1a after it was discovered

that some apps/providers like `dav` use providers from another app like `contacts`

Signed-off-by: nfebe <fenn25.fn@gmail.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2025-01-31 12:01:28 +00:00
SebastianKrupinski
405cd7627c fix: unified search provider id
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2025-01-31 11:40:30 +00:00
nfebe
a6a100ee64 fix(unified-search): Prevent multiple file picker triggers in in-folder search
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2025-01-29 15:57:33 +00:00
nfebe
c680e74a82 fix(unified-search): Use appId for searching
Each provider may search from a particular app so we should use that for searching.

Before this commit, we used `provider.id` instead of `provider.appId` the problem with the previous
approach is that it forces the provider id to be a valid search provider (an app that supports search)
limiting the developers ability to use unique IDs to identify the different providers (especially plugin providers)
inside the places filter.

For example the Files search plugin "In folder" (search in folder plugin) was required to have id as `files` while the
files provider itself already has id as `files`.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-01-29 16:47:21 +01:00
Maksim Sukharev
0f41c35c17 fix(UnifiedSearch): request data only when opening modal
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-01-18 15:16:46 +01:00
nfebe
d2ea5d2a61 feat: Adapt providers disabled property to match user applied filters
Some filters are only available for certain providers, the UI should give the user
a hint to what providers such filters are available in.

Currently, if a filter (date or person) is not support by an a provider, the provider is
blurred out in the places dropdown.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-01-17 11:31:18 +01:00
Ferdinand Thiessen
94262a5c5c fix(core): Do not use v-html for translation output
The content that can be renderered does *not* include HTML (see
`recommended` object).
But `v-html` was used, this is potentially dangerous, even though we
sanitize the translation values, so no urgent harm but better safe than
sorry.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-11-19 09:49:07 +00:00
fenn-cs
c637b23f65 fix(UnifiedSearch): Restore normal dialog size
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-09-02 15:38:21 +01:00
fenn-cs
716b8c896e fix(UnifiedSearch): Focus search input on open
Resolves : https://github.com/nextcloud/server/issues/47056

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-08-20 23:13:31 +02:00
Ferdinand Thiessen
70c6ff9e11 fix(AppMenu): Prevent menu entries from jumping on hover
Only grow and shrink app menu entry if needed

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-14 12:34:37 +00:00
Ferdinand Thiessen
ed16793089
fix: Make focussed app menu entry wider to see full name
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-08 18:24:35 +02:00
Ferdinand Thiessen
7cef884297
fix: Make app menu overflow entries vertically aligned
The `name` property expects a `text` and just adds basically a "heading" for the text,
so lets instead just utilize the default slot.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-07 22:32:04 +02:00
Ferdinand Thiessen
91f78936c9 fix: Ensure app overflow menu is rendered centered
1. Fix app menu overflow button to be centered
2. Ensure the overflow calculation always just removed one element (incl. refactor to use `@vueuse`)
3. Ensure we use 1.5 line height for app menu, otherwise some languages look squashed under the app icon

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-07 21:29:00 +02:00
Sanskar Soni
55bb6ee87e feat(core): add selection for recommended apps
Signed-off-by: Sanskar Soni <sanskarsoni300@gmail.com>
2024-08-06 17:30:15 +02:00
Ferdinand Thiessen
b2d053589a
fix(user_status): Adjust AccountMenu entry for user status
fixup: Adjust to design comments

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-06 09:20:52 +02:00
Ferdinand Thiessen
674805c994
fix(core): Migrate UserMenu / AccountMenu to NcListItem
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-06 09:20:48 +02:00
skjnldsv
3ca6eb5098 fix(core): app menu notification should be in the top right
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-01 08:19:17 +00:00
skjnldsv
b92e0c7c6b fix(core): do not show unread notification on app menu hover
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-07-31 15:30:05 +00:00
skjnldsv
937bb4a539 fix(core): app menu label position and animation
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-31 15:26:07 +00:00
Ferdinand Thiessen
4bcb0734cd
refactor: Fix some linting issues in frontend code
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-19 22:45:13 +02:00
Ferdinand Thiessen
d82565d67d
refactor(core): Split app menu into components
This allows to split one large block of code into three components with each one usecase.
Allowing for better readability and maintainablility.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-10 01:35:24 +02:00
Ferdinand Thiessen
691f570237
chore: Enable ESLint for apps and fix all errors
Nevertheless this causes a huge amount of new warnings.
Previously the shell script for directories to lint was wrong it was generating all app names to lint,
but was missing the `apps/` prefix. Causing only `core` to be linted.

Co-authored-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-09 17:13:30 +02:00
Ferdinand Thiessen
0ff17b857b
fix(UnifiedSearch): Implement design comments and focus input on open
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-27 12:13:14 +02:00
Marco Ambrosini
6ee965f0d9
feat: Add in-app search
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Marco Ambrosini <marcoambrosini@icloud.com>
2024-06-27 12:13:14 +02:00
Ferdinand Thiessen
81ad28f910
chore(deps): Update debounce to 2.1.0
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-23 16:53:10 +02:00
Marcel Müller
f6e6d7a834 fix(login): Prevent submitting the login form multiple times
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2024-06-06 12:00:30 +02:00
Marcel Müller
95148ffe92 fix(login): Disable login button when already logging in
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2024-06-06 12:00:30 +02:00
Ferdinand Thiessen
9d2c3c1164
fix: Adjust dashboard and header menu to use new background colors
fix(UnifiedSearch): Adjust to new background color

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-21 20:36:21 +02:00
Simon L.
3180779404 feat(login-mask): remove Login with from label
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-05-21 09:22:43 +00:00
Christopher Ng
0bd384637a chore(core): Change "username" to "account name"
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-05-17 10:15:46 -07:00
Andy Scherzinger
1f7e2ba599
chore: Add SPDX header
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-13 17:41:36 +02:00
fenn-cs
a51ab473da fix(unifiedSearch): Prevent broken avatars for federated users
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-04-29 01:12:30 +02:00
Ferdinand Thiessen
3880e4c8d7
fix: Use @simplewebauthn for frontend logic
This simplifies the code a lot and fixes errors with the exisiting custom code,
where slightly different base64 values were emitted which are not valid according to the standard.

ref: https://github.com/web-auth/webauthn-framework/issues/510

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-04-16 11:51:03 +02:00
Ferdinand Thiessen
46e78d1b8b
feat: Deprecate OC.dialogs.prompt an replace with Vue implementation
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-04-10 13:51:36 +02:00
Ferdinand Thiessen
3fede00732
feat(login): Clear login form (password) after IDLE timeout
For security reasons it is recommended to stop the login process at a defined time,
this could prevent password leaks by e.g. user forgetting that they entered their password on public devices.

Enforced e.g. by the BSI ORP.4.A13 rule.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-25 12:22:53 +01:00
fenn-cs
2792d8b3f5 feat: Limit email input on auth pages to 255 chars
Excessively long emails reported make server unresponsive.

We could at some point, consider adding a configuration for sysadmins to bypass this setting
on their instance if they want.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-03-21 10:34:55 +01:00
Eduardo Morales
182342decc fix: login page now correctly shows email LDAP settings
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2024-03-10 10:32:22 -05:00
John Molakvoæ
524ed97d62
fix: replace Account name by Login
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-02-13 21:08:10 +01:00
Vincent Petry
839ddaa354
feat: rename users to account or person
Replace translated text in most locations

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2024-02-13 21:06:30 +01:00
Ferdinand Thiessen
0f2b9b09ec
fix(theming): The background is the primary color and must not be double inverted
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-03 14:28:34 +01:00
Simon L
a96a7f0c82 fix header-elements being not shown correctly
Signed-off-by: Simon L <szaimen@e.mail.de>
2024-01-11 22:36:20 +01:00
Christoph Wurst
5198c1ce2b
fix(a11y): Aria-hide contacts menu icon images
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-01-11 15:15:31 +01:00
Eduardo Morales
707c1c0b0b enh(core): replaced previous native a element with NcButton
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2024-01-09 10:33:00 -06:00
Ferdinand Thiessen
fde6914ae1 fix: Adjust colors of app menu and dashboard
Those elements are shown directly on the background which has the `color-primary`,
so they need to use `color-primary-text` instead of `color-primary-element-text` for guranteed contrast.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-12-20 14:53:17 +01:00