Commit graph

546 commits

Author SHA1 Message Date
Julius Knorr
782f42c678
perf(dav): Preload dav search with tags/favorites
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2025-07-02 23:43:18 +02:00
Maxence Lange
20640232ef fix(dav): catch exception on non local account
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-06-25 13:36:11 +00:00
Kate
22848f7725
Update apps/dav/lib/Connector/Sabre/File.php
Signed-off-by: Kate <26026535+provokateurin@users.noreply.github.com>
2025-05-30 16:07:56 +02:00
Robin Appelman
ca432b8157 fix: log error when writing stream to dav file
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-05-30 12:46:32 +00:00
Ferdinand Thiessen
832f79ac93
chore: apply code style
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-30 19:04:59 +02:00
skjnldsv
b658c8519c fix(dav): check the owner displayName scope before giving attribute
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

[skip ci]
2025-04-30 12:39:10 +02:00
Ferdinand Thiessen
744a4394fe fix(dav): allow uploading of files with long filenames
A filename must be less or equal 255 characters, but when adding the
`.part` and `.ocfiletransfer` extensions we might overflow this limit.
So we should also use filename hashes for uploading when the file has a
long filename, similar like when we are uploading to the user storage
directly.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-23 15:19:36 +00:00
Ferdinand Thiessen
95b5fa203f refactor(dav): simplify length header handling
Reduce nesting and drop duplicated sections.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-23 15:19:36 +00:00
Richard Steinmetz
550d8d9fce
fix(oauth2): retain support for legacy ownCloud clients
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-04-02 12:23:45 +02:00
Marcel Klehr
fe0849ebad fix(dav): Give proper HTTP status code on MKCOL when quota exceeded
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-03-31 11:46:42 +00:00
Robin Appelman
e5cca48be6 fix: log which file cannot be opened
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-03-19 14:16:15 +00:00
Andy Scherzinger
76486b7a20
Merge pull request #49840 from nextcloud/revert-49825-revert-49650-backport/49293/stable30
Revert "Revert "[stable30] fix: Handle copy of folders containing live photos""
2025-03-05 16:27:12 +01:00
Louis
acf19f7880
Revert "Revert "[stable30] fix: Handle copy of folders containing live photos""
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-03-05 13:45:23 +01:00
Louis Chemineau
009a7a3368 feat: Support deleting metadata from WebDAV
The `$value` will be `null` if the update is wrapped inside a `<d:remove>...</d:remove>` block.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-03-05 13:39:40 +01:00
Ferdinand Thiessen
01663e67ec
fix(dav): Handle end of stream in File::put
If the stream is aborted and the callback wrapper returns false (or
null as it happened in some cases), we should not try to write to the
storage but abort the operation.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-03 10:09:28 +01:00
Robin Appelman
6cec3eef49 fix: use relative paths for upload locks
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-15 14:42:51 +01:00
Daniel Kesselberg
d7b1ecb881 fix: Replace the TypeError to prevent exposing the installation path
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-02-15 14:42:51 +01:00
Daniel Kesselberg
e8a5e0c392 Revert "fix(dav): Always respond custom error page on exceptions"
This reverts commit 9992e7d439.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-02-15 14:42:51 +01:00
Daniel Kesselberg
44ad5793a3 Revert "fix: Override start method of \Sabre\DAV\Server to remove exception output"
This reverts commit e202896a74.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-02-15 14:42:51 +01:00
Robin Appelman
c6e68988d2 fix: block moving files to it's own parent with dav
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-01-07 09:26:05 +00:00
Louis
cabedbf9c3
Revert "[stable30] fix: Handle copy of folders containing live photos" 2024-12-12 14:28:09 +01:00
Louis Chemineau
3497725235
fix: Throw exception when copy failed
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-12-05 10:48:30 +01:00
Robin Appelman
ca33a62ec6
fix: smuggle storage id to metadata insert queries
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-12-05 10:35:24 +01:00
fenn-cs
2e31d35134 fix(Federation): Show some icon for federated users on shares
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-10-30 15:16:00 +01:00
Louis Chemineau
8bff8d22e2 fix: Override start method of \Sabre\DAV\Server to remove exception output
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-19 14:24:22 +02:00
Anna Larch
ff49395e46 fix(filesreport): cast fileId to integer
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-16 09:09:54 +00:00
Anna Larch
b652b6c60f fix(dav): set string type for sanitizeMtime
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-15 20:45:00 +00:00
Louis Chemineau
23b77dc7ec fix(dav): Always respond custom error page on exceptions
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-05 18:17:10 +00:00
Ferdinand Thiessen
ef3bd03849
fix: Allow read-only filename validation to allow reading files
Needed to read files with the "Windows compatibility" feature.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-28 20:23:54 +02:00
Ferdinand Thiessen
183fcef39b
fix: Renaming does not need update but delete permissions
Renaming is basically copy + delete (a move), so no need to update permissions.
Especially if the node is in a invalid directory the node should be moveable but not editable.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-28 20:23:50 +02:00
Ferdinand Thiessen
e5e3459a54
fix(dav): Pre-check if node can be copied or moved in DAV files plugin
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-28 20:23:42 +02:00
Louis Chemineau
e0c104af09 feat: Delegate is-encrypted handling to the e2ee app
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-08-27 10:34:54 +00:00
Ferdinand Thiessen
4bbcbc5206
feat: Make ISharedStorage public API and reuse where possible
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-12 11:42:10 +02:00
Ferdinand Thiessen
cb1b366baf
fix(dav): Ensure share properties are also set on public remote endpoint
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-12 11:28:03 +02:00
Robin Appelman
d5a2a4aa87
fix: keep previous exception when wrapping dav exceptions
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-07-23 14:23:26 +02:00
Richard Steinmetz
cbea787233
fix(caldav): stricter default calendar checks
Reject calendars that
- are subscriptions
- are not writable
- are shared with a user
- are deleted
- don't support VEVENTs

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-07-22 15:24:39 +02:00
Andy Scherzinger
2e273e477a
Merge pull request #46225 from nextcloud/fix/issue-11633
fix(dav): Thrown forbidden error for authenticated user instead of no…
2024-07-19 18:59:58 +02:00
Ferdinand Thiessen
322b3946d9
fix(dav): Verify target path in setName instead of source path
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-16 12:57:11 +02:00
SebastianKrupinski
f5fcfb4670 fix(dav): Thrown forbidden error for authenticated user instead of not found
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-07-10 17:58:02 -04:00
Julius Härtl
4d6b4b71c7 fix: Authorization header can be an empty string
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-06-28 14:42:36 +02:00
Julius Härtl
637a91e767
Merge pull request #45973 from nextcloud/remove-chunking-v1
chore: remove chunking-v1
2024-06-24 09:52:18 +02:00
Robin Appelman
957a00b9de chore: remove chunking-v1
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-06-19 16:57:42 +02:00
Ferdinand Thiessen
67a0e01382
fix(dav): Try basic auth for ajax WebDAV requests
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-18 10:47:11 +02:00
skjnldsv
4a77fe3530 fix(dav): also return shared-with-me shares data
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-06-12 10:27:29 +02:00
Ferdinand Thiessen
9d0200ca6b
Merge pull request #45120 from nextcloud/bugfix/noid/sensitive-dav-forbidden-logging
fix(dav): Don't log access control as error
2024-06-10 11:56:33 +02:00
Andy Scherzinger
9d4b944098
chore: Add SPDX header
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-27 20:11:22 +02:00
Daniel Kesselberg
e210043ee9
feat(caldav): expose calendar subscriptions
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-05-07 16:03:33 +02:00
Joas Schilling
89bce5c76e
fix(dav): Don't log access control as error
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-04-30 13:46:50 +02:00
Côme Chilliet
d2de3e9981
fix: Fix incorrect phpdoc typing in dav app
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-30 09:24:00 +02:00
Joas Schilling
d2c9cf4b5f
fix(DAV): Migrate known exceptions to Sabre exceptions when copying
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-04-24 07:18:47 +02:00