upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-26 00:27:49 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 29
81712 commits 874 branches 1197 tags 8.4 GiB
Commit graph

397 commits

Author SHA1 Message Date
Louis Chmn
8afe1dd53a fix(encryption): Increment lastChunkNr when size is off 
When computing the unencrypted file size, we need the size of the last encrypted chunk as its size is usually not the regular 8192 bits.

To avoid reading the whole file, we seek directly to that last chunk based on the expected file size. When the expected file size is smaller than the actual one, we have a logic in place to continue reading until we reach the end of the file.

In that logic, we forgot to increment the `$lastChunkNr` which is important when we later check the signature of the chunk.

This commit adds that missing increment.

Signed-off-by: Louis Chmn <louis@chmn.me>
 2025-11-25 09:19:09 +00:00
Robin Appelman
edb370d2ac chore: better type hints for getAvailability 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-11-12 17:45:41 +00:00
Robin Appelman
2221c69219 fix: make failed availability check apply in the same request 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-11-12 17:45:41 +00:00
provokateurin
406c0011fa fix(files): Stop overwriting scan_permissions 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-09-29 16:12:10 +00:00
Côme Chilliet
f1fb150055 fix(encryption): Fix TypeError when trying to decrypt unencrypted file 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-08-26 08:42:58 +02:00
Côme Chilliet
e2861b42d1 fix(encryption): Correctly handle file opening and copying failures 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-07-03 16:03:19 +02:00
Robin Appelman
54338f6d72 fix: create mountpoint folder even if the user has a quota of 0 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-05-15 14:56:10 +02:00
Robin Appelman
b8cbd0f41b
Merge pull request #52764 from nextcloud/backport/52706/stable31 
[stable31] feat: add more encryption checks to info:file
 2025-05-15 14:05:32 +02:00
Robin Appelman
1c5658cd33 feat: add more encryption checks to info:file 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-05-12 11:27:33 +00:00
Robin Appelman
7e454b2d96 fix: throw a better error if we can't get the encrypted header size 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-05-12 11:27:21 +00:00
Robin Appelman
012a402cec fix: restore updated encrypted version when copying versions 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-01-03 15:21:01 +01:00
Robin Appelman
41c53648ad
Merge pull request #49262 from nextcloud/move-from-encryption-no-opt 
fix: don't do same-storage move optimization with encryption wrappers
 2024-12-05 17:42:47 +01:00
Louis
27331d48e3
Merge pull request #48651 from nextcloud/artonge/fix/copy_cache_during_copy_operations 
fix(files): Correctly copy the cache information during copy operations
 2024-12-04 16:58:01 +01:00
Robin Appelman
ae30269eac
fix: don't set 'name' on null metadata 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-12-03 19:12:45 +01:00
Louis Chemineau
199b0bd4d9
fix(files): Correctly copy the cache information on copy operations 
Needed to copy the `encrypted` flag of encrypted files when those files are two level down in a moved folder.

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-12-03 17:04:44 +01:00
Git'Fellow
60d956f39f refactor(storage): Code adjustements and simplifications 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2024-11-21 10:02:00 +01:00
Git'Fellow
8755bf1815 fix(storage): Try to delete existing target 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

Add same logic to common storage
 2024-11-20 09:42:33 +01:00
Robin Appelman
0bc478de2c
fix: don't do same-storage move optimization with encryption wrappers 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-11-13 18:47:13 +01:00
skjnldsv
954b6c68a0 chore: use $this->logger and prevent Server::get 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-11-08 10:56:30 +01:00
Victor Dubiniuk
0f96a2ccb9 Fix Undefined variable: response notice in case of non-404 error 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-11-08 10:56:25 +01:00
John Molakvoæ
e3e22e28c0
Merge pull request #47847 from nextcloud/fix-copying-or-moving-from-shared-groupfolders 2024-10-29 11:33:12 +01:00
provokateurin
0de4843b73 refactor(Storage): Align all Storage constructors 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-23 13:24:18 +02:00
Thomas Citharel
dcd27fd986
feat(http-client): expose default request timeout constant to be used instead of magic number 30 
Will be used to set default where we are able to override the default timeout.

See https://github.com/nextcloud/server/pull/48418

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2024-10-11 10:57:02 +02:00
Daniel Calviño Sánchez
3017951d1d fix: Fix copying or moving from shared groupfolders 
When copying or moving between two local storages the source path (on
disk) to copy or move from is got from the unjailed path of the source
storage. However, if the source storage has more than one jail getting
the unjailed path resolves the most external jail, but the source path
needs to be got from the most internal jail instead (the one closer to
the local storage).

This can happen, for example, with a shared groupfolder: in that case
there is an external jail for the shared storage, and one internal jail
for the groupfolder storage wrapped by the shared storage.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2024-10-10 15:16:12 +02:00
Kate
43b1fd7bb8
Merge pull request #48623 from nextcloud/fix/allow-quota-wrapper-check 2024-10-09 18:39:42 +02:00
Julius Knorr
75381dfe0c
fix: Allow overriding shouldApplyQuota check from child classes 
Signed-off-by: Julius Knorr <jus@bitgrid.net>
 2024-10-09 08:25:30 +02:00
provokateurin
f28e74b7a8
refactor(Storage): Make all parameter types strong types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-07 15:00:05 +02:00
provokateurin
4412b2b8a8
refactor(Wrapper\Encryption): Migrate to strong types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-07 14:11:56 +02:00
Kate
26762172f5
Merge pull request #48454 from nextcloud/fix/storage/get-directory-content-return-type 2024-10-01 16:22:16 +02:00
Robin Appelman
1bf27e74dd
Merge pull request #48235 from nextcloud/readd-object-store-phpunit 
test: re-add object store primary storage phpunit tests
 2024-10-01 15:11:10 +02:00
provokateurin
e1998b6b6c
fix(Storage): Fix getDirectoryContent() return type 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-30 16:49:27 +02:00
Côme Chilliet
6ef05bafeb
fix: Fix test of IConstructableStorage implentation by storage classes 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-30 11:21:42 +02:00
Robin Appelman
888d06dff9
fix: preserve fileid when moving from objectstore to non-objectstore 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-09-27 14:45:42 +02:00
provokateurin
7cdccd058f
fix(Storage): Fix IStorage return types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-26 18:13:03 +02:00
Côme Chilliet
94b0a0e863 fix: Move storage constructor to specific interface 
That allows Wrappers to use DI and not care about the constructor

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-23 09:46:44 +02:00
provokateurin
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-19 14:21:20 +02:00
provokateurin
d2d1e3284d
fix(Storage): Fix method docs inheritance 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-17 10:20:38 +02:00
provokateurin
8ca6fcace7
fix(Storage): Document getOwner() can return false 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-17 10:10:50 +02:00
Côme Chilliet
e7ac9bb2d8
chore: Check storage is an instance of the correct class instead of psalm-suppress 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-16 18:11:39 +02:00
Côme Chilliet
ed0ac284e3
chore: Remove deprecated Storage::search method instead of moving it to IStorage 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-16 18:11:38 +02:00
Côme Chilliet
5d01e0a73c
chore: psalm-suppress legacy code weirdness 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-16 18:11:38 +02:00
Côme Chilliet
492e6997d8
chore: Fix psalm issues, put back private versions of getter in private Storage interface 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-16 18:11:38 +02:00
Côme Chilliet
22822d5e9b
fix: Fix other uses of removed Storage interface 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-16 18:11:36 +02:00
John Molakvoæ
9acaf0788f chore: improve hash_file php usage in Local Storage 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
 2024-09-16 15:07:21 +02:00
Louis Chemineau
6674f790a9 fix(files): Ensure that the hash method does not return null 
To match beececf660/lib/private/Files/View.php (L1050)

- Fix https://github.com/nextcloud/server/issues/44110

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-09-16 15:07:21 +02:00
provokateurin
5bbe535c27
fix(Storage\Local): Do not call getSourcePath() on SplFileInfo 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-15 15:39:09 +02:00
provokateurin
70fa51f042
fix(files): Never return a null ETag in DAV 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-09 10:30:33 +02:00
Git'Fellow
a36738dbfc chore(storage): refactor some code portions 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

chore: revert portion

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2024-09-06 12:44:48 +02:00
Ferdinand Thiessen
17f011f7c5 fix: Also validate parent path in verifyPath 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-08-28 17:22:20 +02:00
Daniel Kesselberg
af6de04e9e
style: update codestyle for coding-standard 1.2.3 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2024-08-25 19:34:58 +02:00