upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-23 23:27:46 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 67
73377 commits 868 branches 1197 tags 8.3 GiB
Commit graph

158 commits

Author SHA1 Message Date
Christoph Wurst
932a385c56
Merge pull request #27429 from nextcloud/bug/26085/wrong-data-add-order-by 
Don't pass a column object to addOrderBy
 2021-06-09 09:12:03 +02:00
Daniel Kesselberg
11cacf63f8
Fix #26085 
addOrderBy expects a order expression. For the migration scenario we have column objects. Column objects are not supported by quoteColumnName yet.

A column object as order expression is most likely an edgy thing when migration database information.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2021-06-08 16:30:44 +02:00
John Molakvoæ (skjnldsv)
215aef3cbd
Update php licenses 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-06-04 22:02:41 +02:00
Roeland Jago Douma
14ee17e5c5
Revert "add a prefix index to filecache.path" 2021-04-08 10:09:13 +02:00
Morris Jobke
ab48d5e8cb
Cleanup unneeded code around database.xml 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2021-03-24 22:15:44 +01:00
Joas Schilling
bb0c50717c
Bye bye database.xml 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-03-24 20:04:12 +01:00
Robin Appelman
b28f0a0e94
add a prefix index to filecache.path 
The reason that `filecache.path` hasn't had an index added is the mysql limitation of ~1kb for indexeded fields,
which is to small for the `path`, however mysql supports indexing only the first N bytes of a column instead of the entire column,
allowing us to add an index even if the column is to long.

Because the index doesn't cover the entire column it can't be used in all situations where a normal index would be used, but it does cover the `path like 'folder/path/%'` queries that are used in various places.

Sqlite and Postgresql don't support prefix indexes, but they also don't have the 1kb limit and DBAL handles the differences in index creation.

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-19 18:52:25 +01:00
Simon Spannagel
244e13cd43
DB conversion: improve console output 
Signed-off-by: Simon Spannagel <simonspa@kth.se>
 2021-03-17 14:35:40 +01:00
Christoph Wurst
c1d4f8161b
Migrate internal classes to the OCP db col types 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-01-12 14:09:13 +01:00
Christoph Wurst
8b64e92b92
Bump doctrine/dbal from 2.12.0 to 3.0.0 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-01-08 11:45:19 +01:00
Christoph Wurst
9ce3ea3368
Update license headers 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-12-30 14:07:05 +01:00
Vincent Petry
bdbec28a8f
Make oc_files_trash.auto_id a bigint 
Adjusted migration.
Added to occ command to update existing tables.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2020-12-23 17:50:50 +01:00
Christoph Wurst
d89a75be0b
Update all license headers for Nextcloud 21 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-12-16 18:48:22 +01:00
Roeland Jago Douma
ccd5ca5476
Merge pull request #23044 from nextcloud/migration-10.5 
Handle owncloud migration to latest release
 2020-12-10 14:32:13 +01:00
Julius Härtl
c77e259cfe
Add missing index on oc_cards and rename if it previously existed 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-12-09 12:13:34 +01:00
Julius Härtl
8f6c2ec357
Move columns to bigint 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-12-08 16:05:53 +01:00
Joas Schilling
d5df033ede
Create primary keys on all tables and add a command to create the afterwards 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-11-10 15:36:27 +01:00
timm2k
3f691c52dc
Update ConvertFilecacheBigInt.php 2020-10-26 09:18:56 +01:00
Joas Schilling
600381f82a
Make the migration template typed 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-10-15 16:08:50 +02:00
Christoph Wurst
d9015a8c94
Format code to a single space around binary operators 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-10-05 20:25:24 +02:00
Robin Appelman
634c051be6
add size index for filecache 
improves performance of #23004

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-09-22 15:15:34 +02:00
Morris Jobke
99c9423766
Remove @suppress SqlInjectionChecker 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-09-16 15:53:56 +02:00
Christoph Wurst
2a054e6c04
Update the license headers for Nextcloud 20 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-08-24 14:54:25 +02:00
Roeland Jago Douma
0157e30ad4
Merge pull request #21599 from nextcloud/debt/noid/type-to-types 
Replace TYPE with TYPES
 2020-07-02 12:21:01 +02:00
Daniel Kesselberg
87dd760a89
Replace TYPE with TYPES 
As TYPE::* is deprecated.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-06-30 23:46:22 +02:00
Joas Schilling
ab21d69903
Add return value to all commands 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-26 14:54:51 +02:00
Mario Danic
6e28c2807b
Add index to properties table 
Signed-off-by: Mario Danic <mario@lovelyhq.com>
 2020-04-30 23:04:15 +02:00
Christoph Wurst
cb057829f7
Update license headers for 19 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-29 11:57:22 +02:00
Christoph Wurst
caff1023ea
Format control structures, classes, methods and function 
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 14:19:56 +02:00
Christoph Wurst
14c996d982
Use elseif instead of else if 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 10:35:09 +02:00
Christoph Wurst
41b5e5923a
Use exactly one empty line after the namespace declaration 
For PSR2

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 11:48:10 +02:00
Joas Schilling
bc6a5ef5c4
Merge pull request #19890 from nextcloud/enh/comments-reference-id 
Add optional comments reference_id
 2020-04-02 11:34:21 +02:00
Christoph Wurst
1a9330cd69
Update the license headers for Nextcloud 19 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-31 14:52:54 +02:00
Joas Schilling
720dc4e93d
Add optional column oc_comments.reference_id 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-03-31 10:51:15 +02:00
Christoph Wurst
6127c288e8 Fix license headers 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-01-13 14:23:49 +01:00
Bernhard Ostertag
6a017eb205
Introduce new variable with the default answer to allow option --no-interaction for command occ db:convert-type 
Variable is set to true for --no-interaction and false otherwise

Signed-off-by: Bernhard Ostertag <bernieo.code@gmx.de>
 2019-12-29 11:03:51 +01:00
Bernhard Ostertag
fe0e47bf5e
enable option '--no-interaction' for db:convert-type 
Signed-off-by: Bernhard Ostertag <bernieo.code@gmx.de>
 2019-12-27 07:50:30 +01:00
Christoph Wurst
1b46621cd3
Update license headers for 18 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-12-20 09:23:25 +01:00
Georg Ehrke
699f3a6817
Convert various columns in oc_mounts to bigint 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
 2019-12-09 14:13:18 +01:00
Christoph Wurst
5bf3d1bb38
Update license headers 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-12-05 15:38:45 +01:00
Roeland Jago Douma
279c0cb2ed
Merge pull request #18098 from nextcloud/fix/migration_import_order 
Fix the import order of new migrations
 2019-11-25 14:11:09 +01:00
Roeland Jago Douma
c7d5b8fc49
Merge pull request #18079 from nextcloud/fixes/phpcs 
Some php-cs fixes
 2019-11-25 14:07:00 +01:00
Roeland Jago Douma
20ec763337
Merge pull request #18027 from str0g/fix/14920/convert_type_boolean 
Incorrect integer value: '' for column 'password_invalid' while migra…
 2019-11-25 11:37:45 +01:00
Roeland Jago Douma
f79d98e089
Fix the import order of new migrations 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-11-25 09:46:39 +01:00
Roeland Jago Douma
68748d4f85
Some php-cs fixes 
* Order the imports
* No leading slash on imports
* Empty line before namespace
* One line per import
* Empty after imports
* Emmpty line at bottom of file

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-11-22 20:52:10 +01:00
Roeland Jago Douma
decdb6b40f
Convert more columns to bigint 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-11-20 19:31:17 +01:00
Łukasz Buśko
23084558a6 Incorrect integer value: '' for column 'password_invalid' while migrating from pg to mysql #14920 
Signed-off-by: Łukasz Buśko <busko.lukasz@pm.me>
 2019-11-20 14:01:46 +01:00
Thomas Citharel
68cf47e947
Check and add index on principaluri for schedulingobjects table 
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2019-10-08 10:25:56 +02:00
Thomas Citharel
90e5850cc4
Add index on calendarid for calendarobject_props table 
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2019-10-07 22:03:15 +02:00
Joas Schilling
592093079f
Deduplicate index names 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-03-27 13:32:59 +01:00
Joas Schilling
274658629d
Make sure all tables have named indexes 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2019-03-27 13:32:59 +01:00
Maxence Lange
8002779200
add support for boolean default 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
code cleaning

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
code cleaning

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2019-01-09 11:21:14 +01:00
Roeland Jago Douma
16cc68a2fe
Add twofactor_providers_uid index 
Fixes #12943

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-12-21 13:03:02 +01:00
Morris Jobke
17b2827bbf
Add setup check for pending bigint conversion 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-12-05 13:42:31 +01:00
Morris Jobke
f57e334f83
Fix bigint conversion on SQLite 
* on SQLite primary keys can't be bigint - see https://stackoverflow.com/a/18835967/520507

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-12-05 00:35:09 +01:00
Morris Jobke
d3b4127164
Show columns to update in CLI interface 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-12-05 00:35:09 +01:00
Joas Schilling
bb352fb667
Use the defined func()->count() instead of manual counting 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-11-08 15:44:45 +01:00
Morris Jobke
4d20c4272f
Fix index names 
* see #11527
 2018-11-06 15:21:16 +01:00
Roeland Jago Douma
b82cbe04df
Add uid_owner and uid_initiator share tabe indices 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-10-01 23:59:36 +02:00
Christoph Wurst
c5cd8d9166
Improve class import and strict typing for generated migration class 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2018-09-07 09:22:57 +02:00
Christoph Wurst
eada4cccfc
Fix generated migration class code 
The `@since` documentation is out of place here.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2018-08-21 07:50:12 +02:00
Morris Jobke
7da815bb04
Merge pull request #10298 from nextcloud/bugfix/talk-714/only-migrate-the-schema-when-moving-database 
Only create the schema when moving between databases
 2018-07-24 16:14:05 +02:00
Robin Appelman
91d3e48ab3
Add filecache index on mtime 
Gives searching by mtime and "recent" a proper index to use

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2018-07-19 17:43:20 +02:00
Joas Schilling
891de38080
Only create the schema when moving between databases 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-07-19 15:32:36 +02:00
Roeland Jago Douma
2f59f389d2
Add parent index to share table 
Fixes #9327

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-06-03 13:36:02 +02:00
Robin Appelman
b40629ac8c
Add human readable description to migration steps 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2018-05-30 21:28:05 +02:00
Roeland Jago Douma
80cc8d0028
Emit event when running ./occ db:add-missing-indices 
This allows apps to listen to this event in order to also update
indecies there.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-05-24 18:03:10 +02:00
Joas Schilling
f772b7b4dd
Add autocomplete to migration commands 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-05-03 16:52:56 +02:00
Alecks Gates
3be2c558a5 Add mtime and storage_mtime to db:convert-filecache-bigint 2018-02-17 09:27:25 -06:00
Joas Schilling
4a5282ba21
Fix the type hints of migrations and correctly inject the wrapped schema into migrations 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-01-17 11:37:36 +01:00
Bjoern Schiessle
41ee23a054
make occ command more generic 
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
 2017-12-18 21:14:45 +01:00
Bjoern Schiessle
fda98ee917
add occ command to add a index to share_with at the share table 
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
 2017-12-18 21:14:45 +01:00
Morris Jobke
0eebff152a
Update license headers 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-11-06 16:56:19 +01:00
Joas Schilling
6acf1d9524
Also update the activity table with this 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-10-13 11:46:50 +02:00
Joas Schilling
e2ec6b33ea
Add a command to manually migrate to big ints 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-10-13 11:42:15 +02:00
Joas Schilling
d5c2b98207
Fix missing "unsigned" on integer columns 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-09-19 20:09:10 +02:00
Joas Schilling
f877096a28
Fix typo in template for migration generation 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-08-09 11:01:08 +02:00
Joas Schilling
b729cc2a02
Add *lob support for all tables 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-07-25 12:49:15 +02:00
Joas Schilling
087138f228
use template placeholders instead of html 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-07-25 12:49:15 +02:00
Joas Schilling
e023899078
Always order by all values, to make sure all entries are copied correctly 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-07-25 12:49:15 +02:00
Joas Schilling
1b7c1ad5c0
Only migrate to the current state 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-07-25 12:49:15 +02:00
Joas Schilling
10d7cbb71f
Use order by to avoid problems when chunking finds a same item again... 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-07-25 12:49:12 +02:00
Joas Schilling
0a0dbbdf15
Remove generate change script which doesnt work with migrations anymore 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-07-25 12:47:39 +02:00
Joas Schilling
3fedfe67b9
Use default connection parameters for utf8 4byte support 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-07-25 12:47:39 +02:00
Joas Schilling
42ed7a18cc
Skip migrations table because it was already done when creating the schema 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-07-25 12:47:39 +02:00
Joas Schilling
1d56b52761
Use migrations on convert 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-07-25 12:47:39 +02:00
Joas Schilling
9307aaee49
Core is converted, so this is dead code 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-07-25 12:47:39 +02:00
Joas Schilling
f6c48b1548
Add a script to generate a migration from database.xml 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-07-25 12:45:38 +02:00
Lukas Reschke
3d2600b039
Add Phan plugin to check for SQL injections 
This adds a phan plugin which checks for SQL injections on code using our QueryBuilder, while it isn't perfect it should already catch most potential issues.

As always, static analysis will sometimes have false positives and this is also here the case. So in some cases the analyzer just doesn't know if something is potential user input or not, thus I had to add some `@suppress SqlInjectionChecker` in front of those potential injections.

The Phan plugin hasn't the most awesome code but it works and I also added a file with test cases.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2017-07-20 22:48:13 +02:00
Joas Schilling
0f275b1550
Only create the migration directory when necessary 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-07-06 09:58:39 +02:00
Joas Schilling
5d9d1b1cb5 Allow to check the schema in pre and post as well 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-07-05 13:01:19 +02:00
Joas Schilling
817783e4c7 Add a version to migrations, so parallel legacy branches can also have migrations 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-07-05 13:01:19 +02:00
Joas Schilling
df6b839b23 Add author and copyright 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-07-05 13:01:19 +02:00
Joas Schilling
8c39e66619 Do not allow to go back on productive systems 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-07-05 13:01:19 +02:00
Joas Schilling
194ef1a171 Adjust the code to use our interface and abstract 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-07-05 13:01:19 +02:00
Joas Schilling
15eec7b83c Start migrations 
Fixme:
- Install and update of apps
- No revert on live systems (debug only)
- Service adjustment to our interface
- Loading via autoloader

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-07-05 13:01:19 +02:00
Thomas Müller
43427e26d7
Add console command to migrate the charset 2017-04-28 09:35:36 +02:00
Joas Schilling
75eee315a3
Use false because null crashes the cache 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-03-26 22:43:19 +02:00
Joas Schilling
2961c735e3
Make sure blob columns are correctly converted as parameters 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-03-26 17:11:57 +02:00
Morris Jobke
8a4466f9ae
Improve error message of charset convert script and behaviour 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-03-23 15:36:22 -06:00