Commit graph

14979 commits

Author SHA1 Message Date
Côme Chilliet
ec85a49cad
chore: Add comment to make code clearer
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:43:44 +01:00
Côme Chilliet
04b6eef246
chore: Turn method description into phpdoc
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2024-12-19 14:43:37 +01:00
Côme Chilliet
c7dbe7e71c
fix(shares): Promote reshares into direct shares when share is deleted
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:43:21 +01:00
Côme Chilliet
16decdede7
fix: Tidy up code for reshare deletion
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:41:50 +01:00
Luka Trovic
024f98a8a1
fix: delete re-shares when deleting the parent share
Note: Removed part about fix command from original PR

Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
(cherry picked from commit 42181c2f49)
2024-12-19 14:39:44 +01:00
skjnldsv
b356cba2a6 fix: make sure we have a valid scheme when testing ocm urls
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-12-17 15:23:59 +01:00
provokateurin
5cc14e2618 fix(View): Catch exceptions when executing mkdir for non-existent parents
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-12-17 09:40:42 +00:00
Git'Fellow
28c6c63cc5 fix(TemplateManager): Make sure TemplateFolder is a Folder
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-12-16 06:05:23 +00:00
SebastianKrupinski
7bf1863545 fix: replace null character when serializing
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-12-13 20:41:06 -05:00
Robin Appelman
68db21f829 fix: improve logic for ensuring join columns are selected for partitioned queries
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-12-12 21:44:05 +00:00
Robin Appelman
f333fbb8f5 fix: handle calling select on partitioned queries with an array of columns
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-12-12 21:44:05 +00:00
Côme Chilliet
ca1e3828aa
fix(shares): Wrap exceptions from password validation to set code to 400
This fixes a regression that bad password returned 403 instead of 400
 because of previous changes.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-12 15:38:18 +01:00
Côme Chilliet
dab953970d
fix(files_sharing): Do not wrap password policy exception into a generic one
Let the controller access the HintException and show the error to the user.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-12 15:38:18 +01:00
Louis
cabedbf9c3
Revert "[stable30] fix: Handle copy of folders containing live photos" 2024-12-12 14:28:09 +01:00
John Molakvoæ
d8c3425878
Merge pull request #49650 from nextcloud/backport/49293/stable30
[stable30] fix: Handle copy of folders containing live photos
2024-12-12 14:19:55 +01:00
John Molakvoæ
00d225aacb
Merge pull request #49165 from nextcloud/backport/48563/stable30 2024-12-12 13:32:37 +01:00
John Molakvoæ
d108a12b0e
Merge pull request #49794 from nextcloud/backport/40394/stable30
[stable30] fix mimetype not being updated when changing file extention on objectstore
2024-12-12 13:19:59 +01:00
Robin Appelman
c3a2d789f1 fix: fix mimetype not being updated when changing file extention on object store
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-12-11 09:00:44 +00:00
Louis Chemineau
9ff3ba7ce0
fix: Correctly create NonExistingFolder during copy
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-12-05 10:35:42 +01:00
Robin Appelman
be7b6a7b1b
test: add some minimal testing for metadata storage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-12-05 10:35:24 +01:00
Robin Appelman
ca33a62ec6
fix: smuggle storage id to metadata insert queries
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-12-05 10:35:24 +01:00
Robin Appelman
46ed8cdfde fix: don't propagate future mtimes
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-12-04 19:14:51 +00:00
Louis Chemineau
97732de328
feat: Use inline password confirmation in external storage settings
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-11-28 13:03:51 +01:00
Christoph Wurst
40e60366fa
Merge pull request #49537 from nextcloud/backport/49523/stable30
[stable30] fix(migration): Decrypt ownCloud secrets v2
2024-11-28 11:28:56 +01:00
Christoph Wurst
b385520f21
fix(migration): Decrypt ownCloud secrets v2
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-11-28 09:43:47 +01:00
Robin Appelman
44727d4862
fix: fix availability wrapper not applying
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-11-26 18:50:00 +01:00
Robin Appelman
3522819624
fix: throw correct exception type when we can't verify if an s3 bucket exists
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-11-26 18:49:56 +01:00
provokateurin
8e9e893d29 fix(OCMDiscoveryService): Also cache error results during discovery
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-25 11:45:52 +00:00
provokateurin
a7f5b452d1
fix(BackgroundJobs): Adjust intervals and time sensitivities
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-25 08:38:58 +01:00
Git'Fellow
003bb0aca4 fix(storage): Try to delete existing target
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-11-21 07:44:43 +01:00
Côme Chilliet
23117a0a04
Merge pull request #49277 from nextcloud/backport/48675/stable30
[stable30] DNS: do not query CNAME if A succeeded already
2024-11-14 14:21:01 +01:00
Julien Veyssier
8f02796a62 fix(textprocessing): accept scheduling a task if there are equivalent taskprocessing providers only
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-11-14 10:59:16 +00:00
georglauterbach
5915d7f7ce fix: remove superflous line
Signed-off-by: georglauterbach <44545919+georglauterbach@users.noreply.github.com>
2024-11-14 10:45:23 +00:00
georglauterbach
c97cb962ee fix: do not query CNAME if A succeeded already
Signed-off-by: georglauterbach <44545919+georglauterbach@users.noreply.github.com>
2024-11-14 10:45:23 +00:00
Richard Steinmetz
442d036ac9
Merge pull request #49098 from nextcloud/backport/48933/stable30
[stable30] Clear pending two factor tokens also from configuration
2024-11-13 10:47:20 +01:00
yemkareems
56ce5d03bd
Merge pull request #49241 from nextcloud/backport/38630/stable30
[stable30] Fix remaining readdir() calls in loops with undesirable false evaluation potential
2024-11-13 15:16:56 +05:30
Arthur Schiwon
b45dc98ba1 fix(Middleware): log deprecation when annotation was actually used
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-11-13 06:29:31 +00:00
Josh Richards
1fc1543a8b
fix: Clean-up some remaining readdir calls with undesirable false evaluation potential
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-11-13 09:11:17 +05:30
Andy Scherzinger
357524dfd2
Merge pull request #49207 from nextcloud/backport/48736/stable30
[stable30] fix: log a warning when we can't build a background job
2024-11-12 11:43:00 +01:00
Robin Appelman
b195ca3920 fix: log a warning when we can't build a background job
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-11-11 16:33:16 +00:00
Victor Dubiniuk
e1df152eb9 Fix Undefined variable: response notice in case of non-404 error
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-08 16:14:47 +00:00
Josh
fa17ed6fb4 fix(tests): Add IpAddressClassifier v6 zone ID test
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-11-07 09:30:06 -05:00
Josh
e7fa55d59f fix(net): Add IPv6 zone handling to IpAddressClassifier
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-11-06 08:19:56 +00:00
Josh
5fd9c03d18 fix(security): Handle IPv6 zone IDs used in link-local addresses
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-11-06 08:19:56 +00:00
Josh
b059bc970b fix(security): Handle IPv6 zone IDs used in link-local addresses
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-11-06 08:19:56 +00:00
Daniel Calviño Sánchez
fcefd37a5f fix: Handle exception when clearing previously removed two factor tokens
If a token was already removed from the database but not from the
configuration clearing the tokens will try to remove it again from the
database, which caused a DoesNotExistException to be thrown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-11-05 10:50:29 +00:00
Daniel Calviño Sánchez
c7b5c3e02f fix: Clear pending two factor tokens also from configuration
Otherwise as the tokens were removed from the database but not from the
configuration the next time that the tokens were cleared the previous
tokens were still got from the configuration, and trying to remove them
again from the database ended in a DoesNotExistException being thrown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-11-05 10:50:29 +00:00
Benjamin Gaussorgues
33f8caf274
Merge pull request #49076 from nextcloud/backport/49075/stable30 2024-11-04 21:33:19 +01:00
Joas Schilling
8b5964c0bd
fix(owncloud): Fix ownCloud migration with oauth2 app
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-11-04 14:24:16 +01:00
Joas Schilling
849b205b59 fix(appinfo): Make sure screenshot, author and category are always arrays
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-11-01 14:48:33 +00:00